ahmido
2bf5de4663
Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
85 lines
2.6 KiB
PHP
85 lines
2.6 KiB
PHP
<?php
|
|
|
|
use App\Filament\Resources\EntraGroupSyncRunResource;
|
|
use App\Filament\Resources\EntraGroupSyncRunResource\Pages\ListEntraGroupSyncRuns;
|
|
use App\Models\EntraGroupSyncRun;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Http;
|
|
use Illuminate\Support\Facades\Queue;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function (): void {
|
|
Http::preventStrayRequests();
|
|
});
|
|
|
|
test('entra group sync runs are listed for the active tenant', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$otherTenant = Tenant::factory()->create();
|
|
|
|
EntraGroupSyncRun::query()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'selection_key' => 'groups-v1:all',
|
|
'slot_key' => 'slot-a',
|
|
'status' => EntraGroupSyncRun::STATUS_SUCCEEDED,
|
|
]);
|
|
|
|
EntraGroupSyncRun::query()->create([
|
|
'tenant_id' => $otherTenant->getKey(),
|
|
'selection_key' => 'groups-v1:all',
|
|
'slot_key' => 'slot-b',
|
|
'status' => EntraGroupSyncRun::STATUS_SUCCEEDED,
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->get(EntraGroupSyncRunResource::getUrl('index', tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('slot-a')
|
|
->assertDontSee('slot-b');
|
|
});
|
|
|
|
test('entra group sync run view is forbidden cross-tenant (403)', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create([
|
|
'workspace_id' => $tenantA->workspace_id,
|
|
]);
|
|
|
|
$runB = EntraGroupSyncRun::query()->create([
|
|
'tenant_id' => $tenantB->getKey(),
|
|
'selection_key' => 'groups-v1:all',
|
|
'slot_key' => null,
|
|
'status' => EntraGroupSyncRun::STATUS_SUCCEEDED,
|
|
]);
|
|
|
|
$user = User::factory()->create();
|
|
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, user: $user, role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->get(EntraGroupSyncRunResource::getUrl('view', ['record' => $runB], tenant: $tenantA))
|
|
->assertForbidden();
|
|
});
|
|
|
|
test('legacy sync runs list is read-only (no sync action)', function () {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$component = Livewire::test(ListEntraGroupSyncRuns::class)->instance();
|
|
$action = $component->getAction([['name' => 'sync_groups']]);
|
|
|
|
expect($action)->toBeNull();
|
|
|
|
Queue::assertNothingPushed();
|
|
});
|