ahmido
9f5c99317b
## Summary - Fixes misleading “queued / running in background” message when Review Pack generation request reuses an existing ready pack (fingerprint dedupe). - Improves resilience of Filament/Livewire interactions by ensuring the Livewire intercept shim applies after Livewire initializes. - Aligns Review Pack operation notifications with Ops-UX patterns (queued + completed notifications) and removes the old ReviewPackStatusNotification. ## Key Changes - Review Pack generate action now: - Shows queued toast only when a new pack is actually created/queued. - Shows a “Review pack already available” success notification with a link when dedupe returns an existing pack. ## Tests - `vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackGenerationTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackResourceTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/LivewireInterceptShimTest.php` ## Notes - No global search behavior changes for ReviewPacks (still excluded). - Destructive actions remain confirmation-gated (`->requiresConfirmation()`). Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #133
44 lines
1.3 KiB
PHP
44 lines
1.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Http\Controllers;
|
|
|
|
use App\Models\ReviewPack;
|
|
use App\Support\ReviewPackStatus;
|
|
use Illuminate\Http\Request;
|
|
use Illuminate\Support\Facades\Storage;
|
|
use Symfony\Component\HttpFoundation\StreamedResponse;
|
|
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
|
|
|
|
class ReviewPackDownloadController extends Controller
|
|
{
|
|
public function __invoke(Request $request, ReviewPack $reviewPack): StreamedResponse
|
|
{
|
|
if ($reviewPack->status !== ReviewPackStatus::Ready->value) {
|
|
throw new NotFoundHttpException;
|
|
}
|
|
|
|
if ($reviewPack->expires_at && $reviewPack->expires_at->isPast()) {
|
|
throw new NotFoundHttpException;
|
|
}
|
|
|
|
$disk = Storage::disk($reviewPack->file_disk ?? 'exports');
|
|
|
|
if (! $disk->exists($reviewPack->file_path)) {
|
|
throw new NotFoundHttpException;
|
|
}
|
|
|
|
$tenant = $reviewPack->tenant;
|
|
$filename = sprintf(
|
|
'review-pack-%s-%s.zip',
|
|
$tenant?->external_id ?? 'unknown',
|
|
$reviewPack->generated_at?->format('Y-m-d') ?? now()->format('Y-m-d'),
|
|
);
|
|
|
|
return $disk->download($reviewPack->file_path, $filename, [
|
|
'X-Review-Pack-SHA256' => $reviewPack->sha256 ?? '',
|
|
]);
|
|
}
|
|
}
|