ahmido
2bf5de4663
Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
60 lines
1.9 KiB
PHP
60 lines
1.9 KiB
PHP
<?php
|
|
|
|
use App\Models\Tenant;
|
|
use App\Services\OperationRunService;
|
|
use Illuminate\Notifications\DatabaseNotification;
|
|
|
|
it('sanitizes persisted run failures and terminal notifications', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
/** @var OperationRunService $runs */
|
|
$runs = app(OperationRunService::class);
|
|
|
|
$run = $runs->ensureRun(
|
|
tenant: $tenant,
|
|
type: 'test.sanitize',
|
|
inputs: [],
|
|
initiator: $user,
|
|
);
|
|
|
|
$rawBearer = 'Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.'.str_repeat('A', 90);
|
|
|
|
$runs->updateRun(
|
|
$run,
|
|
status: 'completed',
|
|
outcome: 'failed',
|
|
failures: [[
|
|
'code' => 'graph_forbidden',
|
|
'message' => "Authorization: {$rawBearer} client_secret=supersecret user=test.user@example.com",
|
|
]],
|
|
);
|
|
|
|
$run->refresh();
|
|
|
|
$failureSummaryJson = json_encode($run->failure_summary, JSON_THROW_ON_ERROR);
|
|
|
|
expect($failureSummaryJson)->not->toContain('client_secret=supersecret');
|
|
expect($failureSummaryJson)->not->toContain($rawBearer);
|
|
expect($failureSummaryJson)->not->toContain('test.user@example.com');
|
|
|
|
expect($run->failure_summary[0]['reason_code'] ?? null)->toBe('provider_permission_denied');
|
|
|
|
$notification = DatabaseNotification::query()
|
|
->where('notifiable_id', $user->getKey())
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($notification)->not->toBeNull();
|
|
|
|
$notificationJson = json_encode($notification?->data, JSON_THROW_ON_ERROR);
|
|
|
|
expect($notificationJson)->not->toContain('client_secret=supersecret');
|
|
expect($notificationJson)->not->toContain($rawBearer);
|
|
expect($notificationJson)->not->toContain('test.user@example.com');
|
|
|
|
$this->actingAs($user)
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertSuccessful();
|
|
});
|