## Summary - align operator-visible OperationRun terminology to canonical `Operations` / `Operation` labels across shared links, notifications, verification/onboarding surfaces, summary widgets, and monitoring/detail pages - add the Spec 171 planning artifacts under `specs/171-operations-naming-consolidation/` - close the remaining tenant dashboard and admin copy drift found during browser smoke validation ## Validation - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && vendor/bin/sail artisan test --compact tests/Unit/Support/RelatedNavigationResolverTest.php tests/Unit/Support/References/RelatedContextReferenceAdapterTest.php tests/Feature/OpsUx/NotificationViewRunLinkTest.php tests/Feature/Guards/ActionSurfaceContractTest.php tests/Feature/Operations/TenantlessOperationRunViewerTest.php tests/Feature/Filament/BackupSetResolvedReferencePresentationTest.php tests/Feature/Filament/TenantVerificationReportWidgetTest.php tests/Feature/Onboarding/OnboardingVerificationTest.php tests/Feature/Onboarding/OnboardingVerificationClustersTest.php tests/Feature/Onboarding/OnboardingVerificationV1_5UxTest.php tests/Feature/Filament/BaselineCompareSummaryConsistencyTest.php tests/Feature/Filament/WorkspaceOverviewContentTest.php tests/Feature/Filament/RecentOperationsSummaryWidgetTest.php tests/Feature/Monitoring/OperationLifecycleAggregateVisibilityTest.php tests/Feature/System/Spec114/OpsTriageActionsTest.php tests/Feature/System/Spec114/OpsFailuresViewTest.php tests/Feature/System/Spec114/OpsStuckViewTest.php` - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && vendor/bin/sail artisan test --compact tests/Browser/OnboardingDraftRefreshTest.php` - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && vendor/bin/sail bin pint --dirty --format agent` ## Notes - no schema or route renames - Filament / Livewire surface behavior stays within the existing admin and tenant panels - OperationRunResource remains excluded from global search Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #202
92 lines
3.6 KiB
PHP
92 lines
3.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\Badges\BadgeCatalog;
|
|
use App\Support\Badges\BadgeDomain;
|
|
|
|
it('maps operation run status values to canonical badge semantics', function (): void {
|
|
$queued = BadgeCatalog::spec(BadgeDomain::OperationRunStatus, 'queued');
|
|
expect($queued->label)->toBe('Queued for execution');
|
|
expect($queued->color)->toBe('info');
|
|
|
|
$running = BadgeCatalog::spec(BadgeDomain::OperationRunStatus, 'running');
|
|
expect($running->label)->toBe('In progress');
|
|
expect($running->color)->toBe('info');
|
|
|
|
$completed = BadgeCatalog::spec(BadgeDomain::OperationRunStatus, 'completed');
|
|
expect($completed->label)->toBe('Operation finished');
|
|
expect($completed->color)->toBe('gray');
|
|
|
|
$stale = BadgeCatalog::spec(BadgeDomain::OperationRunStatus, [
|
|
'status' => 'running',
|
|
'freshness_state' => 'likely_stale',
|
|
]);
|
|
expect($stale->label)->toBe('Likely stale');
|
|
expect($stale->color)->toBe('warning');
|
|
|
|
$completedArray = BadgeCatalog::spec(BadgeDomain::OperationRunStatus, [
|
|
'status' => 'completed',
|
|
'freshness_state' => 'terminal_normal',
|
|
]);
|
|
expect($completedArray->label)->toBe('Operation finished');
|
|
expect($completedArray->color)->toBe('gray');
|
|
});
|
|
|
|
it('maps operation run outcome values to canonical badge semantics', function (): void {
|
|
$pending = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'pending');
|
|
expect($pending->label)->toBe('Awaiting result');
|
|
expect($pending->color)->toBe('gray');
|
|
|
|
$succeeded = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'succeeded');
|
|
expect($succeeded->label)->toBe('Completed successfully');
|
|
expect($succeeded->color)->toBe('success');
|
|
|
|
$partial = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'partially_succeeded');
|
|
expect($partial->label)->toBe('Completed with follow-up');
|
|
expect($partial->color)->toBe('warning');
|
|
|
|
$blocked = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'blocked');
|
|
expect($blocked->label)->toBe('Blocked by prerequisite');
|
|
expect($blocked->color)->toBe('warning');
|
|
|
|
$failed = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'failed');
|
|
expect($failed->label)->toBe('Execution failed');
|
|
expect($failed->color)->toBe('danger');
|
|
|
|
$reconciled = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, [
|
|
'outcome' => 'failed',
|
|
'freshness_state' => 'reconciled_failed',
|
|
]);
|
|
expect($reconciled->label)->toBe('Reconciled failed');
|
|
expect($reconciled->color)->toBe('danger');
|
|
|
|
$cancelled = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'cancelled');
|
|
expect($cancelled->label)->toBe('Cancelled');
|
|
expect($cancelled->color)->toBe('gray');
|
|
});
|
|
|
|
it('normalizes missing operation run outcomes from lifecycle context', function (): void {
|
|
$stalePending = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, [
|
|
'outcome' => '',
|
|
'status' => 'running',
|
|
'freshness_state' => 'likely_stale',
|
|
]);
|
|
expect($stalePending->label)->toBe('Awaiting result');
|
|
expect($stalePending->color)->toBe('gray');
|
|
|
|
$reconciledFailed = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, [
|
|
'outcome' => '',
|
|
'status' => 'completed',
|
|
'freshness_state' => 'reconciled_failed',
|
|
]);
|
|
expect($reconciledFailed->label)->toBe('Reconciled failed');
|
|
expect($reconciledFailed->color)->toBe('danger');
|
|
});
|
|
|
|
it('never represents a success outcome with warning/attention meaning', function (): void {
|
|
$succeeded = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'succeeded');
|
|
|
|
expect($succeeded->color)->not->toBe('warning');
|
|
});
|