ahmido
1b88d28739
## Summary - align operator-visible OperationRun terminology to canonical `Operations` / `Operation` labels across shared links, notifications, verification/onboarding surfaces, summary widgets, and monitoring/detail pages - add the Spec 171 planning artifacts under `specs/171-operations-naming-consolidation/` - close the remaining tenant dashboard and admin copy drift found during browser smoke validation ## Validation - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && vendor/bin/sail artisan test --compact tests/Unit/Support/RelatedNavigationResolverTest.php tests/Unit/Support/References/RelatedContextReferenceAdapterTest.php tests/Feature/OpsUx/NotificationViewRunLinkTest.php tests/Feature/Guards/ActionSurfaceContractTest.php tests/Feature/Operations/TenantlessOperationRunViewerTest.php tests/Feature/Filament/BackupSetResolvedReferencePresentationTest.php tests/Feature/Filament/TenantVerificationReportWidgetTest.php tests/Feature/Onboarding/OnboardingVerificationTest.php tests/Feature/Onboarding/OnboardingVerificationClustersTest.php tests/Feature/Onboarding/OnboardingVerificationV1_5UxTest.php tests/Feature/Filament/BaselineCompareSummaryConsistencyTest.php tests/Feature/Filament/WorkspaceOverviewContentTest.php tests/Feature/Filament/RecentOperationsSummaryWidgetTest.php tests/Feature/Monitoring/OperationLifecycleAggregateVisibilityTest.php tests/Feature/System/Spec114/OpsTriageActionsTest.php tests/Feature/System/Spec114/OpsFailuresViewTest.php tests/Feature/System/Spec114/OpsStuckViewTest.php` - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && vendor/bin/sail artisan test --compact tests/Browser/OnboardingDraftRefreshTest.php` - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && vendor/bin/sail bin pint --dirty --format agent` ## Notes - no schema or route renames - Filament / Livewire surface behavior stays within the existing admin and tenant panels - OperationRunResource remains excluded from global search Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #202
75 lines
3.1 KiB
PHP
75 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\Navigation\NavigationMatrixRule;
|
|
use App\Support\Navigation\RelatedActionLabelCatalog;
|
|
use App\Support\References\ReferenceClass;
|
|
use App\Support\References\ReferenceLinkTarget;
|
|
use App\Support\References\ReferenceResolutionState;
|
|
use App\Support\References\ReferenceStatePresenter;
|
|
use App\Support\References\ReferenceTechnicalDetail;
|
|
use App\Support\References\ReferenceTypeLabelCatalog;
|
|
use App\Support\References\RelatedContextReferenceAdapter;
|
|
use App\Support\References\ResolvedReference;
|
|
use App\Support\References\ResolvedReferencePresenter;
|
|
|
|
it('adapts a resolved reference into a related context entry payload', function (): void {
|
|
$adapter = new RelatedContextReferenceAdapter(
|
|
new RelatedActionLabelCatalog,
|
|
new ResolvedReferencePresenter(new ReferenceTypeLabelCatalog, new ReferenceStatePresenter),
|
|
);
|
|
|
|
$entry = $adapter->adapt(
|
|
new NavigationMatrixRule('finding', 'detail_section', 'source_run', 'operation_run', 'canonical_page', 10),
|
|
new ResolvedReference(
|
|
referenceClass: ReferenceClass::OperationRun,
|
|
rawIdentifier: '44',
|
|
primaryLabel: 'Baseline compare',
|
|
secondaryLabel: 'Operation #44',
|
|
state: ReferenceResolutionState::Resolved,
|
|
stateLabel: null,
|
|
linkTarget: new ReferenceLinkTarget(
|
|
targetKind: ReferenceClass::OperationRun->value,
|
|
url: '/admin/operations/44',
|
|
actionLabel: 'Open operation',
|
|
contextBadge: 'Tenant context',
|
|
),
|
|
technicalDetail: ReferenceTechnicalDetail::forIdentifier('44'),
|
|
),
|
|
);
|
|
|
|
expect($entry)->not->toBeNull()
|
|
->and($entry?->targetUrl)->toBe('/admin/operations/44')
|
|
->and($entry?->secondaryValue)->toBe('Operation #44 · ID 44')
|
|
->and($entry?->actionLabel)->toBe('Open operation')
|
|
->and($entry?->reference)->not->toBeNull()
|
|
->and($entry?->reference['typeLabel'])->toBe('Operation')
|
|
->and($entry?->reference['secondaryLabel'])->toBe('Operation #44')
|
|
->and($entry?->reference['stateLabel'])->toBe('Resolved')
|
|
->and($entry?->reference['showStateBadge'])->toBeFalse();
|
|
});
|
|
|
|
it('respects hide policies for degraded references', function (): void {
|
|
$adapter = new RelatedContextReferenceAdapter(
|
|
new RelatedActionLabelCatalog,
|
|
new ResolvedReferencePresenter(new ReferenceTypeLabelCatalog, new ReferenceStatePresenter),
|
|
);
|
|
|
|
$entry = $adapter->adapt(
|
|
new NavigationMatrixRule('finding', 'list_row', 'baseline_snapshot', 'baseline_snapshot', 'direct_record', 10, missingStatePolicy: 'hide'),
|
|
new ResolvedReference(
|
|
referenceClass: ReferenceClass::BaselineSnapshot,
|
|
rawIdentifier: '88',
|
|
primaryLabel: 'Baseline snapshot',
|
|
secondaryLabel: null,
|
|
state: ReferenceResolutionState::Inaccessible,
|
|
stateLabel: null,
|
|
linkTarget: null,
|
|
technicalDetail: ReferenceTechnicalDetail::forIdentifier('88'),
|
|
),
|
|
);
|
|
|
|
expect($entry)->toBeNull();
|
|
});
|