ahmido
1cd8d48474
## Summary - cut over `EntraGroupResource` to an environment-bound admin Directory Groups surface in the workspace-first runtime - adopt workspace-scoped admin list/detail URLs and add the bounded `Directory > Groups` navigation entry in the admin panel - keep workspace-home navigation clean while preserving existing scoped list, detail, and global-search behavior - update focused feature coverage and add a browser smoke for the rendered sidebar drilldown path - include the Spec 303 package under `specs/303-admin-directory-groups-cutover/` ## Testing - updated focused Pest coverage for admin navigation segregation, Entra group admin scoping, Entra group global search scoping, and directory group browsing - added browser smoke coverage in `apps/platform/tests/Browser/Spec303AdminDirectoryGroupsCutoverSmokeTest.php` ## Filament / Runtime Notes - remains compliant with Filament v5 on Livewire v4 - no provider registration changes; provider registration location remains `apps/platform/bootstrap/providers.php` - `EntraGroupResource` remains eligible for global search because it has a View page - no destructive actions were added or changed; confirmation and authorization behavior is unchanged - no asset registration changes; existing `cd apps/platform && php artisan filament:assets` deploy posture is unchanged Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #358
126 lines
3.9 KiB
PHP
126 lines
3.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\EntraGroupResource;
|
|
use App\Models\EntraGroup;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
function entraGroupSearchTitles($results): array
|
|
{
|
|
return collect($results)->map(fn ($result): string => (string) $result->title)->all();
|
|
}
|
|
|
|
it('returns no admin global-search results without canonical tenant context', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
EntraGroup::factory()->for($tenant)->create([
|
|
'display_name' => 'Admin search group',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setCurrentPanel('admin');
|
|
Filament::setTenant(null, true);
|
|
Filament::bootCurrentPanel();
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
|
|
|
expect(EntraGroupResource::getGlobalSearchResults('Admin search'))
|
|
->toHaveCount(0);
|
|
});
|
|
|
|
it('scopes admin global-search results to the remembered tenant context', function (): void {
|
|
$tenantA = ManagedEnvironment::factory()->create();
|
|
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
|
|
|
|
$tenantB = ManagedEnvironment::factory()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
|
|
|
|
$tenantC = ManagedEnvironment::factory()->create();
|
|
createUserWithTenant(tenant: $tenantC, user: $user, role: 'owner');
|
|
|
|
$groupA = EntraGroup::factory()->for($tenantA)->create([
|
|
'display_name' => 'Remembered search group',
|
|
]);
|
|
|
|
EntraGroup::factory()->for($tenantB)->create([
|
|
'display_name' => 'Other search group',
|
|
]);
|
|
|
|
EntraGroup::factory()->for($tenantC)->create([
|
|
'display_name' => 'Other workspace search group',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setCurrentPanel('admin');
|
|
Filament::setTenant(null, true);
|
|
Filament::bootCurrentPanel();
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenantA->workspace_id);
|
|
session()->put(WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY, [
|
|
(string) $tenantA->workspace_id => (int) $tenantA->getKey(),
|
|
]);
|
|
|
|
$results = EntraGroupResource::getGlobalSearchResults('search group');
|
|
|
|
expect(entraGroupSearchTitles($results))->toBe([
|
|
'Remembered search group',
|
|
]);
|
|
|
|
$url = $results->first()?->url;
|
|
|
|
expect($url)
|
|
->toBe(EntraGroupResource::getUrl('view', ['record' => $groupA], panel: 'admin', tenant: $tenantA))
|
|
->not->toContain('/admin/t/');
|
|
|
|
$this->get($url)->assertOk();
|
|
});
|
|
|
|
it('keeps tenant-panel global-search results panel-native', function (): void {
|
|
$tenantA = ManagedEnvironment::factory()->create();
|
|
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
|
|
|
|
$tenantB = ManagedEnvironment::factory()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
|
|
|
|
$groupA = EntraGroup::factory()->for($tenantA)->create([
|
|
'display_name' => 'ManagedEnvironment panel group',
|
|
]);
|
|
|
|
EntraGroup::factory()->for($tenantB)->create([
|
|
'display_name' => 'ManagedEnvironment panel outsider',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setCurrentPanel('tenant');
|
|
Filament::setTenant($tenantA, true);
|
|
Filament::bootCurrentPanel();
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenantA->workspace_id);
|
|
|
|
$results = EntraGroupResource::getGlobalSearchResults('ManagedEnvironment panel');
|
|
|
|
expect(entraGroupSearchTitles($results))->toBe([
|
|
'ManagedEnvironment panel group',
|
|
]);
|
|
|
|
$url = $results->first()?->url;
|
|
|
|
expect($url)
|
|
->toBe(EntraGroupResource::getUrl('view', ['record' => $groupA], panel: 'admin', tenant: $tenantA))
|
|
->not->toContain('/admin/t/');
|
|
|
|
$this->get($url)->assertOk();
|
|
});
|