## Summary - replace the legacy Tenant and TenantMembership core models with ManagedEnvironment and ManagedEnvironmentMembership - propagate the managed environment naming and key changes across Filament resources, pages, controllers, jobs, models, and supporting runtime paths - add feature 279 spec artifacts and focused managed-environment test coverage for model behavior, route binding, panel context, authorization, and legacy guardrails ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentAuthorizationTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentPanelContextTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentRouteBindingTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentContextResolverTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentModelTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - branch pushed from commit `1123b122` - browser smoke test file was added but not run in this pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #335
106 lines
4.0 KiB
PHP
106 lines
4.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\InventoryCoverage;
|
|
use App\Filament\Resources\InventoryItemResource;
|
|
use App\Models\InventoryItem;
|
|
use App\Models\OperationRun;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Support\Inventory\InventoryCoverage as InventoryCoveragePayload;
|
|
use App\Support\OperationRunLinks;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
function seedCoverageBasisRun(ManagedEnvironment $tenant): OperationRun
|
|
{
|
|
return OperationRun::factory()->create([
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'inventory_sync',
|
|
'status' => 'completed',
|
|
'outcome' => 'failed',
|
|
'context' => [
|
|
'inventory' => [
|
|
'coverage' => InventoryCoveragePayload::buildPayload([
|
|
'deviceConfiguration' => [
|
|
'status' => InventoryCoveragePayload::StatusFailed,
|
|
'item_count' => 0,
|
|
'error_code' => 'graph_forbidden',
|
|
],
|
|
], []),
|
|
],
|
|
],
|
|
'completed_at' => now(),
|
|
]);
|
|
}
|
|
|
|
it('shows the basis run and tenant-scoped history path on the coverage report for authorized viewers', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$run = seedCoverageBasisRun($tenant);
|
|
|
|
$historyUrl = OperationRunLinks::index($tenant, operationType: 'inventory_sync');
|
|
|
|
$this->actingAs($user)
|
|
->get(InventoryCoverage::getUrl(tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('Latest coverage-bearing sync completed')
|
|
->assertSee('Open basis run')
|
|
->assertSee(OperationRunLinks::view($run, $tenant), false)
|
|
->assertSee($historyUrl, false)
|
|
->assertSee('Review the cited inventory sync to inspect provider or permission issues in detail.');
|
|
});
|
|
|
|
it('degrades basis-run links safely for viewers who cannot open inventory-sync runs', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'readonly');
|
|
|
|
seedCoverageBasisRun($tenant);
|
|
|
|
$this->actingAs($user)
|
|
->get(InventoryCoverage::getUrl(tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('The coverage basis is current, but your role cannot open the cited run detail.')
|
|
->assertDontSee('Open basis run');
|
|
|
|
$this->actingAs($user)
|
|
->get(InventoryItemResource::getUrl('index', tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('Latest run detail is not available with your current role.')
|
|
->assertDontSee('Open basis run');
|
|
});
|
|
|
|
it('shows the last inventory sync as a canonical admin operation detail link', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->forTenant($tenant)->create([
|
|
'type' => 'inventory_sync',
|
|
]);
|
|
|
|
$item = InventoryItem::factory()->create([
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'last_seen_operation_run_id' => (int) $run->getKey(),
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->get(InventoryItemResource::getUrl('view', ['record' => $item], tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('Last inventory sync')
|
|
->assertSee(OperationRunLinks::view($run, $tenant), false);
|
|
});
|
|
|
|
it('keeps the no-basis fallback explicit on the inventory items list', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->get(InventoryItemResource::getUrl('index', tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('No current result')
|
|
->assertSee('Run Inventory Sync from Inventory Items to establish current coverage truth.');
|
|
});
|