Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
197 lines
6.1 KiB
PHP
197 lines
6.1 KiB
PHP
<?php
|
|
|
|
namespace App\Console\Commands;
|
|
|
|
use App\Models\AuditLog;
|
|
use App\Models\BackupItem;
|
|
use App\Models\BackupSchedule;
|
|
use App\Models\BackupSet;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Models\RestoreRun;
|
|
use App\Models\Tenant;
|
|
use Illuminate\Console\Command;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Illuminate\Support\Str;
|
|
use RuntimeException;
|
|
|
|
class TenantpilotPurgeNonPersistentData extends Command
|
|
{
|
|
/**
|
|
* The name and signature of the console command.
|
|
*
|
|
* @var string
|
|
*/
|
|
protected $signature = 'tenantpilot:purge-nonpersistent
|
|
{tenant? : Tenant id / tenant_id / external_id (defaults to current tenant)}
|
|
{--all : Purge for all tenants}
|
|
{--force : Actually delete rows}';
|
|
|
|
/**
|
|
* The console command description.
|
|
*
|
|
* @var string
|
|
*/
|
|
protected $description = 'Permanently delete non-persistent (regeneratable) tenant data like policies, backups, runs, and logs.';
|
|
|
|
/**
|
|
* Execute the console command.
|
|
*/
|
|
public function handle(): int
|
|
{
|
|
$tenants = $this->resolveTenants();
|
|
|
|
if ($tenants->isEmpty()) {
|
|
$this->error('No tenants selected. Provide {tenant} or use --all.');
|
|
|
|
return self::FAILURE;
|
|
}
|
|
|
|
$isDryRun = ! (bool) $this->option('force');
|
|
|
|
if ($isDryRun) {
|
|
$this->warn('Dry run: no rows will be deleted. Re-run with --force to apply.');
|
|
} else {
|
|
$this->warn('This will PERMANENTLY delete non-persistent tenant data.');
|
|
|
|
if ($this->input->isInteractive() && ! $this->confirm('Proceed?', false)) {
|
|
$this->info('Aborted.');
|
|
|
|
return self::SUCCESS;
|
|
}
|
|
}
|
|
|
|
foreach ($tenants as $tenant) {
|
|
$counts = $this->countsForTenant($tenant);
|
|
|
|
$this->line('');
|
|
$this->info("Tenant: {$tenant->id} ({$tenant->name})");
|
|
$this->table(
|
|
['Table', 'Rows'],
|
|
collect($counts)
|
|
->map(fn (int $count, string $table) => [$table, $count])
|
|
->values()
|
|
->all(),
|
|
);
|
|
|
|
if ($isDryRun) {
|
|
continue;
|
|
}
|
|
|
|
DB::transaction(function () use ($tenant): void {
|
|
BackupSchedule::query()
|
|
->where('tenant_id', $tenant->id)
|
|
->delete();
|
|
|
|
OperationRun::query()
|
|
->where('tenant_id', $tenant->id)
|
|
->delete();
|
|
|
|
AuditLog::query()
|
|
->where('tenant_id', $tenant->id)
|
|
->delete();
|
|
|
|
RestoreRun::withTrashed()
|
|
->where('tenant_id', $tenant->id)
|
|
->forceDelete();
|
|
|
|
BackupItem::withTrashed()
|
|
->where('tenant_id', $tenant->id)
|
|
->forceDelete();
|
|
|
|
BackupSet::withTrashed()
|
|
->where('tenant_id', $tenant->id)
|
|
->forceDelete();
|
|
|
|
PolicyVersion::withTrashed()
|
|
->where('tenant_id', $tenant->id)
|
|
->forceDelete();
|
|
|
|
Policy::query()
|
|
->where('tenant_id', $tenant->id)
|
|
->delete();
|
|
});
|
|
|
|
$this->recordPurgeOperationRun($tenant, $counts);
|
|
|
|
$this->info('Purged.');
|
|
}
|
|
|
|
return self::SUCCESS;
|
|
}
|
|
|
|
private function resolveTenants()
|
|
{
|
|
if ((bool) $this->option('all')) {
|
|
return Tenant::query()->get();
|
|
}
|
|
|
|
$tenantArg = $this->argument('tenant');
|
|
|
|
if ($tenantArg !== null && $tenantArg !== '') {
|
|
$tenant = Tenant::query()->forTenant($tenantArg)->first();
|
|
|
|
return $tenant ? collect([$tenant]) : collect();
|
|
}
|
|
|
|
try {
|
|
return collect([Tenant::currentOrFail()]);
|
|
} catch (RuntimeException) {
|
|
return collect();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @return array<string,int>
|
|
*/
|
|
private function countsForTenant(Tenant $tenant): array
|
|
{
|
|
return [
|
|
'backup_schedules' => BackupSchedule::query()->where('tenant_id', $tenant->id)->count(),
|
|
'operation_runs' => OperationRun::query()->where('tenant_id', $tenant->id)->count(),
|
|
'audit_logs' => AuditLog::query()->where('tenant_id', $tenant->id)->count(),
|
|
'restore_runs' => RestoreRun::withTrashed()->where('tenant_id', $tenant->id)->count(),
|
|
'backup_items' => BackupItem::withTrashed()->where('tenant_id', $tenant->id)->count(),
|
|
'backup_sets' => BackupSet::withTrashed()->where('tenant_id', $tenant->id)->count(),
|
|
'policy_versions' => PolicyVersion::withTrashed()->where('tenant_id', $tenant->id)->count(),
|
|
'policies' => Policy::query()->where('tenant_id', $tenant->id)->count(),
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @param array<string, int> $counts
|
|
*/
|
|
private function recordPurgeOperationRun(Tenant $tenant, array $counts): void
|
|
{
|
|
OperationRun::query()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->id,
|
|
'user_id' => null,
|
|
'initiator_name' => 'System',
|
|
'type' => 'backup_schedule_purge',
|
|
'status' => 'completed',
|
|
'outcome' => 'succeeded',
|
|
'run_identity_hash' => hash('sha256', implode(':', [
|
|
(string) $tenant->id,
|
|
'backup_schedule_purge',
|
|
now()->toISOString(),
|
|
Str::uuid()->toString(),
|
|
])),
|
|
'summary_counts' => [
|
|
'total' => array_sum($counts),
|
|
'processed' => array_sum($counts),
|
|
'succeeded' => array_sum($counts),
|
|
'failed' => 0,
|
|
],
|
|
'failure_summary' => [],
|
|
'context' => [
|
|
'source' => 'tenantpilot:purge-nonpersistent',
|
|
'deleted_rows' => $counts,
|
|
],
|
|
'started_at' => now(),
|
|
'completed_at' => now(),
|
|
]);
|
|
}
|
|
}
|