## Summary - Fixes misleading “queued / running in background” message when Review Pack generation request reuses an existing ready pack (fingerprint dedupe). - Improves resilience of Filament/Livewire interactions by ensuring the Livewire intercept shim applies after Livewire initializes. - Aligns Review Pack operation notifications with Ops-UX patterns (queued + completed notifications) and removes the old ReviewPackStatusNotification. ## Key Changes - Review Pack generate action now: - Shows queued toast only when a new pack is actually created/queued. - Shows a “Review pack already available” success notification with a link when dedupe returns an existing pack. ## Tests - `vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackGenerationTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackResourceTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/LivewireInterceptShimTest.php` ## Notes - No global search behavior changes for ReviewPacks (still excluded). - Destructive actions remain confirmation-gated (`->requiresConfirmation()`). Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #133
224 lines
7.9 KiB
PHP
224 lines
7.9 KiB
PHP
<?php
|
|
|
|
use App\Http\Controllers\AdminConsentCallbackController;
|
|
use App\Http\Controllers\Auth\EntraController;
|
|
use App\Http\Controllers\ClearTenantContextController;
|
|
use App\Http\Controllers\RbacDelegatedAuthController;
|
|
use App\Http\Controllers\ReviewPackDownloadController;
|
|
use App\Http\Controllers\SelectTenantController;
|
|
use App\Http\Controllers\SwitchWorkspaceController;
|
|
use App\Http\Controllers\TenantOnboardingController;
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use App\Support\Workspaces\WorkspaceRedirectResolver;
|
|
use App\Support\Workspaces\WorkspaceResolver;
|
|
use Filament\Http\Middleware\Authenticate as FilamentAuthenticate;
|
|
use Filament\Http\Middleware\DisableBladeIconComponents;
|
|
use Filament\Http\Middleware\DispatchServingFilamentEvent;
|
|
use Illuminate\Http\Request;
|
|
use Illuminate\Support\Facades\Route;
|
|
|
|
Route::get('/', function () {
|
|
return view('welcome');
|
|
});
|
|
|
|
Route::get('/admin/consent/callback', AdminConsentCallbackController::class)
|
|
->name('admin.consent.callback');
|
|
|
|
Route::get('/admin/consent/start', TenantOnboardingController::class)
|
|
->name('admin.consent.start');
|
|
|
|
// Avoid Filament's tenancy root redirect which otherwise sends users into legacy flows.
|
|
// when no default tenant can be resolved.
|
|
Route::middleware([
|
|
'web',
|
|
'panel:admin',
|
|
'ensure-correct-guard:web',
|
|
DisableBladeIconComponents::class,
|
|
DispatchServingFilamentEvent::class,
|
|
FilamentAuthenticate::class,
|
|
'ensure-workspace-selected',
|
|
])
|
|
->get('/admin', function (Request $request) {
|
|
$workspaceId = app(WorkspaceContext::class)->currentWorkspaceId($request);
|
|
|
|
$user = $request->user();
|
|
|
|
if (! $user instanceof User) {
|
|
return redirect()->to('/admin/choose-workspace');
|
|
}
|
|
|
|
if ($workspaceId === null) {
|
|
return redirect()->to('/admin/choose-workspace');
|
|
}
|
|
|
|
$workspace = Workspace::query()->whereKey($workspaceId)->first();
|
|
|
|
if (! $workspace instanceof Workspace) {
|
|
return redirect()->to('/admin/choose-workspace');
|
|
}
|
|
|
|
/** @var WorkspaceRedirectResolver $resolver */
|
|
$resolver = app(WorkspaceRedirectResolver::class);
|
|
|
|
return redirect()->to($resolver->resolve($workspace, $user));
|
|
})
|
|
->name('admin.home');
|
|
|
|
Route::get('/admin/rbac/start', [RbacDelegatedAuthController::class, 'start'])
|
|
->name('admin.rbac.start');
|
|
|
|
Route::get('/admin/rbac/callback', [RbacDelegatedAuthController::class, 'callback'])
|
|
->name('admin.rbac.callback');
|
|
|
|
Route::get('/auth/entra/redirect', [EntraController::class, 'redirect'])
|
|
->name('auth.entra.redirect');
|
|
|
|
Route::get('/auth/entra/callback', [EntraController::class, 'callback'])
|
|
->middleware('throttle:entra-callback')
|
|
->name('auth.entra.callback');
|
|
|
|
Route::middleware(['web', 'auth', 'ensure-correct-guard:web'])
|
|
->post('/admin/switch-workspace', SwitchWorkspaceController::class)
|
|
->name('admin.switch-workspace');
|
|
|
|
Route::middleware(['web', 'auth', 'ensure-correct-guard:web', 'ensure-workspace-selected'])
|
|
->post('/admin/select-tenant', SelectTenantController::class)
|
|
->name('admin.select-tenant');
|
|
|
|
Route::middleware(['web', 'auth', 'ensure-correct-guard:web', 'ensure-workspace-selected'])
|
|
->post('/admin/clear-tenant-context', ClearTenantContextController::class)
|
|
->name('admin.clear-tenant-context');
|
|
Route::bind('workspace', function (string $value): Workspace {
|
|
/** @var WorkspaceResolver $resolver */
|
|
$resolver = app(WorkspaceResolver::class);
|
|
|
|
$workspace = $resolver->resolve($value);
|
|
|
|
abort_unless($workspace instanceof Workspace, 404);
|
|
|
|
return $workspace;
|
|
});
|
|
|
|
Route::middleware(['web', 'auth', 'ensure-correct-guard:web', 'ensure-workspace-member'])
|
|
->prefix('/admin/w/{workspace}')
|
|
->group(function (): void {
|
|
Route::get('/', fn () => redirect()->route('admin.workspace.managed-tenants.index', ['workspace' => request()->route('workspace')]))
|
|
->name('admin.workspace.home');
|
|
|
|
Route::get('/ping', fn () => response()->noContent())->name('admin.workspace.ping');
|
|
});
|
|
|
|
Route::middleware([
|
|
'web',
|
|
'panel:admin',
|
|
'ensure-correct-guard:web',
|
|
DisableBladeIconComponents::class,
|
|
DispatchServingFilamentEvent::class,
|
|
FilamentAuthenticate::class,
|
|
])
|
|
->get('/admin/onboarding', \App\Filament\Pages\Workspaces\ManagedTenantOnboardingWizard::class)
|
|
->name('admin.onboarding');
|
|
|
|
Route::middleware([
|
|
'web',
|
|
'panel:admin',
|
|
'ensure-correct-guard:web',
|
|
DisableBladeIconComponents::class,
|
|
DispatchServingFilamentEvent::class,
|
|
FilamentAuthenticate::class,
|
|
'ensure-workspace-selected',
|
|
'ensure-filament-tenant-selected',
|
|
])
|
|
->get('/admin/operations', \App\Filament\Pages\Monitoring\Operations::class)
|
|
->name('admin.operations.index');
|
|
|
|
Route::middleware([
|
|
'web',
|
|
'panel:admin',
|
|
'ensure-correct-guard:web',
|
|
DisableBladeIconComponents::class,
|
|
DispatchServingFilamentEvent::class,
|
|
FilamentAuthenticate::class,
|
|
'ensure-workspace-selected',
|
|
'ensure-filament-tenant-selected',
|
|
])
|
|
->prefix('/admin/tenants/{tenant:external_id}/provider-connections')
|
|
->group(function (): void {
|
|
Route::get('/', function (Tenant $tenant) {
|
|
return redirect()->to('/admin/provider-connections?tenant_id='.$tenant->external_id);
|
|
})->name('admin.provider-connections.legacy-index');
|
|
|
|
Route::get('/create', function (Tenant $tenant) {
|
|
return redirect()->to('/admin/provider-connections/create?tenant_id='.$tenant->external_id);
|
|
})->name('admin.provider-connections.legacy-create');
|
|
|
|
Route::get('/{record}/edit', function (Tenant $tenant, mixed $record) {
|
|
$connection = ProviderConnection::query()
|
|
->whereKey((int) $record)
|
|
->where('tenant_id', (int) $tenant->getKey())
|
|
->where('workspace_id', (int) $tenant->workspace_id)
|
|
->first();
|
|
|
|
abort_unless($connection instanceof ProviderConnection, 404);
|
|
|
|
return redirect()->to('/admin/provider-connections/'.$connection->getKey().'/edit?tenant_id='.$tenant->external_id);
|
|
})->name('admin.provider-connections.legacy-edit');
|
|
});
|
|
|
|
Route::middleware([
|
|
'web',
|
|
'panel:admin',
|
|
'ensure-correct-guard:web',
|
|
DisableBladeIconComponents::class,
|
|
DispatchServingFilamentEvent::class,
|
|
FilamentAuthenticate::class,
|
|
'ensure-workspace-selected',
|
|
'ensure-filament-tenant-selected',
|
|
])
|
|
->get('/admin/audit-log', \App\Filament\Pages\Monitoring\AuditLog::class)
|
|
->name('admin.monitoring.audit-log');
|
|
|
|
Route::middleware([
|
|
'web',
|
|
'panel:admin',
|
|
'ensure-correct-guard:web',
|
|
DisableBladeIconComponents::class,
|
|
DispatchServingFilamentEvent::class,
|
|
FilamentAuthenticate::class,
|
|
'ensure-workspace-selected',
|
|
'ensure-filament-tenant-selected',
|
|
])
|
|
->get('/admin/operations/{run}', \App\Filament\Pages\Operations\TenantlessOperationRunViewer::class)
|
|
->name('admin.operations.view');
|
|
|
|
Route::middleware([
|
|
'web',
|
|
'panel:admin',
|
|
'ensure-correct-guard:web',
|
|
DisableBladeIconComponents::class,
|
|
DispatchServingFilamentEvent::class,
|
|
FilamentAuthenticate::class,
|
|
'ensure-workspace-member',
|
|
])
|
|
->get('/admin/w/{workspace}/managed-tenants', \App\Filament\Pages\Workspaces\ManagedTenantsLanding::class)
|
|
->name('admin.workspace.managed-tenants.index');
|
|
|
|
Route::middleware(['signed'])
|
|
->get('/admin/review-packs/{reviewPack}/download', ReviewPackDownloadController::class)
|
|
->name('admin.review-packs.download');
|
|
|
|
if (app()->runningUnitTests()) {
|
|
Route::middleware(['web', 'auth', 'ensure-workspace-selected'])
|
|
->get('/admin/_test/workspace-context', function (Request $request) {
|
|
$workspaceId = app(\App\Support\Workspaces\WorkspaceContext::class)->currentWorkspaceId($request);
|
|
|
|
return response()->json([
|
|
'workspace_id' => $workspaceId,
|
|
]);
|
|
});
|
|
}
|