## Summary
Implements and polishes the Platform Ops Runbooks feature (Spec 113) — the operator control plane for safe backfills and data repair from `/system`.
## Changes
### UX Polish (Phase 7 — US4)
- **Filament-native components**: Rewrote `runbooks.blade.php` and `view-run.blade.php` using `<x-filament::section>` instead of raw Tailwind div cards. Cards now render correctly with Filament's built-in borders, shadows and dark mode.
- **System panel theme**: Created `resources/css/filament/system/theme.css` and registered `->viteTheme()` on `SystemPanelProvider`. The system panel previously had no theme CSS registered — Tailwind utility classes weren't compiled for its views, causing the warning icon SVG to expand to full container size.
- **Live scope selector**: Added `->live()` to the scope `Radio` field so "Single tenant" immediately reveals the tenant search dropdown without requiring a Submit first.
### Core Feature (Phases 1–6, previously shipped)
- `/system/ops/runbooks` — runbook catalog, preflight, run with typed confirmation + reason
- `/system/ops/runs` — run history table with status/outcome badges
- `/system/ops/runs/{id}` — run detail view with summary counts, failures, collapsible context
- `FindingsLifecycleBackfillRunbookService` — preflight + execution logic
- AllowedTenantUniverse — scopes tenant picker to non-platform tenants only
- RBAC: `platform.ops.view`, `platform.runbooks.view`, `platform.runbooks.run`, `platform.runbooks.findings.lifecycle_backfill`
- Rate-limited `/system/login` (10/min per IP+username)
- Distinct session cookie for `/system` isolation
## Test Coverage
- 16 tests / 141 assertions — all passing
- Covers: page access, RBAC, preflight, run dispatch, scope selector, run detail, run list
## Checklist
- [x] Filament v5 / Livewire v4 compliant
- [x] Provider registered in `bootstrap/providers.php`
- [x] Destructive actions require confirmation (`->requiresConfirmation()`)
- [x] System panel theme registered (`viteTheme`)
- [x] Pint clean
- [x] Tests pass
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #137
161 lines
4.7 KiB
PHP
161 lines
4.7 KiB
PHP
<?php
|
|
|
|
use App\Filament\System\Pages\Auth\Login;
|
|
use App\Models\AuditLog;
|
|
use App\Models\PlatformUser;
|
|
use App\Models\Tenant;
|
|
use App\Support\Auth\PlatformCapabilities;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function () {
|
|
Filament::setCurrentPanel('system');
|
|
Filament::bootCurrentPanel();
|
|
});
|
|
|
|
it('serves the system login page', function () {
|
|
$this->get('/system/login')->assertSuccessful();
|
|
});
|
|
|
|
it('authenticates a platform user and audits success', function () {
|
|
$platformTenant = Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
|
|
$user = PlatformUser::factory()->create([
|
|
'email' => 'operator@tenantpilot.io',
|
|
'is_active' => true,
|
|
'last_login_at' => null,
|
|
]);
|
|
|
|
Livewire::test(Login::class)
|
|
->set('data.email', $user->email)
|
|
->set('data.password', 'password')
|
|
->call('authenticate');
|
|
|
|
expect(auth('platform')->check())->toBeTrue();
|
|
expect(auth('platform')->id())->toBe($user->getKey());
|
|
expect($user->fresh()->last_login_at)->not->toBeNull();
|
|
|
|
$audit = AuditLog::query()
|
|
->where('tenant_id', $platformTenant->getKey())
|
|
->where('action', 'platform.auth.login')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($audit)->not->toBeNull();
|
|
expect($audit->status)->toBe('success');
|
|
expect($audit->actor_id)->toBe($user->getKey());
|
|
expect($audit->metadata['attempted_email'] ?? null)->toBe($user->email);
|
|
});
|
|
|
|
it('rejects invalid credentials and audits failure', function () {
|
|
$platformTenant = Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
|
|
$user = PlatformUser::factory()->create([
|
|
'email' => 'operator@tenantpilot.io',
|
|
'is_active' => true,
|
|
]);
|
|
|
|
Livewire::test(Login::class)
|
|
->set('data.email', $user->email)
|
|
->set('data.password', 'wrong-password')
|
|
->call('authenticate')
|
|
->assertHasErrors(['data.email']);
|
|
|
|
expect(auth('platform')->check())->toBeFalse();
|
|
|
|
$audit = AuditLog::query()
|
|
->where('tenant_id', $platformTenant->getKey())
|
|
->where('action', 'platform.auth.login')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($audit)->not->toBeNull();
|
|
expect($audit->status)->toBe('failure');
|
|
expect($audit->metadata['attempted_email'] ?? null)->toBe($user->email);
|
|
expect($audit->metadata['reason'] ?? null)->toBe('invalid_credentials');
|
|
});
|
|
|
|
it('rejects inactive platform users and audits failure', function () {
|
|
$platformTenant = Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
|
|
$user = PlatformUser::factory()->create([
|
|
'email' => 'operator@tenantpilot.io',
|
|
'is_active' => false,
|
|
'last_login_at' => null,
|
|
]);
|
|
|
|
Livewire::test(Login::class)
|
|
->set('data.email', $user->email)
|
|
->set('data.password', 'password')
|
|
->call('authenticate')
|
|
->assertHasErrors(['data.email']);
|
|
|
|
expect(auth('platform')->check())->toBeFalse();
|
|
expect($user->fresh()->last_login_at)->toBeNull();
|
|
|
|
$audit = AuditLog::query()
|
|
->where('tenant_id', $platformTenant->getKey())
|
|
->where('action', 'platform.auth.login')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($audit)->not->toBeNull();
|
|
expect($audit->status)->toBe('failure');
|
|
expect($audit->metadata['attempted_email'] ?? null)->toBe($user->email);
|
|
expect($audit->metadata['reason'] ?? null)->toBe('inactive');
|
|
});
|
|
|
|
it('denies system panel access (403) for platform users without the required capability', function () {
|
|
Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
|
|
$user = PlatformUser::factory()->create([
|
|
'capabilities' => [],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
Livewire::test(Login::class)
|
|
->set('data.email', $user->email)
|
|
->set('data.password', 'password')
|
|
->call('authenticate');
|
|
|
|
expect(auth('platform')->check())->toBeTrue();
|
|
|
|
$this->get('/system')->assertForbidden();
|
|
});
|
|
|
|
it('allows system panel access for platform users with the required capability', function () {
|
|
Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
|
|
$user = PlatformUser::factory()->create([
|
|
'capabilities' => [PlatformCapabilities::ACCESS_SYSTEM_PANEL],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
$this->actingAs($user, 'platform');
|
|
|
|
$this->get('/system')->assertSuccessful();
|
|
});
|