ahmido
9f5c99317b
## Summary - Fixes misleading “queued / running in background” message when Review Pack generation request reuses an existing ready pack (fingerprint dedupe). - Improves resilience of Filament/Livewire interactions by ensuring the Livewire intercept shim applies after Livewire initializes. - Aligns Review Pack operation notifications with Ops-UX patterns (queued + completed notifications) and removes the old ReviewPackStatusNotification. ## Key Changes - Review Pack generate action now: - Shows queued toast only when a new pack is actually created/queued. - Shows a “Review pack already available” success notification with a link when dedupe returns an existing pack. ## Tests - `vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackGenerationTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackResourceTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/LivewireInterceptShimTest.php` ## Notes - No global search behavior changes for ReviewPacks (still excluded). - Destructive actions remain confirmation-gated (`->requiresConfirmation()`). Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #133
42 lines
1.6 KiB
PHP
42 lines
1.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Illuminate\Console\Scheduling\Schedule;
|
|
|
|
it('schedules review pack prune command daily without overlapping', function (): void {
|
|
/** @var Schedule $schedule */
|
|
$schedule = app(Schedule::class);
|
|
|
|
$event = collect($schedule->events())
|
|
->first(fn ($event) => str_contains($event->command ?? '', 'tenantpilot:review-pack:prune'));
|
|
|
|
expect($event)->not->toBeNull('review-pack:prune should be scheduled');
|
|
expect($event->withoutOverlapping)->toBeTrue();
|
|
});
|
|
|
|
it('schedules entra admin roles scan daily without overlapping', function (): void {
|
|
/** @var Schedule $schedule */
|
|
$schedule = app(Schedule::class);
|
|
|
|
$event = collect($schedule->events())
|
|
->first(fn ($event) => ($event->description ?? null) === 'entra-admin-roles:scan');
|
|
|
|
expect($event)->not->toBeNull('entra-admin-roles:scan should be scheduled');
|
|
expect($event->withoutOverlapping)->toBeTrue();
|
|
});
|
|
|
|
it('documents posture:dispatch deferral', function (): void {
|
|
// FR-015: tenantpilot:posture:dispatch command infrastructure does not yet exist.
|
|
// The schedule entry will be added once the command is created.
|
|
// See specs/109-review-pack-export/research.md §7 for rationale.
|
|
|
|
/** @var Schedule $schedule */
|
|
$schedule = app(Schedule::class);
|
|
|
|
$event = collect($schedule->events())
|
|
->first(fn ($event) => str_contains($event->command ?? '', 'posture:dispatch'));
|
|
|
|
expect($event)->toBeNull('posture:dispatch not yet implemented — deferred per FR-015');
|
|
})->skip('posture:dispatch command deferred — see specs/109 research.md §7');
|