ahmido
200498fa8e
## Summary
Implements and polishes the Platform Ops Runbooks feature (Spec 113) — the operator control plane for safe backfills and data repair from `/system`.
## Changes
### UX Polish (Phase 7 — US4)
- **Filament-native components**: Rewrote `runbooks.blade.php` and `view-run.blade.php` using `<x-filament::section>` instead of raw Tailwind div cards. Cards now render correctly with Filament's built-in borders, shadows and dark mode.
- **System panel theme**: Created `resources/css/filament/system/theme.css` and registered `->viteTheme()` on `SystemPanelProvider`. The system panel previously had no theme CSS registered — Tailwind utility classes weren't compiled for its views, causing the warning icon SVG to expand to full container size.
- **Live scope selector**: Added `->live()` to the scope `Radio` field so "Single tenant" immediately reveals the tenant search dropdown without requiring a Submit first.
### Core Feature (Phases 1–6, previously shipped)
- `/system/ops/runbooks` — runbook catalog, preflight, run with typed confirmation + reason
- `/system/ops/runs` — run history table with status/outcome badges
- `/system/ops/runs/{id}` — run detail view with summary counts, failures, collapsible context
- `FindingsLifecycleBackfillRunbookService` — preflight + execution logic
- AllowedTenantUniverse — scopes tenant picker to non-platform tenants only
- RBAC: `platform.ops.view`, `platform.runbooks.view`, `platform.runbooks.run`, `platform.runbooks.findings.lifecycle_backfill`
- Rate-limited `/system/login` (10/min per IP+username)
- Distinct session cookie for `/system` isolation
## Test Coverage
- 16 tests / 141 assertions — all passing
- Covers: page access, RBAC, preflight, run dispatch, scope selector, run detail, run list
## Checklist
- [x] Filament v5 / Livewire v4 compliant
- [x] Provider registered in `bootstrap/providers.php`
- [x] Destructive actions require confirmation (`->requiresConfirmation()`)
- [x] System panel theme registered (`viteTheme`)
- [x] Pint clean
- [x] Tests pass
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #137
79 lines
2.2 KiB
PHP
79 lines
2.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Jobs\BackfillFindingLifecycleJob;
|
|
use App\Models\Finding;
|
|
use App\Models\Tenant;
|
|
use App\Services\OperationRunService;
|
|
use App\Services\Runbooks\FindingsLifecycleBackfillRunbookService;
|
|
use App\Services\Runbooks\FindingsLifecycleBackfillScope;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Queue;
|
|
use Illuminate\Validation\ValidationException;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function () {
|
|
Filament::setCurrentPanel('system');
|
|
Filament::bootCurrentPanel();
|
|
|
|
Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
});
|
|
|
|
it('is idempotent: after a successful run, preflight reports nothing to do', function () {
|
|
Queue::fake();
|
|
|
|
$platformTenant = Tenant::query()->where('external_id', 'platform')->firstOrFail();
|
|
|
|
$tenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $platformTenant->workspace_id,
|
|
]);
|
|
|
|
Finding::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'due_at' => null,
|
|
]);
|
|
|
|
$runbook = app(FindingsLifecycleBackfillRunbookService::class);
|
|
|
|
$initial = $runbook->preflight(FindingsLifecycleBackfillScope::singleTenant((int) $tenant->getKey()));
|
|
|
|
expect($initial['affected_count'])->toBe(1);
|
|
|
|
$runbook->start(
|
|
scope: FindingsLifecycleBackfillScope::singleTenant((int) $tenant->getKey()),
|
|
initiator: null,
|
|
reason: null,
|
|
source: 'system_ui',
|
|
);
|
|
|
|
$job = new BackfillFindingLifecycleJob(
|
|
tenantId: (int) $tenant->getKey(),
|
|
workspaceId: (int) $tenant->workspace_id,
|
|
initiatorUserId: null,
|
|
);
|
|
|
|
$job->handle(
|
|
app(OperationRunService::class),
|
|
app(\App\Services\Findings\FindingSlaPolicy::class),
|
|
$runbook,
|
|
);
|
|
|
|
$after = $runbook->preflight(FindingsLifecycleBackfillScope::singleTenant((int) $tenant->getKey()));
|
|
|
|
expect($after['affected_count'])->toBe(0);
|
|
|
|
expect(fn () => $runbook->start(
|
|
scope: FindingsLifecycleBackfillScope::singleTenant((int) $tenant->getKey()),
|
|
initiator: null,
|
|
reason: null,
|
|
source: 'system_ui',
|
|
))->toThrow(ValidationException::class);
|
|
});
|