ahmido
200498fa8e
## Summary
Implements and polishes the Platform Ops Runbooks feature (Spec 113) — the operator control plane for safe backfills and data repair from `/system`.
## Changes
### UX Polish (Phase 7 — US4)
- **Filament-native components**: Rewrote `runbooks.blade.php` and `view-run.blade.php` using `<x-filament::section>` instead of raw Tailwind div cards. Cards now render correctly with Filament's built-in borders, shadows and dark mode.
- **System panel theme**: Created `resources/css/filament/system/theme.css` and registered `->viteTheme()` on `SystemPanelProvider`. The system panel previously had no theme CSS registered — Tailwind utility classes weren't compiled for its views, causing the warning icon SVG to expand to full container size.
- **Live scope selector**: Added `->live()` to the scope `Radio` field so "Single tenant" immediately reveals the tenant search dropdown without requiring a Submit first.
### Core Feature (Phases 1–6, previously shipped)
- `/system/ops/runbooks` — runbook catalog, preflight, run with typed confirmation + reason
- `/system/ops/runs` — run history table with status/outcome badges
- `/system/ops/runs/{id}` — run detail view with summary counts, failures, collapsible context
- `FindingsLifecycleBackfillRunbookService` — preflight + execution logic
- AllowedTenantUniverse — scopes tenant picker to non-platform tenants only
- RBAC: `platform.ops.view`, `platform.runbooks.view`, `platform.runbooks.run`, `platform.runbooks.findings.lifecycle_backfill`
- Rate-limited `/system/login` (10/min per IP+username)
- Distinct session cookie for `/system` isolation
## Test Coverage
- 16 tests / 141 assertions — all passing
- Covers: page access, RBAC, preflight, run dispatch, scope selector, run detail, run list
## Checklist
- [x] Filament v5 / Livewire v4 compliant
- [x] Provider registered in `bootstrap/providers.php`
- [x] Destructive actions require confirmation (`->requiresConfirmation()`)
- [x] System panel theme registered (`viteTheme`)
- [x] Pint clean
- [x] Tests pass
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #137
114 lines
3.4 KiB
PHP
114 lines
3.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\System\Pages\Ops\Runbooks;
|
|
use App\Models\Finding;
|
|
use App\Models\PlatformUser;
|
|
use App\Models\Tenant;
|
|
use App\Services\Runbooks\FindingsLifecycleBackfillScope;
|
|
use App\Support\Auth\PlatformCapabilities;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Queue;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function () {
|
|
Filament::setCurrentPanel('system');
|
|
Filament::bootCurrentPanel();
|
|
|
|
Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
});
|
|
|
|
it('disables running when preflight indicates nothing to do', function () {
|
|
Queue::fake();
|
|
|
|
$platformTenant = Tenant::query()->where('external_id', 'platform')->firstOrFail();
|
|
|
|
$tenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $platformTenant->workspace_id,
|
|
]);
|
|
|
|
Finding::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
]);
|
|
|
|
$user = PlatformUser::factory()->create([
|
|
'capabilities' => [
|
|
PlatformCapabilities::ACCESS_SYSTEM_PANEL,
|
|
PlatformCapabilities::OPS_VIEW,
|
|
PlatformCapabilities::RUNBOOKS_VIEW,
|
|
PlatformCapabilities::RUNBOOKS_RUN,
|
|
PlatformCapabilities::RUNBOOKS_FINDINGS_LIFECYCLE_BACKFILL,
|
|
],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
$this->actingAs($user, 'platform');
|
|
|
|
Livewire::test(Runbooks::class)
|
|
->callAction('preflight', data: [
|
|
'scope_mode' => FindingsLifecycleBackfillScope::MODE_ALL_TENANTS,
|
|
])
|
|
->assertSet('preflight.affected_count', 0)
|
|
->assertActionDisabled('run');
|
|
});
|
|
|
|
it('requires typed confirmation and a reason for all-tenants runs', function () {
|
|
Queue::fake();
|
|
|
|
$platformTenant = Tenant::query()->where('external_id', 'platform')->firstOrFail();
|
|
|
|
$tenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $platformTenant->workspace_id,
|
|
]);
|
|
|
|
Finding::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'due_at' => null,
|
|
]);
|
|
|
|
$user = PlatformUser::factory()->create([
|
|
'capabilities' => [
|
|
PlatformCapabilities::ACCESS_SYSTEM_PANEL,
|
|
PlatformCapabilities::OPS_VIEW,
|
|
PlatformCapabilities::RUNBOOKS_VIEW,
|
|
PlatformCapabilities::RUNBOOKS_RUN,
|
|
PlatformCapabilities::RUNBOOKS_FINDINGS_LIFECYCLE_BACKFILL,
|
|
],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
$this->actingAs($user, 'platform');
|
|
|
|
Livewire::test(Runbooks::class)
|
|
->callAction('preflight', data: [
|
|
'scope_mode' => FindingsLifecycleBackfillScope::MODE_ALL_TENANTS,
|
|
])
|
|
->assertSet('preflight.affected_count', 1)
|
|
->callAction('run', data: [])
|
|
->assertHasActionErrors([
|
|
'typed_confirmation',
|
|
'reason_code',
|
|
'reason_text',
|
|
]);
|
|
|
|
Livewire::test(Runbooks::class)
|
|
->callAction('preflight', data: [
|
|
'scope_mode' => FindingsLifecycleBackfillScope::MODE_ALL_TENANTS,
|
|
])
|
|
->assertSet('preflight.affected_count', 1)
|
|
->callAction('run', data: [
|
|
'typed_confirmation' => 'backfill',
|
|
'reason_code' => 'DATA_REPAIR',
|
|
'reason_text' => 'Test run',
|
|
])
|
|
->assertHasActionErrors(['typed_confirmation']);
|
|
});
|