Summary Implements Inventory Core (Spec 040): a tenant-scoped, mutable “last observed” inventory catalog + sync run logging, with deterministic selection hashing and safe derived “missing” semantics. This establishes the foundation for Inventory UI (041), Dependencies Graph (042), Compare/Promotion (043), and Drift (044). What’s included • DB schema • inventory_items (unique: tenant_id + policy_type + external_id; indexes; last_seen_at, last_seen_run_id) • inventory_sync_runs (tenant_id, selection_hash/payload, status, started/finished, counts, error_codes, correlation_id) • Selection hashing • Deterministic selection_hash via canonical JSON (sorted keys + sorted arrays) + sha256 • Sync semantics • Idempotent upsert (no duplicates) • Updates last_seen_* when observed • Enforces tenant scoping for all reads/writes • Guardrail: inventory sync does not create snapshots/backups • Missing semantics (derived) • “missing” computed relative to latest completed run for same (tenant_id, selection_hash) • Low confidence when latest run is partial/failed or had_errors=true • Selection isolation (runs for other selections don’t affect missing) • deleted is reserved (not produced here) • Safety • meta_jsonb whitelist enforced (unknown keys dropped; never fail sync) • Safe error persistence (no bearer tokens / secrets) • Locking to prevent overlapping runs for same tenant+selection • Concurrency limiter (global + per-tenant) and throttling resilience (429/503 backoff + jitter) Tests Added Pest coverage for: • selection_hash determinism (array order invariant) • upsert idempotency + last_seen updates • missing derived semantics + selection isolation • low confidence missing on partial/had_errors • meta whitelist drop (no exception) • lock prevents overlapping runs • no snapshots/backups side effects • safe error persistence (no bearer tokens) Non-goals • Inventory UI pages/resources (Spec 041) • Dependency graph hydration (Spec 042) • Cross-tenant compare/promotion flows (Spec 043) • Drift analysis dashboards (Spec 044) Review focus • Data model correctness + indexes/constraints • Selection hash canonicalization (determinism) • Missing semantics (latest completed run + confidence rule) • Guardrails (no snapshot/backups side effects) • Safety: error_code taxonomy + safe persistence/logging Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #43
90 lines
2.3 KiB
PHP
90 lines
2.3 KiB
PHP
<?php
|
|
|
|
namespace App\Services\Inventory;
|
|
|
|
class InventorySelectionHasher
|
|
{
|
|
/**
|
|
* @param array<string, mixed> $selectionPayload
|
|
* @return array{policy_types: list<string>, categories: list<string>, include_foundations: bool, include_dependencies: bool}
|
|
*/
|
|
public function normalize(array $selectionPayload): array
|
|
{
|
|
$policyTypes = $this->stringList($selectionPayload['policy_types'] ?? []);
|
|
sort($policyTypes);
|
|
|
|
$categories = $this->stringList($selectionPayload['categories'] ?? []);
|
|
sort($categories);
|
|
|
|
return [
|
|
'policy_types' => $policyTypes,
|
|
'categories' => $categories,
|
|
'include_foundations' => (bool) ($selectionPayload['include_foundations'] ?? false),
|
|
'include_dependencies' => (bool) ($selectionPayload['include_dependencies'] ?? false),
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed> $selectionPayload
|
|
*/
|
|
public function canonicalJson(array $selectionPayload): string
|
|
{
|
|
$normalized = $this->normalize($selectionPayload);
|
|
$normalized = $this->ksortRecursive($normalized);
|
|
|
|
return (string) json_encode($normalized, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE);
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed> $selectionPayload
|
|
*/
|
|
public function hash(array $selectionPayload): string
|
|
{
|
|
return hash('sha256', $this->canonicalJson($selectionPayload));
|
|
}
|
|
|
|
/**
|
|
* @return list<string>
|
|
*/
|
|
private function stringList(mixed $value): array
|
|
{
|
|
if (! is_array($value)) {
|
|
return [];
|
|
}
|
|
|
|
$result = [];
|
|
foreach ($value as $item) {
|
|
if (! is_string($item)) {
|
|
continue;
|
|
}
|
|
|
|
$item = trim($item);
|
|
if ($item === '') {
|
|
continue;
|
|
}
|
|
|
|
$result[] = $item;
|
|
}
|
|
|
|
return array_values(array_unique($result));
|
|
}
|
|
|
|
private function ksortRecursive(mixed $value): mixed
|
|
{
|
|
if (! is_array($value)) {
|
|
return $value;
|
|
}
|
|
|
|
$isList = array_is_list($value);
|
|
if (! $isList) {
|
|
ksort($value);
|
|
}
|
|
|
|
foreach ($value as $key => $child) {
|
|
$value[$key] = $this->ksortRecursive($child);
|
|
}
|
|
|
|
return $value;
|
|
}
|
|
}
|