ahmido
e64bae9cfc
## Summary - replace the legacy Tenant and TenantMembership core models with ManagedEnvironment and ManagedEnvironmentMembership - propagate the managed environment naming and key changes across Filament resources, pages, controllers, jobs, models, and supporting runtime paths - add feature 279 spec artifacts and focused managed-environment test coverage for model behavior, route binding, panel context, authorization, and legacy guardrails ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentAuthorizationTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentPanelContextTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentRouteBindingTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentContextResolverTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentModelTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - branch pushed from commit `1123b122` - browser smoke test file was added but not run in this pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #335
56 lines
2.2 KiB
PHP
56 lines
2.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\AuditLog;
|
|
use App\Models\Finding;
|
|
use App\Services\Findings\FindingWorkflowService;
|
|
use App\Services\Intune\AuditLogger;
|
|
use App\Support\Audit\AuditActionId;
|
|
use Mockery\MockInterface;
|
|
|
|
use function Pest\Laravel\mock;
|
|
|
|
it('registers canonical findings workflow audit actions', function (): void {
|
|
expect(AuditActionId::knownValues())
|
|
->toContain(AuditActionId::FindingTriaged->value)
|
|
->toContain(AuditActionId::FindingInProgress->value)
|
|
->toContain(AuditActionId::FindingAssigned->value)
|
|
->toContain(AuditActionId::FindingResolved->value)
|
|
->toContain(AuditActionId::FindingClosed->value)
|
|
->toContain(AuditActionId::FindingRiskAccepted->value)
|
|
->toContain(AuditActionId::FindingReopened->value);
|
|
});
|
|
|
|
it('keeps only the surviving model lifecycle helpers', function (): void {
|
|
expect(method_exists(Finding::class, 'resolve'))->toBeTrue()
|
|
->and(method_exists(Finding::class, 'reopen'))->toBeTrue()
|
|
->and(method_exists(Finding::class, 'triage'))->toBeFalse()
|
|
->and(method_exists(Finding::class, 'startProgress'))->toBeFalse()
|
|
->and(method_exists(Finding::class, 'assign'))->toBeFalse()
|
|
->and(method_exists(Finding::class, 'close'))->toBeFalse()
|
|
->and(method_exists(Finding::class, 'riskAccept'))->toBeFalse();
|
|
});
|
|
|
|
it('rolls back finding workflow persistence when audit logging fails', function (): void {
|
|
[$user, $tenant] = $this->actingAsFindingOperator('owner');
|
|
|
|
$finding = $this->makeFindingForWorkflow($tenant, Finding::STATUS_NEW);
|
|
|
|
mock(AuditLogger::class, function (MockInterface $mock): void {
|
|
$mock->shouldReceive('log')
|
|
->once()
|
|
->andThrow(new \RuntimeException('Audit write unavailable.'));
|
|
});
|
|
|
|
expect(fn () => app(FindingWorkflowService::class)->triage($finding, $tenant, $user))
|
|
->toThrow(\RuntimeException::class, 'Audit write unavailable.');
|
|
|
|
expect($finding->refresh()->status)->toBe(Finding::STATUS_NEW)
|
|
->and(AuditLog::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('resource_type', 'finding')
|
|
->where('resource_id', (string) $finding->getKey())
|
|
->count())->toBe(0);
|
|
});
|