ahmido
094fff87b6
## Reopened validation note Baseline Compare residual test failures discovered during the Spec 322 broader regression pass were fixed in Spec 319 because they belong to the Environment-owned Baseline Compare route contract. No runtime code was changed. The affected tests now mount `BaselineCompareLanding` through the explicit environment route-owned helper instead of relying on implicit/remembered context. Validation: - 5 previously failing tests: 5 passed, 42 assertions - additional baseline/action/gap/action-surface tests: 20 passed, 199 assertions - broader Unit/Feature slice: 233 passed, 1826 assertions - pint --dirty: pass - git diff --check: pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #382
94 lines
3.5 KiB
PHP
94 lines
3.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\BaselineProfile;
|
|
use App\Models\BaselineSnapshot;
|
|
use App\Models\BaselineTenantAssignment;
|
|
use App\Models\OperationRun;
|
|
use App\Support\Baselines\BaselineCompareReasonCode;
|
|
use App\Support\Baselines\BaselineCompareStats;
|
|
use App\Support\ReasonTranslation\ReasonPresenter;
|
|
use App\Support\Ui\OperatorExplanation\ExplanationFamily;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('renders suppressed baseline-compare results as explanation-first output instead of an implicit all-clear', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
]);
|
|
|
|
$snapshot = BaselineSnapshot::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
]);
|
|
|
|
$profile->update(['active_snapshot_id' => (int) $snapshot->getKey()]);
|
|
|
|
BaselineTenantAssignment::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
]);
|
|
|
|
OperationRun::factory()->create([
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'baseline_compare',
|
|
'status' => 'completed',
|
|
'outcome' => 'partially_succeeded',
|
|
'completed_at' => now(),
|
|
'summary_counts' => [
|
|
'total' => 0,
|
|
'processed' => 0,
|
|
'errors_recorded' => 2,
|
|
],
|
|
'context' => [
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
'baseline_snapshot_id' => (int) $snapshot->getKey(),
|
|
'baseline_compare' => [
|
|
'reason_code' => BaselineCompareReasonCode::CoverageUnproven->value,
|
|
'coverage' => [
|
|
'effective_types' => ['deviceConfiguration', 'deviceCompliancePolicy'],
|
|
'covered_types' => ['deviceConfiguration'],
|
|
'uncovered_types' => ['deviceCompliancePolicy'],
|
|
'proof' => false,
|
|
],
|
|
'evidence_gaps' => [
|
|
'count' => 2,
|
|
'by_reason' => [
|
|
BaselineCompareReasonCode::CoverageUnproven->value => 2,
|
|
],
|
|
],
|
|
'fidelity' => 'meta',
|
|
],
|
|
],
|
|
]);
|
|
|
|
$stats = BaselineCompareStats::forTenant($tenant);
|
|
$explanation = $stats->operatorExplanation();
|
|
$summary = $stats->summaryAssessment();
|
|
$reasonSemantics = app(ReasonPresenter::class)->semantics(
|
|
app(ReasonPresenter::class)->forArtifactTruth(BaselineCompareReasonCode::CoverageUnproven->value, 'artifact_truth'),
|
|
);
|
|
|
|
expect($explanation->family)->toBe(ExplanationFamily::SuppressedOutput);
|
|
expect($reasonSemantics)->not->toBeNull();
|
|
|
|
baselineCompareLandingLivewire($tenant, user: $user)
|
|
->assertSee($summary->headline)
|
|
->assertSee($explanation->trustworthinessLabel())
|
|
->assertSee($summary->nextActionLabel())
|
|
->assertSee('Reason owner')
|
|
->assertSee($reasonSemantics['owner_label'])
|
|
->assertSee('Platform reason family')
|
|
->assertSee($reasonSemantics['family_label'])
|
|
->assertSee('Findings shown')
|
|
->assertSee('Evidence gaps');
|
|
});
|