ahmido
3030dd9af2
Summary Kurz: Implementiert Feature 054 — canonical OperationRun-flow, Monitoring UI, dispatch-safety, notifications, dedupe, plus small UX safety clarifications (RBAC group search delegated; Restore group mapping DB-only). What Changed Core service: OperationRun lifecycle, dedupe and dispatch helpers — OperationRunService.php. Model + migration: OperationRun model and migration — OperationRun.php, 2026_01_16_180642_create_operation_runs_table.php. Notifications: queued + terminal DB notifications (initiator-only) — OperationRunQueued.php, OperationRunCompleted.php. Monitoring UI: Filament list/detail + Livewire pieces (DB-only render) — OperationRunResource.php and related pages/views. Start surfaces / Jobs: instrumented start surfaces, job middleware, and job updates to use canonical runs — multiple app/Jobs/* and app/Filament/* updates (see tests for full coverage). RBAC + Restore UX clarifications: RBAC group search is delegated-Graph-based and disabled without delegated token; Restore group mapping remains DB-only (directory cache) and helper text always visible — TenantResource.php, RestoreRunResource.php. Specs / Constitution: updated spec & quickstart and added one-line constitution guideline about Graph usage: spec.md quickstart.md constitution.md Tests & Verification Unit / Feature tests added/updated for run lifecycle, notifications, idempotency, and UI guards: see tests/Feature/* (notably OperationRunServiceTest, MonitoringOperationsTest, OperationRunNotificationTest, and various Filament feature tests). Full test run locally: ./vendor/bin/sail artisan test → 587 passed, 5 skipped. Migrations Adds create_operation_runs_table migration; run php artisan migrate in staging after review. Notes / Rationale Monitoring pages are explicitly DB-only at render time (no Graph calls). Start surfaces enqueue work only and return a “View run” link. Delegated Graph access is used only for explicit user actions (RBAC group search); restore mapping intentionally uses cached DB data only to avoid render-time Graph calls. Dispatch wrapper marks runs failed immediately if background dispatch throws synchronously to avoid misleading “queued” states. Upgrade / Deploy Considerations Run migrations: ./vendor/bin/sail artisan migrate. Background workers should be running to process queued jobs (recommended to monitor queue health during rollout). No secret or token persistence changes. PR checklist Tests updated/added for changed behavior Specs updated: 054-unify-runs-suitewide docs + quickstart Constitution note added (.specify) Pint formatting applied Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #63
89 lines
3.0 KiB
PHP
89 lines
3.0 KiB
PHP
<?php
|
|
|
|
use App\Models\BackupSchedule;
|
|
use App\Models\BackupScheduleRun;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use Carbon\CarbonImmutable;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('reconciles completed backup schedule runs into operation runs', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$schedule = BackupSchedule::create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Daily',
|
|
'is_enabled' => true,
|
|
'timezone' => 'UTC',
|
|
'frequency' => 'daily',
|
|
'time_of_day' => '10:00:00',
|
|
'days_of_week' => null,
|
|
'policy_types' => ['deviceConfiguration'],
|
|
'include_foundations' => true,
|
|
'retention_keep_last' => 30,
|
|
'last_run_at' => null,
|
|
'last_run_status' => null,
|
|
'next_run_at' => null,
|
|
]);
|
|
|
|
$startedAt = CarbonImmutable::parse('2026-01-01 00:00:00', 'UTC');
|
|
$finishedAt = CarbonImmutable::parse('2026-01-01 00:00:05', 'UTC');
|
|
|
|
$scheduleRun = BackupScheduleRun::create([
|
|
'backup_schedule_id' => $schedule->id,
|
|
'tenant_id' => $tenant->id,
|
|
'scheduled_for' => CarbonImmutable::parse('2026-01-01 00:00:00', 'UTC'),
|
|
'started_at' => $startedAt,
|
|
'finished_at' => $finishedAt,
|
|
'status' => BackupScheduleRun::STATUS_SUCCESS,
|
|
'summary' => [
|
|
'policies_total' => 5,
|
|
'policies_backed_up' => 18,
|
|
'sync_failures' => [],
|
|
],
|
|
'error_code' => null,
|
|
'error_message' => null,
|
|
'backup_set_id' => null,
|
|
]);
|
|
|
|
$operationRun = OperationRun::create([
|
|
'tenant_id' => $tenant->id,
|
|
'user_id' => null,
|
|
'initiator_name' => 'System',
|
|
'type' => 'backup_schedule.run_now',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'run_identity_hash' => hash('sha256', 'backup_schedule.run_now|'.$scheduleRun->id),
|
|
'summary_counts' => [],
|
|
'failure_summary' => [],
|
|
'context' => [
|
|
'backup_schedule_id' => (int) $schedule->id,
|
|
'backup_schedule_run_id' => (int) $scheduleRun->id,
|
|
],
|
|
]);
|
|
|
|
$this->artisan('tenantpilot:operation-runs:reconcile-backup-schedules', [
|
|
'--tenant' => [$tenant->id],
|
|
'--older-than' => 0,
|
|
])->assertSuccessful();
|
|
|
|
$operationRun->refresh();
|
|
|
|
expect($operationRun->status)->toBe('completed');
|
|
expect($operationRun->outcome)->toBe('succeeded');
|
|
expect($operationRun->failure_summary)->toBe([]);
|
|
|
|
expect($operationRun->started_at?->format('Y-m-d H:i:s'))->toBe($startedAt->format('Y-m-d H:i:s'));
|
|
expect($operationRun->completed_at?->format('Y-m-d H:i:s'))->toBe($finishedAt->format('Y-m-d H:i:s'));
|
|
|
|
expect($operationRun->summary_counts)->toMatchArray([
|
|
'backup_schedule_id' => (int) $schedule->id,
|
|
'backup_schedule_run_id' => (int) $scheduleRun->id,
|
|
'policies_total' => 5,
|
|
'policies_backed_up' => 18,
|
|
'sync_failures' => 0,
|
|
]);
|
|
});
|