ahmido
3030dd9af2
Summary Kurz: Implementiert Feature 054 — canonical OperationRun-flow, Monitoring UI, dispatch-safety, notifications, dedupe, plus small UX safety clarifications (RBAC group search delegated; Restore group mapping DB-only). What Changed Core service: OperationRun lifecycle, dedupe and dispatch helpers — OperationRunService.php. Model + migration: OperationRun model and migration — OperationRun.php, 2026_01_16_180642_create_operation_runs_table.php. Notifications: queued + terminal DB notifications (initiator-only) — OperationRunQueued.php, OperationRunCompleted.php. Monitoring UI: Filament list/detail + Livewire pieces (DB-only render) — OperationRunResource.php and related pages/views. Start surfaces / Jobs: instrumented start surfaces, job middleware, and job updates to use canonical runs — multiple app/Jobs/* and app/Filament/* updates (see tests for full coverage). RBAC + Restore UX clarifications: RBAC group search is delegated-Graph-based and disabled without delegated token; Restore group mapping remains DB-only (directory cache) and helper text always visible — TenantResource.php, RestoreRunResource.php. Specs / Constitution: updated spec & quickstart and added one-line constitution guideline about Graph usage: spec.md quickstart.md constitution.md Tests & Verification Unit / Feature tests added/updated for run lifecycle, notifications, idempotency, and UI guards: see tests/Feature/* (notably OperationRunServiceTest, MonitoringOperationsTest, OperationRunNotificationTest, and various Filament feature tests). Full test run locally: ./vendor/bin/sail artisan test → 587 passed, 5 skipped. Migrations Adds create_operation_runs_table migration; run php artisan migrate in staging after review. Notes / Rationale Monitoring pages are explicitly DB-only at render time (no Graph calls). Start surfaces enqueue work only and return a “View run” link. Delegated Graph access is used only for explicit user actions (RBAC group search); restore mapping intentionally uses cached DB data only to avoid render-time Graph calls. Dispatch wrapper marks runs failed immediately if background dispatch throws synchronously to avoid misleading “queued” states. Upgrade / Deploy Considerations Run migrations: ./vendor/bin/sail artisan migrate. Background workers should be running to process queued jobs (recommended to monitor queue health during rollout). No secret or token persistence changes. PR checklist Tests updated/added for changed behavior Specs updated: 054-unify-runs-suitewide docs + quickstart Constitution note added (.specify) Pint formatting applied Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #63
94 lines
2.8 KiB
PHP
94 lines
2.8 KiB
PHP
<?php
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\RestoreRun;
|
|
use App\Support\RestoreRunStatus;
|
|
|
|
it('creates an operation run only from previewed onward', function () {
|
|
$restoreRun = RestoreRun::factory()->create([
|
|
'status' => RestoreRunStatus::Checked->value,
|
|
]);
|
|
|
|
expect(OperationRun::query()
|
|
->where('tenant_id', $restoreRun->tenant_id)
|
|
->where('type', 'restore.execute')
|
|
->count())->toBe(0);
|
|
|
|
$restoreRun->update(['status' => RestoreRunStatus::Previewed->value]);
|
|
|
|
$opRun = OperationRun::query()
|
|
->where('tenant_id', $restoreRun->tenant_id)
|
|
->where('type', 'restore.execute')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($opRun)->not->toBeNull();
|
|
expect($opRun?->status)->toBe('queued');
|
|
expect($opRun?->outcome)->toBe('pending');
|
|
expect($opRun?->context)->toMatchArray([
|
|
'restore_run_id' => (int) $restoreRun->getKey(),
|
|
'backup_set_id' => (int) $restoreRun->backup_set_id,
|
|
'is_dry_run' => (bool) $restoreRun->is_dry_run,
|
|
]);
|
|
});
|
|
|
|
it('updates the operation run when restore completes', function () {
|
|
$restoreRun = RestoreRun::factory()->create([
|
|
'status' => RestoreRunStatus::Previewed->value,
|
|
]);
|
|
|
|
$opRun = OperationRun::query()
|
|
->where('tenant_id', $restoreRun->tenant_id)
|
|
->where('type', 'restore.execute')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($opRun)->not->toBeNull();
|
|
expect($opRun?->status)->toBe('queued');
|
|
|
|
$restoreRun->update([
|
|
'status' => RestoreRunStatus::Completed->value,
|
|
'results' => [
|
|
'assignment_outcomes' => [
|
|
['status' => 'success'],
|
|
['status' => 'failed'],
|
|
['status' => 'skipped'],
|
|
],
|
|
],
|
|
]);
|
|
|
|
$opRun->refresh();
|
|
|
|
expect($opRun->status)->toBe('completed');
|
|
expect($opRun->outcome)->toBe('succeeded');
|
|
expect($opRun->summary_counts)->toMatchArray([
|
|
'assignments_success' => 1,
|
|
'assignments_failed' => 1,
|
|
'assignments_skipped' => 1,
|
|
]);
|
|
expect($opRun->completed_at)->not->toBeNull();
|
|
});
|
|
|
|
it('maps cancelled restore runs to failed outcome (cancelled is reserved)', function () {
|
|
$restoreRun = RestoreRun::factory()->create([
|
|
'status' => RestoreRunStatus::Previewed->value,
|
|
]);
|
|
|
|
$opRun = OperationRun::query()
|
|
->where('tenant_id', $restoreRun->tenant_id)
|
|
->where('type', 'restore.execute')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($opRun)->not->toBeNull();
|
|
|
|
$restoreRun->update(['status' => RestoreRunStatus::Cancelled->value]);
|
|
|
|
$opRun->refresh();
|
|
|
|
expect($opRun->status)->toBe('completed');
|
|
expect($opRun->outcome)->toBe('failed');
|
|
expect($opRun->failure_summary)->toBeArray();
|
|
expect($opRun->failure_summary[0]['code'] ?? null)->toBe('restore.cancelled');
|
|
});
|