Summary Adds a tenant-scoped Entra Groups “Directory Cache” to enable DB-only group name resolution across the app (no render-time Graph calls), plus sync runs + observability. What’s included • Entra Groups cache • New entra_groups storage (tenant-scoped) for group metadata (no memberships). • Retention semantics: groups become stale / retained per spec (no hard delete on first miss). • Group Sync Runs • New “Group Sync Runs” UI (list + detail) with tenant isolation (403 on cross-tenant access). • Manual “Sync Groups” action: creates/reuses a run, dispatches job, DB notification with “View run” link. • Scheduled dispatcher command wired in console.php. • DB-only label resolution (US3) • Shared EntraGroupLabelResolver with safe fallback Unresolved (…last8) and UUID guarding. • Refactors to prefer cached names (no typeahead / no live Graph) in: • Tenant RBAC group selects • Policy version assignments widget • Restore results + restore wizard group mapping labels Safety / Guardrails • No render-time Graph calls: fail-hard guard test verifies UI paths don’t call GraphClientInterface during page render. • Tenant isolation & authorization: policies + scoped queries enforced (cross-tenant access returns 403, not 404). • Data minimization: only group metadata is cached (no membership/owners). Tests / Verification • Added/updated tests under tests/Feature/DirectoryGroups and tests/Unit/DirectoryGroups: • Start sync → run record + job dispatch + upserts • Retention purge semantics • Scheduled dispatch wiring • Render-time Graph guard • UI/resource access isolation • Ran: • ./vendor/bin/pint --dirty • ./vendor/bin/sail artisan test tests/Feature/DirectoryGroups • ./vendor/bin/sail artisan test tests/Unit/DirectoryGroups Notes / Follow-ups • UI polish remains (picker/lookup UX, consistent progress widget/toasts across modules, navigation grouping). • pr-gate checklist still has non-blocking open items (mostly UX/ops polish); requirements gate is green. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #57
144 lines
5.8 KiB
PHP
144 lines
5.8 KiB
PHP
<?php
|
|
|
|
namespace App\Filament\Resources;
|
|
|
|
use App\Filament\Resources\EntraGroupSyncRunResource\Pages;
|
|
use App\Models\EntraGroupSyncRun;
|
|
use App\Models\Tenant;
|
|
use BackedEnum;
|
|
use Filament\Actions;
|
|
use Filament\Infolists\Components\TextEntry;
|
|
use Filament\Infolists\Components\ViewEntry;
|
|
use Filament\Resources\Resource;
|
|
use Filament\Schemas\Components\Section;
|
|
use Filament\Schemas\Schema;
|
|
use Filament\Tables;
|
|
use Filament\Tables\Table;
|
|
use Illuminate\Database\Eloquent\Builder;
|
|
use UnitEnum;
|
|
|
|
class EntraGroupSyncRunResource extends Resource
|
|
{
|
|
protected static bool $isScopedToTenant = false;
|
|
|
|
protected static ?string $model = EntraGroupSyncRun::class;
|
|
|
|
protected static string|BackedEnum|null $navigationIcon = 'heroicon-o-user-group';
|
|
|
|
protected static string|UnitEnum|null $navigationGroup = 'Directory';
|
|
|
|
protected static ?string $navigationLabel = 'Group Sync Runs';
|
|
|
|
public static function form(Schema $schema): Schema
|
|
{
|
|
return $schema;
|
|
}
|
|
|
|
public static function infolist(Schema $schema): Schema
|
|
{
|
|
return $schema
|
|
->schema([
|
|
Section::make('Sync Run')
|
|
->schema([
|
|
TextEntry::make('initiator.name')
|
|
->label('Initiator')
|
|
->placeholder('—'),
|
|
TextEntry::make('status')
|
|
->badge()
|
|
->color(fn (EntraGroupSyncRun $record): string => static::statusColor($record->status)),
|
|
TextEntry::make('selection_key')->label('Selection'),
|
|
TextEntry::make('slot_key')->label('Slot')->placeholder('—')->copyable(),
|
|
TextEntry::make('started_at')->dateTime(),
|
|
TextEntry::make('finished_at')->dateTime(),
|
|
TextEntry::make('pages_fetched')->label('Pages')->numeric(),
|
|
TextEntry::make('items_observed_count')->label('Observed')->numeric(),
|
|
TextEntry::make('items_upserted_count')->label('Upserted')->numeric(),
|
|
TextEntry::make('error_count')->label('Errors')->numeric(),
|
|
TextEntry::make('safety_stop_triggered')->label('Safety stop')->badge(),
|
|
TextEntry::make('safety_stop_reason')->label('Stop reason')->placeholder('—'),
|
|
])
|
|
->columns(2)
|
|
->columnSpanFull(),
|
|
|
|
Section::make('Error Summary')
|
|
->schema([
|
|
TextEntry::make('error_code')->placeholder('—'),
|
|
TextEntry::make('error_category')->placeholder('—'),
|
|
ViewEntry::make('error_summary')
|
|
->label('Safe error summary')
|
|
->view('filament.infolists.entries.snapshot-json')
|
|
->state(fn (EntraGroupSyncRun $record) => $record->error_summary ? ['summary' => $record->error_summary] : [])
|
|
->columnSpanFull(),
|
|
])
|
|
->columns(2)
|
|
->columnSpanFull(),
|
|
]);
|
|
}
|
|
|
|
public static function table(Table $table): Table
|
|
{
|
|
return $table
|
|
->defaultSort('id', 'desc')
|
|
->modifyQueryUsing(function (Builder $query): Builder {
|
|
$tenantId = Tenant::current()?->getKey();
|
|
|
|
return $query->when($tenantId, fn (Builder $q) => $q->where('tenant_id', $tenantId));
|
|
})
|
|
->columns([
|
|
Tables\Columns\TextColumn::make('initiator.name')
|
|
->label('Initiator')
|
|
->placeholder('—')
|
|
->toggleable(),
|
|
Tables\Columns\TextColumn::make('status')
|
|
->badge()
|
|
->color(fn (EntraGroupSyncRun $record): string => static::statusColor($record->status)),
|
|
Tables\Columns\TextColumn::make('selection_key')
|
|
->label('Selection')
|
|
->limit(24)
|
|
->copyable(),
|
|
Tables\Columns\TextColumn::make('slot_key')
|
|
->label('Slot')
|
|
->placeholder('—')
|
|
->limit(16)
|
|
->copyable(),
|
|
Tables\Columns\TextColumn::make('started_at')->since(),
|
|
Tables\Columns\TextColumn::make('finished_at')->since(),
|
|
Tables\Columns\TextColumn::make('pages_fetched')->label('Pages')->numeric(),
|
|
Tables\Columns\TextColumn::make('items_observed_count')->label('Observed')->numeric(),
|
|
Tables\Columns\TextColumn::make('items_upserted_count')->label('Upserted')->numeric(),
|
|
Tables\Columns\TextColumn::make('error_count')->label('Errors')->numeric(),
|
|
])
|
|
->actions([
|
|
Actions\ViewAction::make(),
|
|
])
|
|
->bulkActions([]);
|
|
}
|
|
|
|
public static function getEloquentQuery(): Builder
|
|
{
|
|
return parent::getEloquentQuery()
|
|
->with('initiator')
|
|
->latest('id');
|
|
}
|
|
|
|
public static function getPages(): array
|
|
{
|
|
return [
|
|
'index' => Pages\ListEntraGroupSyncRuns::route('/'),
|
|
'view' => Pages\ViewEntraGroupSyncRun::route('/{record}'),
|
|
];
|
|
}
|
|
|
|
private static function statusColor(?string $status): string
|
|
{
|
|
return match ($status) {
|
|
EntraGroupSyncRun::STATUS_SUCCEEDED => 'success',
|
|
EntraGroupSyncRun::STATUS_PARTIAL => 'warning',
|
|
EntraGroupSyncRun::STATUS_FAILED => 'danger',
|
|
EntraGroupSyncRun::STATUS_RUNNING => 'info',
|
|
EntraGroupSyncRun::STATUS_PENDING => 'gray',
|
|
default => 'gray',
|
|
};
|
|
}
|
|
}
|