ahmido
d90fb0f963
PR Body Implements Spec 065 “Tenant RBAC v1” with capabilities-first RBAC, tenant membership scoping (Option 3), and consistent Filament action semantics. Key decisions / rules Tenancy Option 3: tenant switching is tenantless (ChooseTenant), tenant-scoped routes stay scoped, non-members get 404 (not 403). RBAC model: canonical capability registry + role→capability map + Gates for each capability (no role-string checks in UI logic). UX policy: for tenant members lacking permission → actions are visible but disabled + tooltip (avoid click→403). Security still enforced server-side. What’s included Capabilities foundation: Central capability registry (Capabilities::*) Role→capability mapping (RoleCapabilityMap) Gate registration + resolver/manager updates to support tenant-scoped authorization Filament enforcement hardening across the app: Tenant registration & tenant CRUD properly gated Backup/restore/policy flows aligned to “visible-but-disabled” where applicable Provider operations (health check / inventory sync / compliance snapshot) guarded and normalized Directory groups + inventory sync start surfaces normalized Policy version maintenance actions (archive/restore/prune/force delete) gated SpecKit artifacts for 065: spec.md, plan/tasks updates, checklists, enforcement hitlist Security guarantees Non-member → 404 via tenant scoping/membership guards. Member without capability → 403 on execution, even if UI is disabled. No destructive actions execute without proper authorization checks. Tests Adds/updates Pest coverage for: Tenant scoping & membership denial behavior Role matrix expectations (owner/manager/operator/readonly) Filament surface checks (visible/disabled actions, no side effects) Provider/Inventory/Groups run-start authorization Verified locally with targeted vendor/bin/sail artisan test --compact … Deployment / ops notes No new services required. Safe change: behavior is authorization + UI semantics; no breaking route changes intended. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #79
71 lines
2.1 KiB
PHP
71 lines
2.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\ProviderConnectionResource;
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\Tenant;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('returns 404 for non-members on tenant-scoped routes', function (): void {
|
|
$tenantA = Tenant::factory()->create(['name' => 'Tenant A']);
|
|
$tenantB = Tenant::factory()->create(['name' => 'Tenant B']);
|
|
|
|
[$user] = createUserWithTenant($tenantA, role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->get(ProviderConnectionResource::getUrl('index', tenant: $tenantB))
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('does not show non-member tenants in the choose-tenant list', function (): void {
|
|
$tenantA = Tenant::factory()->create(['name' => 'Tenant A']);
|
|
$tenantB = Tenant::factory()->create(['name' => 'Tenant B']);
|
|
|
|
[$user] = createUserWithTenant($tenantA, role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/choose-tenant')
|
|
->assertOk()
|
|
->assertSee('Tenant A')
|
|
->assertDontSee('Tenant B');
|
|
});
|
|
|
|
it('scopes global search results to the current tenant and denies non-members', function (): void {
|
|
$tenantA = Tenant::factory()->create(['name' => 'Tenant A']);
|
|
$tenantB = Tenant::factory()->create(['name' => 'Tenant B']);
|
|
|
|
[$user] = createUserWithTenant($tenantA, role: 'owner');
|
|
|
|
ProviderConnection::factory()->create([
|
|
'tenant_id' => $tenantA->getKey(),
|
|
'display_name' => 'Acme Connection A',
|
|
]);
|
|
|
|
ProviderConnection::factory()->create([
|
|
'tenant_id' => $tenantB->getKey(),
|
|
'display_name' => 'Acme Connection B',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenantA, true);
|
|
|
|
$resultsA = ProviderConnectionResource::getGlobalSearchResults('Acme');
|
|
|
|
expect($resultsA)->toHaveCount(1);
|
|
expect((string) $resultsA->first()?->title)->toBe('Acme Connection A');
|
|
|
|
Filament::setTenant($tenantB, true);
|
|
|
|
$resultsB = ProviderConnectionResource::getGlobalSearchResults('Acme');
|
|
|
|
expect($resultsB)->toHaveCount(0);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$resultsNone = ProviderConnectionResource::getGlobalSearchResults('Acme');
|
|
|
|
expect($resultsNone)->toHaveCount(0);
|
|
});
|