Implementiert Feature 066: “RBAC UI Enforcement Helper v2” inkl. Migration der betroffenen Filament-Surfaces + Regression-Tests. Was ist drin Neuer Helper: UiEnforcement.php: mixed visibility (preserveVisibility, andVisibleWhen, andHiddenWhen), tenant resolver (tenantFromFilament, tenantFromRecord, tenantFrom(callable)), bulk preflight (preflightByCapability, preflightByTenantMembership, preflightSelection) + server-side authorizeOrAbort() / authorizeBulkSelectionOrAbort(). UiTooltips.php: standard Tooltip “Insufficient permission — ask a tenant Owner.” Filament migrations (weg von Gate::… / abort_* hin zu UiEnforcement): Backup/Restore (mixed visibility) TenantResource (record-scoped tenant actions + bulk preflight) Inventory/Entra/ProviderConnections (Tier-2 surfaces) Guardrails: NoAdHocFilamentAuthPatternsTest.php als CI-failing allowlist guard für app/Filament/**. Verhalten / Contract Non-member: deny-as-not-found (404) auf tenant routes; Actions hidden. Member ohne Capability: Action visible but disabled + standard tooltip; keine Ausführung. Member mit Capability: Action enabled; destructive/high-impact Actions bleiben confirmation-gated (->requiresConfirmation()). Server-side Enforcement bleibt vorhanden: Mutations/Operations rufen authorizeOrAbort() / authorizeBulkSelectionOrAbort(). Tests Neue/erweiterte Feature-Tests für RBAC UX inkl. Http::preventStrayRequests() (DB-only render): BackupSetUiEnforcementTest.php RestoreRunUiEnforcementTest.php ProviderConnectionsUiEnforcementTest.php diverse bestehende Filament Tests erweitert (Inventory/Entra/Tenant actions/bulk) Unit-Tests: UiEnforcementTest.php UiEnforcementBulkPreflightQueryCountTest.php Verification vendor/bin/sail bin pint --dirty ✅ vendor/bin/sail artisan test --compact tests/Unit/Auth tests/Feature/Filament tests/Feature/Guards tests/Feature/Rbac ✅ (185 passed, 5 skipped) Notes für Reviewer Filament v5 / Livewire v4 compliant. Destructive actions: weiterhin ->requiresConfirmation() + server-side auth. Bulk: authorization preflight ist set-based (Query-count test vorhanden). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #83
129 lines
3.8 KiB
PHP
129 lines
3.8 KiB
PHP
<?php
|
|
|
|
use App\Models\Tenant;
|
|
use App\Support\Auth\Capabilities;
|
|
use App\Support\Auth\UiEnforcement;
|
|
use App\Support\Auth\UiTooltips;
|
|
use Filament\Actions\Action;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('forbids preserveVisibility on record-scoped tenant resolution', function () {
|
|
expect(fn () => UiEnforcement::for(Capabilities::TENANT_VIEW)->tenantFromRecord()->preserveVisibility())
|
|
->toThrow(LogicException::class);
|
|
|
|
expect(fn () => UiEnforcement::for(Capabilities::TENANT_VIEW)->preserveVisibility()->tenantFromRecord())
|
|
->toThrow(LogicException::class);
|
|
});
|
|
|
|
it('hides actions for non-members on record-scoped surfaces', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant();
|
|
|
|
$action = Action::make('test');
|
|
|
|
UiEnforcement::for(Capabilities::TENANT_VIEW)
|
|
->tenantFromRecord()
|
|
->apply($action);
|
|
|
|
$this->actingAs($user);
|
|
$action->record($tenant);
|
|
|
|
expect($action->isHidden())->toBeTrue();
|
|
});
|
|
|
|
it('disables actions with the standard tooltip for members without the capability', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant, role: 'readonly');
|
|
|
|
$action = Action::make('test');
|
|
|
|
UiEnforcement::for(Capabilities::TENANT_SYNC)
|
|
->tenantFromRecord()
|
|
->apply($action);
|
|
|
|
$this->actingAs($user);
|
|
$action->record($tenant);
|
|
|
|
expect($action->isHidden())->toBeFalse();
|
|
expect($action->isDisabled())->toBeTrue();
|
|
expect($action->getTooltip())->toBe(UiTooltips::insufficientPermission());
|
|
});
|
|
|
|
it('enables actions for members with the capability', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
$action = Action::make('test');
|
|
|
|
UiEnforcement::for(Capabilities::TENANT_SYNC)
|
|
->tenantFromRecord()
|
|
->apply($action);
|
|
|
|
$this->actingAs($user);
|
|
$action->record($tenant);
|
|
|
|
expect($action->isHidden())->toBeFalse();
|
|
expect($action->isDisabled())->toBeFalse();
|
|
expect($action->getTooltip())->toBeNull();
|
|
});
|
|
|
|
it('supports mixed visibility composition via andVisibleWhen', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$action = Action::make('test');
|
|
|
|
UiEnforcement::for(Capabilities::TENANT_VIEW)
|
|
->andVisibleWhen(fn (): bool => false)
|
|
->apply($action);
|
|
|
|
$this->actingAs($user);
|
|
|
|
expect($action->isHidden())->toBeTrue();
|
|
});
|
|
|
|
it('supports mixed visibility composition via andHiddenWhen', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$action = Action::make('test');
|
|
|
|
UiEnforcement::for(Capabilities::TENANT_VIEW)
|
|
->andHiddenWhen(fn (): bool => true)
|
|
->apply($action);
|
|
|
|
$this->actingAs($user);
|
|
|
|
expect($action->isHidden())->toBeTrue();
|
|
});
|
|
|
|
it('disables bulk actions for mixed-authorization selections (capability preflight)', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create();
|
|
|
|
[$user] = createUserWithTenant($tenantA, role: 'owner');
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantB->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
$enforcement = UiEnforcement::for(Capabilities::TENANT_SYNC)
|
|
->tenantFromRecord()
|
|
->preflightByCapability();
|
|
|
|
expect($enforcement->bulkSelectionIsAuthorized($user, collect([$tenantA, $tenantB])))->toBeFalse();
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantB->getKey() => ['role' => 'owner'],
|
|
]);
|
|
|
|
expect($enforcement->bulkSelectionIsAuthorized($user, collect([$tenantA, $tenantB])))->toBeTrue();
|
|
});
|
|
|