## Summary - replace the legacy Tenant and TenantMembership core models with ManagedEnvironment and ManagedEnvironmentMembership - propagate the managed environment naming and key changes across Filament resources, pages, controllers, jobs, models, and supporting runtime paths - add feature 279 spec artifacts and focused managed-environment test coverage for model behavior, route binding, panel context, authorization, and legacy guardrails ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentAuthorizationTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentPanelContextTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentRouteBindingTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentContextResolverTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentModelTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - branch pushed from commit `1123b122` - browser smoke test file was added but not run in this pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #335
73 lines
2.5 KiB
PHP
73 lines
2.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\ProductUsageEvent;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Services\OperationRunService;
|
|
use App\Support\OperationRunType;
|
|
use App\Support\ProductTelemetry\ProductUsageEventCatalog;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('records telemetry for user-initiated tenant-bound operation starts only once per created run', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'operator');
|
|
|
|
$service = app(OperationRunService::class);
|
|
|
|
$run = $service->ensureRun(
|
|
tenant: $tenant,
|
|
type: OperationRunType::ReviewPackGenerate->value,
|
|
inputs: [
|
|
'include_pii' => true,
|
|
'include_operations' => true,
|
|
],
|
|
initiator: $user,
|
|
);
|
|
|
|
$sameRun = $service->ensureRun(
|
|
tenant: $tenant,
|
|
type: OperationRunType::ReviewPackGenerate->value,
|
|
inputs: [
|
|
'include_pii' => true,
|
|
'include_operations' => true,
|
|
],
|
|
initiator: $user,
|
|
);
|
|
|
|
expect($sameRun->getKey())->toBe($run->getKey())
|
|
->and(ProductUsageEvent::query()->count())->toBe(1);
|
|
|
|
$event = ProductUsageEvent::query()->sole();
|
|
$serializedEvent = json_encode($event->toArray(), JSON_THROW_ON_ERROR);
|
|
|
|
expect($event->event_name)->toBe(ProductUsageEventCatalog::OPERATIONS_STARTED)
|
|
->and($event->managed_environment_id)->toBe((int) $tenant->getKey())
|
|
->and($event->workspace_id)->toBe((int) $tenant->workspace_id)
|
|
->and($event->user_id)->toBe((int) $user->getKey())
|
|
->and($event->subject_type)->toBe('operation_run')
|
|
->and($event->subject_id)->toBe((string) $run->getKey())
|
|
->and($event->metadata)->toBe([
|
|
'operation_type' => OperationRunType::ReviewPackGenerate->value,
|
|
])
|
|
->and($serializedEvent)->not->toContain('@')
|
|
->and($serializedEvent)->not->toContain($user->name)
|
|
->and($serializedEvent)->not->toContain((string) $tenant->name);
|
|
});
|
|
|
|
it('does not record telemetry for system-initiated operation starts', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
|
|
app(OperationRunService::class)->ensureRun(
|
|
tenant: $tenant,
|
|
type: OperationRunType::ReviewPackGenerate->value,
|
|
inputs: [
|
|
'include_pii' => true,
|
|
],
|
|
initiator: null,
|
|
);
|
|
|
|
expect(ProductUsageEvent::query()->count())->toBe(0);
|
|
}); |