Ordering + limit-only Test für created_at DESC in DependencyExtractionFeatureTest.php UI Test für masked Identifier (ID: 123456…) + Guest-Access blocked in InventoryItemDependenciesTest.php Quickstart ergänzt um manuellen <2s Check in quickstart.md pr-gate Checkbox-Format normalisiert (kein leading space) in pr-gate.md Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #49
189 lines
6.2 KiB
PHP
189 lines
6.2 KiB
PHP
<?php
|
|
|
|
use App\Filament\Resources\InventoryItemResource;
|
|
use App\Models\InventoryItem;
|
|
use App\Models\InventoryLink;
|
|
use App\Models\Tenant;
|
|
use Illuminate\Support\Str;
|
|
|
|
it('shows zero-state when no dependencies and shows missing badge when applicable', function () {
|
|
[$user, $tenant] = createUserWithTenant();
|
|
$this->actingAs($user);
|
|
|
|
/** @var InventoryItem $item */
|
|
$item = InventoryItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'external_id' => (string) Str::uuid(),
|
|
]);
|
|
|
|
// Zero state
|
|
$url = InventoryItemResource::getUrl('view', ['record' => $item], tenant: $tenant);
|
|
$this->get($url)->assertOk()->assertSee('No dependencies found');
|
|
|
|
// Create a missing edge and assert badge appears
|
|
InventoryLink::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'source_type' => 'inventory_item',
|
|
'source_id' => $item->external_id,
|
|
'target_type' => 'missing',
|
|
'target_id' => null,
|
|
'relationship_type' => 'assigned_to',
|
|
'metadata' => [
|
|
'last_known_name' => 'Ghost Target',
|
|
'raw_ref' => ['example' => 'ref'],
|
|
],
|
|
]);
|
|
|
|
$this->get($url)
|
|
->assertOk()
|
|
->assertSee('Missing')
|
|
->assertSee('Last known: Ghost Target');
|
|
});
|
|
|
|
it('direction filter limits to outbound or inbound', function () {
|
|
[$user, $tenant] = createUserWithTenant();
|
|
$this->actingAs($user);
|
|
|
|
/** @var InventoryItem $item */
|
|
$item = InventoryItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'external_id' => (string) Str::uuid(),
|
|
]);
|
|
|
|
// Outbound only
|
|
InventoryLink::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'source_type' => 'inventory_item',
|
|
'source_id' => $item->external_id,
|
|
'target_type' => 'foundation_object',
|
|
'target_id' => (string) Str::uuid(),
|
|
'relationship_type' => 'assigned_to',
|
|
]);
|
|
|
|
// Inbound only
|
|
InventoryLink::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'source_type' => 'inventory_item',
|
|
'source_id' => (string) Str::uuid(),
|
|
'target_type' => 'inventory_item',
|
|
'target_id' => $item->external_id,
|
|
'relationship_type' => 'depends_on',
|
|
]);
|
|
|
|
$urlOutbound = InventoryItemResource::getUrl('view', ['record' => $item], tenant: $tenant).'?direction=outbound';
|
|
$this->get($urlOutbound)->assertOk()->assertDontSee('No dependencies found');
|
|
|
|
$urlInbound = InventoryItemResource::getUrl('view', ['record' => $item], tenant: $tenant).'?direction=inbound';
|
|
$this->get($urlInbound)->assertOk()->assertDontSee('No dependencies found');
|
|
});
|
|
|
|
it('relationship filter limits edges by type', function () {
|
|
[$user, $tenant] = createUserWithTenant();
|
|
$this->actingAs($user);
|
|
|
|
/** @var InventoryItem $item */
|
|
$item = InventoryItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'external_id' => (string) Str::uuid(),
|
|
]);
|
|
|
|
// Two outbound edges with different relationship types.
|
|
InventoryLink::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'source_type' => 'inventory_item',
|
|
'source_id' => $item->external_id,
|
|
'target_type' => 'missing',
|
|
'target_id' => null,
|
|
'relationship_type' => 'assigned_to',
|
|
'metadata' => ['last_known_name' => 'Assigned Target'],
|
|
]);
|
|
|
|
InventoryLink::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'source_type' => 'inventory_item',
|
|
'source_id' => $item->external_id,
|
|
'target_type' => 'missing',
|
|
'target_id' => null,
|
|
'relationship_type' => 'scoped_by',
|
|
'metadata' => ['last_known_name' => 'Scoped Target'],
|
|
]);
|
|
|
|
$url = InventoryItemResource::getUrl('view', ['record' => $item], tenant: $tenant)
|
|
.'?direction=outbound&relationship_type=scoped_by';
|
|
|
|
$this->get($url)
|
|
->assertOk()
|
|
->assertSee('Scoped Target')
|
|
->assertDontSee('Assigned Target');
|
|
});
|
|
|
|
it('does not show edges from other tenants (tenant isolation)', function () {
|
|
[$user, $tenant] = createUserWithTenant();
|
|
$this->actingAs($user);
|
|
|
|
/** @var InventoryItem $item */
|
|
$item = InventoryItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'external_id' => (string) Str::uuid(),
|
|
]);
|
|
|
|
$otherTenant = Tenant::factory()->create();
|
|
|
|
// Same source_id, but different tenant_id: must not be rendered.
|
|
InventoryLink::factory()->create([
|
|
'tenant_id' => $otherTenant->getKey(),
|
|
'source_type' => 'inventory_item',
|
|
'source_id' => $item->external_id,
|
|
'target_type' => 'missing',
|
|
'target_id' => null,
|
|
'relationship_type' => 'assigned_to',
|
|
'metadata' => ['last_known_name' => 'Other Tenant Edge'],
|
|
]);
|
|
|
|
$url = InventoryItemResource::getUrl('view', ['record' => $item], tenant: $tenant);
|
|
$this->get($url)
|
|
->assertOk()
|
|
->assertDontSee('Other Tenant Edge');
|
|
});
|
|
|
|
it('shows masked identifier when last known name is missing', function () {
|
|
[$user, $tenant] = createUserWithTenant();
|
|
$this->actingAs($user);
|
|
|
|
/** @var InventoryItem $item */
|
|
$item = InventoryItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'external_id' => (string) Str::uuid(),
|
|
]);
|
|
|
|
InventoryLink::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'source_type' => 'inventory_item',
|
|
'source_id' => $item->external_id,
|
|
'target_type' => 'foundation_object',
|
|
'target_id' => '12345678-1234-1234-1234-123456789012',
|
|
'relationship_type' => 'assigned_to',
|
|
'metadata' => [
|
|
'last_known_name' => null,
|
|
],
|
|
]);
|
|
|
|
$url = InventoryItemResource::getUrl('view', ['record' => $item], tenant: $tenant);
|
|
$this->get($url)
|
|
->assertOk()
|
|
->assertSee('ID: 123456…');
|
|
});
|
|
|
|
it('blocks guest access to inventory item dependencies view', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
/** @var InventoryItem $item */
|
|
$item = InventoryItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'external_id' => (string) Str::uuid(),
|
|
]);
|
|
|
|
$url = InventoryItemResource::getUrl('view', ['record' => $item], tenant: $tenant);
|
|
$this->get($url)->assertRedirect();
|
|
});
|