ahmido
3a2a06e8d7
## Summary - align tenant dashboard KPI, attention, compare, and operations truth so the page does not read calmer than the tenant's actual state - preserve tenant-safe drill-through continuity into findings, baseline compare, and canonical operations, including disabled helper states for permission-limited members - add the Spec 173 artifact set and focused regression coverage for dashboard truth alignment and drill-through behavior ## Validation - `vendor/bin/sail bin pint --dirty --format agent` - `vendor/bin/sail artisan test --compact tests/Feature/Filament/DashboardKpisWidgetTest.php tests/Feature/Filament/TenantDashboardTruthAlignmentTest.php tests/Feature/Monitoring/OperationsDashboardDrillthroughTest.php tests/Feature/Filament/NeedsAttentionWidgetTest.php tests/Feature/Filament/BaselineCompareNowWidgetTest.php tests/Feature/Filament/BaselineCompareSummaryConsistencyTest.php tests/Feature/Findings/FindingsListDefaultsTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Findings/FindingAdminTenantParityTest.php tests/Feature/OpsUx/CanonicalViewRunLinksTest.php tests/Feature/Filament/TenantDashboardTenantScopeTest.php tests/Feature/Filament/TenantDashboardDbOnlyTest.php tests/Feature/Filament/TableStandardsBaselineTest.php tests/Feature/Filament/TableDetailVisibilityTest.php` - integrated browser smoke on the tenant dashboard, including a permission-limited member scenario Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #204
70 lines
2.4 KiB
PHP
70 lines
2.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\OperationRunLinks;
|
|
use Illuminate\Support\Facades\File;
|
|
|
|
it('routes all OperationRun view links through OperationRunLinks', function (): void {
|
|
$files = File::allFiles(app_path());
|
|
|
|
$violations = [];
|
|
|
|
foreach ($files as $file) {
|
|
$path = $file->getRealPath();
|
|
if (! is_string($path)) {
|
|
continue;
|
|
}
|
|
|
|
// OperationRunLinks is the canonical wrapper.
|
|
if (str_ends_with($path, '/Support/OperationRunLinks.php')) {
|
|
continue;
|
|
}
|
|
|
|
$contents = File::get($path);
|
|
|
|
if (preg_match("/\\bOperationRunResource::getUrl\(\\s*'view'/", $contents) === 1
|
|
|| preg_match("/route\(\s*'filament\.admin\.resources\.operations\.view'/", $contents) === 1) {
|
|
$violations[] = $path;
|
|
}
|
|
}
|
|
|
|
expect($violations)->toBeEmpty();
|
|
})->group('ops-ux');
|
|
|
|
it('resolves tenantless operation run links to the canonical admin.operations.view route', function (): void {
|
|
$run = OperationRun::factory()->create();
|
|
|
|
$expectedUrl = route('admin.operations.view', ['run' => (int) $run->getKey()]);
|
|
|
|
expect(OperationRunLinks::tenantlessView($run))->toBe($expectedUrl);
|
|
expect(OperationRunLinks::tenantlessView((int) $run->getKey()))->toBe($expectedUrl);
|
|
})->group('ops-ux');
|
|
|
|
it('normalizes tenant-scoped callers onto the canonical tenantless run route', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
$run = OperationRun::factory()->for($tenant)->create();
|
|
|
|
$expectedUrl = route('admin.operations.view', ['run' => (int) $run->getKey()]);
|
|
|
|
expect(OperationRunLinks::view($run, $tenant))->toBe($expectedUrl)
|
|
->and(OperationRunLinks::view((int) $run->getKey(), $tenant))->toBe($expectedUrl);
|
|
})->group('ops-ux');
|
|
|
|
it('preserves tenant prefilter and requested tab on canonical operations collection links', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
expect(OperationRunLinks::index($tenant, activeTab: 'active'))
|
|
->toBe(route('admin.operations.index', [
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'activeTab' => 'active',
|
|
]))
|
|
->and(OperationRunLinks::index($tenant, activeTab: 'blocked'))
|
|
->toBe(route('admin.operations.index', [
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'activeTab' => 'blocked',
|
|
]));
|
|
})->group('ops-ux');
|