## Summary
- centralize tenant operability into a lane-aware, actor-aware policy boundary
- align selector eligibility, administrative discoverability, remembered context, tenant-bound routes, and canonical run viewers
- add focused Pest coverage plus Spec 148 artifacts and final polish task completion
## Validation
- `vendor/bin/sail artisan test --compact tests/Unit/Tenants/TenantOperabilityServiceTest.php tests/Unit/Tenants/TenantOperabilityOutcomeTest.php tests/Feature/Workspaces/ChooseTenantPageTest.php tests/Feature/Workspaces/SelectTenantControllerTest.php tests/Feature/TenantRBAC/ArchivedTenantRouteAccessTest.php tests/Feature/TenantRBAC/TenantRouteDenyAsNotFoundTest.php tests/Feature/Operations/TenantlessOperationRunViewerTest.php tests/Feature/OpsUx/OperateHubShellTest.php tests/Feature/Rbac/TenantLifecycleActionVisibilityTest.php tests/Feature/TenantRBAC/TenantSwitcherScopeTest.php tests/Feature/Rbac/TenantResourceAuthorizationTest.php tests/Feature/Filament/ManagedTenantsLandingLifecycleTest.php tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php tests/Feature/Onboarding/OnboardingDraftLifecycleTest.php tests/Feature/Onboarding/OnboardingDraftAuthorizationTest.php`
- `vendor/bin/sail bin pint --dirty --format agent`
- manual browser smoke checks on `/admin/choose-tenant`, `/admin/tenants`, `/admin/onboarding`, `/admin/onboarding/{draft}`, and `/admin/operations/{run}`
## Filament / platform notes
- Livewire v4 compliance preserved
- panel provider registration unchanged in `bootstrap/providers.php`
- Tenant resource global search remains backed by existing view/edit pages and is now separated from active-only selector eligibility
- destructive actions remain action closures with confirmation and authorization enforcement
- no asset pipeline changes and no new `filament:assets` deployment requirement
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #177
162 lines
5.9 KiB
PHP
162 lines
5.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\ChooseTenant;
|
|
use App\Filament\Resources\TenantResource;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Filament\PanelRegistry;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('only returns active membership tenants for normal users', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$allowed = Tenant::factory()->active()->create(['name' => 'Allowed']);
|
|
$onboarding = Tenant::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $allowed->workspace_id,
|
|
'name' => 'Onboarding',
|
|
]);
|
|
$archived = Tenant::factory()->archived()->create([
|
|
'workspace_id' => (int) $allowed->workspace_id,
|
|
'name' => 'Archived',
|
|
]);
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$allowed->getKey() => ['role' => 'readonly'],
|
|
$onboarding->getKey() => ['role' => 'readonly'],
|
|
$archived->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
/** @var \Filament\Panel $panel */
|
|
$panel = app(PanelRegistry::class)->get('admin');
|
|
|
|
$tenants = $user->getTenants($panel);
|
|
|
|
expect($tenants)->toHaveCount(1);
|
|
expect($tenants->first()?->getKey())->toBe($allowed->getKey());
|
|
expect($tenants->contains(fn (Tenant $tenant): bool => $tenant->name === 'Onboarding'))->toBeFalse();
|
|
expect($tenants->contains(fn (Tenant $tenant): bool => $tenant->name === 'Archived'))->toBeFalse();
|
|
});
|
|
|
|
it('returns no tenants for users without active tenant memberships', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$draft = Tenant::factory()->draft()->create(['name' => 'Draft']);
|
|
$archived = Tenant::factory()->archived()->create([
|
|
'workspace_id' => (int) $draft->workspace_id,
|
|
'name' => 'Archived',
|
|
]);
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$draft->getKey() => ['role' => 'readonly'],
|
|
$archived->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
/** @var \Filament\Panel $panel */
|
|
$panel = app(PanelRegistry::class)->get('admin');
|
|
|
|
expect($user->getTenants($panel))->toHaveCount(0);
|
|
});
|
|
|
|
it('rejects selecting non-active memberships as tenant context', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$active = Tenant::factory()->active()->create(['name' => 'Allowed']);
|
|
$onboarding = Tenant::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $active->workspace_id,
|
|
'name' => 'Onboarding',
|
|
]);
|
|
$archived = Tenant::factory()->archived()->create([
|
|
'workspace_id' => (int) $active->workspace_id,
|
|
'name' => 'Archived',
|
|
]);
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$active->getKey() => ['role' => 'readonly'],
|
|
$onboarding->getKey() => ['role' => 'readonly'],
|
|
$archived->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $active->workspace_id);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(ChooseTenant::class)
|
|
->call('selectTenant', $onboarding->getKey())
|
|
->assertStatus(404);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(ChooseTenant::class)
|
|
->call('selectTenant', $archived->getKey())
|
|
->assertStatus(404);
|
|
});
|
|
|
|
it('keeps tenant global-search broader than selector eligibility when the user only has administratively discoverable memberships', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$draft = Tenant::factory()->draft()->create(['name' => 'Search Draft']);
|
|
$onboarding = Tenant::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $draft->workspace_id,
|
|
'name' => 'Search Onboarding',
|
|
]);
|
|
$archived = Tenant::factory()->archived()->create([
|
|
'workspace_id' => (int) $draft->workspace_id,
|
|
'name' => 'Search Archived',
|
|
]);
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$draft->getKey() => ['role' => 'readonly'],
|
|
$onboarding->getKey() => ['role' => 'readonly'],
|
|
$archived->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
|
|
Filament::setCurrentPanel('admin');
|
|
Filament::setTenant(null, true);
|
|
Filament::bootCurrentPanel();
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $draft->workspace_id);
|
|
|
|
expect(TenantResource::getGlobalSearchResults('Search'))
|
|
->toHaveCount(3)
|
|
->sequence(
|
|
fn ($result) => $result->title->toContain('Search'),
|
|
fn ($result) => $result->title->toContain('Search'),
|
|
fn ($result) => $result->title->toContain('Search'),
|
|
);
|
|
});
|
|
|
|
it('does not render onboarding or archived tenants in the header selector on workspace pages', function (): void {
|
|
$activeTenant = Tenant::factory()->active()->create(['name' => 'Header Active Tenant']);
|
|
[$user, $activeTenant] = createUserWithTenant(tenant: $activeTenant, role: 'owner');
|
|
|
|
$onboardingTenant = Tenant::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'name' => 'Header Onboarding Tenant',
|
|
]);
|
|
$archivedTenant = Tenant::factory()->archived()->create([
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'name' => 'Header Archived Tenant',
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $onboardingTenant, user: $user, role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
|
createUserWithTenant(tenant: $archivedTenant, user: $user, role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
|
->get(route('admin.operations.index'))
|
|
->assertSuccessful()
|
|
->assertSee('Header Active Tenant')
|
|
->assertDontSee('Header Onboarding Tenant')
|
|
->assertDontSee('Header Archived Tenant')
|
|
->assertSee('No tenant selected');
|
|
});
|