ahmido
d6e7de597a
Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
100 lines
3.4 KiB
PHP
100 lines
3.4 KiB
PHP
<?php
|
|
|
|
use App\Filament\Resources\FindingResource;
|
|
use App\Models\Finding;
|
|
use App\Models\InventoryItem;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
|
|
test('finding detail shows a normalized settings diff for policy_snapshot evidence', function () {
|
|
bindFailHardGraphClient();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$baseline = createInventorySyncOperationRun($tenant, [
|
|
'selection_hash' => hash('sha256', 'scope-settings-diff'),
|
|
'status' => 'success',
|
|
'finished_at' => now()->subDays(2),
|
|
]);
|
|
|
|
$current = createInventorySyncOperationRun($tenant, [
|
|
'selection_hash' => $baseline->selection_hash,
|
|
'status' => 'success',
|
|
'finished_at' => now()->subDay(),
|
|
]);
|
|
|
|
$policy = Policy::factory()->for($tenant)->create([
|
|
'external_id' => 'policy-123',
|
|
'policy_type' => 'deviceConfiguration',
|
|
'platform' => 'windows10',
|
|
]);
|
|
|
|
$baselineVersion = PolicyVersion::factory()->for($tenant)->create([
|
|
'policy_id' => $policy->getKey(),
|
|
'version_number' => 1,
|
|
'policy_type' => $policy->policy_type,
|
|
'platform' => $policy->platform,
|
|
'captured_at' => $baseline->finished_at->copy()->subHour(),
|
|
'snapshot' => [
|
|
'displayName' => 'My Policy',
|
|
'description' => 'Old description',
|
|
'customSettingFoo' => 'Old value',
|
|
],
|
|
]);
|
|
|
|
$currentVersion = PolicyVersion::factory()->for($tenant)->create([
|
|
'policy_id' => $policy->getKey(),
|
|
'version_number' => 2,
|
|
'policy_type' => $policy->policy_type,
|
|
'platform' => $policy->platform,
|
|
'captured_at' => $current->finished_at->copy()->subHour(),
|
|
'snapshot' => [
|
|
'displayName' => 'My Policy',
|
|
'description' => 'New description',
|
|
'customSettingFoo' => 'New value',
|
|
],
|
|
]);
|
|
|
|
$finding = Finding::factory()->for($tenant)->create([
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'scope_key' => (string) $current->selection_hash,
|
|
'baseline_operation_run_id' => $baseline->getKey(),
|
|
'current_operation_run_id' => $current->getKey(),
|
|
'subject_type' => 'policy',
|
|
'subject_external_id' => $policy->external_id,
|
|
'evidence_jsonb' => [
|
|
'change_type' => 'modified',
|
|
'summary' => [
|
|
'kind' => 'policy_snapshot',
|
|
'changed_fields' => ['snapshot_hash'],
|
|
],
|
|
'baseline' => [
|
|
'policy_id' => $policy->external_id,
|
|
'policy_version_id' => $baselineVersion->getKey(),
|
|
'snapshot_hash' => 'baseline-hash',
|
|
],
|
|
'current' => [
|
|
'policy_id' => $policy->external_id,
|
|
'policy_version_id' => $currentVersion->getKey(),
|
|
'snapshot_hash' => 'current-hash',
|
|
],
|
|
],
|
|
]);
|
|
|
|
InventoryItem::factory()->for($tenant)->create([
|
|
'external_id' => $finding->subject_external_id,
|
|
'display_name' => 'My Policy 123',
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->get(FindingResource::getUrl('view', ['record' => $finding], tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('Normalized diff')
|
|
->assertSee('1 changed')
|
|
->assertSee('Custom Setting Foo')
|
|
->assertSee('From')
|
|
->assertSee('To')
|
|
->assertSee('Old value')
|
|
->assertSee('New value');
|
|
});
|