Implements Spec 117 (Golden Master Baseline Drift Engine): - Adds provider-chain resolver for current state hashes (content evidence via PolicyVersion, meta evidence via inventory) - Updates baseline capture + compare jobs to use resolver and persist provenance + fidelity - Adds evidence_fidelity column/index + Filament UI badge/filter/provenance display for findings - Adds performance guard test + integration tests for drift, fidelity semantics, provenance, filter behavior - UX fix: Policies list shows "Sync from Intune" header action only when records exist; empty-state CTA remains and is functional Tests: - `vendor/bin/sail artisan test --compact tests/Feature/Filament/PolicySyncCtaPlacementTest.php` - `vendor/bin/sail artisan test --compact --filter=Baseline` Checklist: - specs/117-baseline-drift-engine/checklists/requirements.md ✓ Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #142
142 lines
5.5 KiB
PHP
142 lines
5.5 KiB
PHP
<?php
|
|
|
|
use App\Models\InventoryItem;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Services\Baselines\BaselineSnapshotIdentity;
|
|
use App\Services\Baselines\CurrentStateHashResolver;
|
|
use App\Services\Drift\DriftHasher;
|
|
use App\Services\Drift\Normalizers\SettingsNormalizer;
|
|
use Carbon\CarbonImmutable;
|
|
|
|
it('Baseline resolver prefers content evidence over meta evidence when available', function () {
|
|
[, $tenant] = createUserWithTenant();
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'external_id' => 'policy-a',
|
|
'platform' => 'windows10',
|
|
]);
|
|
|
|
$policyVersion = PolicyVersion::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_id' => (int) $policy->getKey(),
|
|
'policy_type' => (string) $policy->policy_type,
|
|
'platform' => (string) $policy->platform,
|
|
'captured_at' => CarbonImmutable::parse('2026-03-01 10:00:00'),
|
|
'snapshot' => [
|
|
'settings' => [
|
|
['name' => 'settingA', 'value' => 1],
|
|
],
|
|
],
|
|
]);
|
|
|
|
$inventory = InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_type' => (string) $policy->policy_type,
|
|
'external_id' => (string) $policy->external_id,
|
|
'meta_jsonb' => [
|
|
'odata_type' => '#microsoft.graph.deviceManagementConfigurationPolicy',
|
|
'etag' => 'W/"meta-etag"',
|
|
'scope_tag_ids' => [],
|
|
'assignment_target_count' => 1,
|
|
],
|
|
'last_seen_at' => CarbonImmutable::parse('2026-03-01 11:00:00'),
|
|
'last_seen_operation_run_id' => null,
|
|
]);
|
|
|
|
$expectedContentHash = app(DriftHasher::class)->hashNormalized(
|
|
app(SettingsNormalizer::class)->normalizeForDiff(
|
|
is_array($policyVersion->snapshot) ? $policyVersion->snapshot : [],
|
|
(string) $policyVersion->policy_type,
|
|
is_string($policyVersion->platform) ? $policyVersion->platform : null,
|
|
),
|
|
);
|
|
|
|
$expectedMetaHash = app(BaselineSnapshotIdentity::class)->hashItemContent(
|
|
policyType: (string) $inventory->policy_type,
|
|
subjectExternalId: (string) $inventory->external_id,
|
|
metaJsonb: is_array($inventory->meta_jsonb) ? $inventory->meta_jsonb : [],
|
|
);
|
|
|
|
$resolver = app(CurrentStateHashResolver::class);
|
|
$result = $resolver->resolveForSubjects(
|
|
tenant: $tenant,
|
|
subjects: [
|
|
['policy_type' => (string) $policy->policy_type, 'subject_external_id' => (string) $policy->external_id],
|
|
],
|
|
since: null,
|
|
latestInventorySyncRunId: null,
|
|
);
|
|
|
|
expect($result)->toHaveKey((string) $policy->policy_type.'|'.(string) $policy->external_id);
|
|
|
|
$evidence = $result[(string) $policy->policy_type.'|'.(string) $policy->external_id];
|
|
expect($evidence)->not->toBeNull();
|
|
expect($evidence?->hash)->toBe($expectedContentHash);
|
|
expect($evidence?->hash)->not->toBe($expectedMetaHash);
|
|
expect($evidence?->provenance()['fidelity'])->toBe('content');
|
|
expect($evidence?->provenance()['source'])->toBe('policy_version');
|
|
});
|
|
|
|
it('Baseline resolver obeys since rule and falls back to meta evidence when content is too old', function () {
|
|
[, $tenant] = createUserWithTenant();
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'external_id' => 'policy-b',
|
|
'platform' => 'windows10',
|
|
]);
|
|
|
|
PolicyVersion::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_id' => (int) $policy->getKey(),
|
|
'policy_type' => (string) $policy->policy_type,
|
|
'platform' => (string) $policy->platform,
|
|
'captured_at' => CarbonImmutable::parse('2026-03-01 10:00:00'),
|
|
'snapshot' => [
|
|
'settings' => [
|
|
['name' => 'settingB', 'value' => 2],
|
|
],
|
|
],
|
|
]);
|
|
|
|
$inventory = InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_type' => (string) $policy->policy_type,
|
|
'external_id' => (string) $policy->external_id,
|
|
'meta_jsonb' => [
|
|
'odata_type' => '#microsoft.graph.deviceManagementConfigurationPolicy',
|
|
'etag' => 'W/"meta-etag-b"',
|
|
'scope_tag_ids' => [],
|
|
'assignment_target_count' => 1,
|
|
],
|
|
'last_seen_at' => CarbonImmutable::parse('2026-03-02 10:00:00'),
|
|
'last_seen_operation_run_id' => null,
|
|
]);
|
|
|
|
$expectedMetaHash = app(BaselineSnapshotIdentity::class)->hashItemContent(
|
|
policyType: (string) $inventory->policy_type,
|
|
subjectExternalId: (string) $inventory->external_id,
|
|
metaJsonb: is_array($inventory->meta_jsonb) ? $inventory->meta_jsonb : [],
|
|
);
|
|
|
|
$resolver = app(CurrentStateHashResolver::class);
|
|
$result = $resolver->resolveForSubjects(
|
|
tenant: $tenant,
|
|
subjects: [
|
|
['policy_type' => (string) $policy->policy_type, 'subject_external_id' => (string) $policy->external_id],
|
|
],
|
|
since: CarbonImmutable::parse('2026-03-02 00:00:00'),
|
|
latestInventorySyncRunId: null,
|
|
);
|
|
|
|
$evidence = $result[(string) $policy->policy_type.'|'.(string) $policy->external_id] ?? null;
|
|
expect($evidence)->not->toBeNull();
|
|
expect($evidence?->hash)->toBe($expectedMetaHash);
|
|
expect($evidence?->provenance()['fidelity'])->toBe('meta');
|
|
expect($evidence?->provenance()['source'])->toBe('inventory');
|
|
});
|