## Summary
Implements Spec 145 for tenant action taxonomy and lifecycle-safe visibility.
This PR:
- adds a central tenant action policy surface and supporting value objects
- aligns tenant list, detail, edit, onboarding, and widget surfaces around lifecycle-safe actions
- standardizes operator-facing lifecycle wording around View, Resume onboarding, Archive, Restore, and Complete onboarding
- tightens onboarding and tenant lifecycle authorization semantics, including honest 404 vs 403 behavior
- updates related regression coverage and spec artifacts for Spec 145
- fixes follow-on full-suite regressions uncovered during validation, including onboarding browser flows, provider consent fixtures, workspace redirect DI expectations, and critical table/action/UI expectation drift
## Validation
Executed and passed:
- vendor/bin/sail bin pint --dirty --format agent
- vendor/bin/sail artisan test --compact
Result:
- 2581 passed
- 8 skipped
- 13534 assertions
## Notes
- Base branch: dev
- Feature branch commit: a33a41b
- Filament v5 / Livewire v4 compliance preserved
- No panel provider registration changes; Laravel 12 provider registration remains in bootstrap/providers.php
- No new globally searchable resource behavior added in this slice
- Destructive lifecycle actions remain confirmation-gated and authorization-protected
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #174
127 lines
3.9 KiB
PHP
127 lines
3.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Policies;
|
|
|
|
use App\Models\Tenant;
|
|
use App\Models\TenantOnboardingSession;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Services\Auth\WorkspaceCapabilityResolver;
|
|
use App\Support\Auth\Capabilities;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Illuminate\Auth\Access\Response;
|
|
use Illuminate\Support\Facades\Gate;
|
|
|
|
class TenantOnboardingSessionPolicy
|
|
{
|
|
public function viewAny(User $user): bool|Response
|
|
{
|
|
$workspace = $this->currentWorkspace($user);
|
|
|
|
if (! $workspace instanceof Workspace) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
return $this->authorizeForWorkspace($user, $workspace, Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD);
|
|
}
|
|
|
|
public function view(User $user, TenantOnboardingSession $tenantOnboardingSession): bool|Response
|
|
{
|
|
return $this->authorizeForDraft(
|
|
user: $user,
|
|
tenantOnboardingSession: $tenantOnboardingSession,
|
|
capability: Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD,
|
|
);
|
|
}
|
|
|
|
public function update(User $user, TenantOnboardingSession $tenantOnboardingSession): bool|Response
|
|
{
|
|
return $this->authorizeForDraft(
|
|
user: $user,
|
|
tenantOnboardingSession: $tenantOnboardingSession,
|
|
capability: Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD,
|
|
);
|
|
}
|
|
|
|
public function cancel(User $user, TenantOnboardingSession $tenantOnboardingSession): bool|Response
|
|
{
|
|
return $this->authorizeForDraft(
|
|
user: $user,
|
|
tenantOnboardingSession: $tenantOnboardingSession,
|
|
capability: Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_CANCEL,
|
|
);
|
|
}
|
|
|
|
private function currentWorkspace(User $user): ?Workspace
|
|
{
|
|
$workspaceId = app(WorkspaceContext::class)->currentWorkspaceId(request());
|
|
|
|
if (! is_int($workspaceId)) {
|
|
return null;
|
|
}
|
|
|
|
$workspace = Workspace::query()->whereKey($workspaceId)->first();
|
|
|
|
if (! $workspace instanceof Workspace) {
|
|
return null;
|
|
}
|
|
|
|
/** @var WorkspaceCapabilityResolver $resolver */
|
|
$resolver = app(WorkspaceCapabilityResolver::class);
|
|
|
|
if (! $resolver->isMember($user, $workspace)) {
|
|
return null;
|
|
}
|
|
|
|
return $workspace;
|
|
}
|
|
|
|
private function authorizeForDraft(
|
|
User $user,
|
|
TenantOnboardingSession $tenantOnboardingSession,
|
|
string $capability,
|
|
): bool|Response {
|
|
$workspace = $this->currentWorkspace($user);
|
|
|
|
if (! $workspace instanceof Workspace) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
if ((int) $tenantOnboardingSession->workspace_id !== (int) $workspace->getKey()) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
$tenant = $tenantOnboardingSession->tenant;
|
|
|
|
if ($tenant instanceof Tenant && ! $user->canAccessTenant($tenant)) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
return $this->authorizeForWorkspace($user, $workspace, $capability);
|
|
}
|
|
|
|
private function authorizeForWorkspace(User $user, Workspace $workspace, string $capability): bool|Response
|
|
{
|
|
/** @var WorkspaceCapabilityResolver $resolver */
|
|
$resolver = app(WorkspaceCapabilityResolver::class);
|
|
|
|
if (! $resolver->isMember($user, $workspace)) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
return Gate::forUser($user)->allows($capability, $workspace)
|
|
? Response::allow()
|
|
: Response::deny($this->forbiddenCapabilityMessage($capability));
|
|
}
|
|
|
|
private function forbiddenCapabilityMessage(string $capability): string
|
|
{
|
|
return match ($capability) {
|
|
Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_CANCEL => 'You do not have permission to cancel this onboarding draft.',
|
|
default => 'You do not have permission to continue this onboarding draft.',
|
|
};
|
|
}
|
|
}
|