## Summary - harden governance artifact truth propagation so stale or partial evidence downgrades evidence snapshots, tenant reviews, review packs, the canonical evidence overview, and the canonical review register consistently - add the full Spec 174 artifact set under `specs/174-evidence-freshness-publication-trust/` including spec, plan, research, data model, contracts, quickstart, checklist, and completed tasks - add focused fixture helpers plus a new browser smoke test for the touched evidence, review, and review-pack trust surfaces ## Testing - `vendor/bin/sail artisan test --compact tests/Feature/Evidence/EvidenceSnapshotResourceTest.php tests/Feature/Evidence/EvidenceOverviewPageTest.php tests/Feature/TenantReview/TenantReviewLifecycleTest.php tests/Feature/TenantReview/TenantReviewRegisterTest.php tests/Feature/ReviewPack/ReviewPackResourceTest.php tests/Feature/Monitoring/ArtifactTruthRunDetailTest.php tests/Browser/Spec174EvidenceFreshnessPublicationTrustSmokeTest.php` - manual integrated-browser smoke pass across Evidence Overview, Review Register, tenant review detail, tenant evidence snapshot detail, and review-packs list ## Notes - Livewire v4 compliance is preserved and no Filament v3/v4 APIs were introduced - no panel or provider changes were made; Laravel 11+ provider registration remains in `bootstrap/providers.php` - no new global-search behavior was introduced; existing resource view pages remain the relevant detail endpoints - destructive actions were not broadened; existing confirmation and authorization behavior remains in place - no new assets were added, so the current Filament asset strategy and deploy-time `php artisan filament:assets` behavior stay unchanged - branch `174-evidence-freshness-publication-trust` is pushed at `7f2c82c26dc83bbc09fbf9e732d5644cdd143113` and targets `dev` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #205
227 lines
8.6 KiB
PHP
227 lines
8.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Feature\Concerns;
|
|
|
|
use App\Models\EvidenceSnapshot;
|
|
use App\Models\OperationRun;
|
|
use App\Models\ReviewPack;
|
|
use App\Models\Tenant;
|
|
use App\Models\TenantReview;
|
|
use App\Models\User;
|
|
use App\Support\Evidence\EvidenceCompletenessState;
|
|
use App\Support\Evidence\EvidenceSnapshotStatus;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\ReviewPackStatus;
|
|
use App\Support\TenantReviewCompletenessState;
|
|
use App\Support\TenantReviewStatus;
|
|
|
|
trait BuildsGovernanceArtifactTruthFixtures
|
|
{
|
|
protected function makeArtifactTruthEvidenceSnapshot(
|
|
Tenant $tenant,
|
|
array $snapshotOverrides = [],
|
|
array $summaryOverrides = [],
|
|
): EvidenceSnapshot {
|
|
$defaults = [
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'status' => EvidenceSnapshotStatus::Active->value,
|
|
'completeness_state' => EvidenceCompletenessState::Complete->value,
|
|
'summary' => array_replace_recursive([
|
|
'dimension_count' => 5,
|
|
'finding_count' => 2,
|
|
'report_count' => 2,
|
|
'operation_count' => 2,
|
|
'missing_dimensions' => 0,
|
|
'stale_dimensions' => 0,
|
|
], $summaryOverrides),
|
|
'fingerprint' => hash('sha256', 'evidence-'.$tenant->getKey().'-'.microtime()),
|
|
'generated_at' => now(),
|
|
];
|
|
|
|
return EvidenceSnapshot::query()->create(array_replace($defaults, $snapshotOverrides));
|
|
}
|
|
|
|
protected function makeStaleArtifactTruthEvidenceSnapshot(
|
|
Tenant $tenant,
|
|
array $snapshotOverrides = [],
|
|
array $summaryOverrides = [],
|
|
): EvidenceSnapshot {
|
|
$snapshot = $this->makeArtifactTruthEvidenceSnapshot($tenant, $snapshotOverrides, $summaryOverrides);
|
|
|
|
return $this->restateArtifactTruthEvidenceSnapshot(
|
|
$snapshot,
|
|
EvidenceCompletenessState::Stale,
|
|
array_replace([
|
|
'missing_dimensions' => 0,
|
|
'stale_dimensions' => 2,
|
|
], $summaryOverrides),
|
|
);
|
|
}
|
|
|
|
protected function makePartialArtifactTruthEvidenceSnapshot(
|
|
Tenant $tenant,
|
|
array $snapshotOverrides = [],
|
|
array $summaryOverrides = [],
|
|
): EvidenceSnapshot {
|
|
$snapshot = $this->makeArtifactTruthEvidenceSnapshot($tenant, $snapshotOverrides, $summaryOverrides);
|
|
|
|
return $this->restateArtifactTruthEvidenceSnapshot(
|
|
$snapshot,
|
|
EvidenceCompletenessState::Partial,
|
|
array_replace([
|
|
'missing_dimensions' => 1,
|
|
'stale_dimensions' => 0,
|
|
], $summaryOverrides),
|
|
);
|
|
}
|
|
|
|
protected function makeArtifactTruthReview(
|
|
Tenant $tenant,
|
|
User $user,
|
|
?EvidenceSnapshot $snapshot = null,
|
|
array $reviewOverrides = [],
|
|
array $summaryOverrides = [],
|
|
): TenantReview {
|
|
$snapshot ??= $this->makeArtifactTruthEvidenceSnapshot($tenant);
|
|
|
|
$defaults = [
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'evidence_snapshot_id' => (int) $snapshot->getKey(),
|
|
'initiated_by_user_id' => (int) $user->getKey(),
|
|
'status' => TenantReviewStatus::Ready->value,
|
|
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
|
'summary' => array_replace_recursive([
|
|
'publish_blockers' => [],
|
|
'section_state_counts' => [
|
|
'complete' => 6,
|
|
'partial' => 0,
|
|
'missing' => 0,
|
|
'stale' => 0,
|
|
],
|
|
'finding_count' => 2,
|
|
'report_count' => 2,
|
|
'operation_count' => 2,
|
|
'section_count' => 6,
|
|
], $summaryOverrides),
|
|
'fingerprint' => hash('sha256', 'review-'.$tenant->getKey().'-'.microtime()),
|
|
'generated_at' => now(),
|
|
];
|
|
|
|
return TenantReview::query()->create(array_replace($defaults, $reviewOverrides));
|
|
}
|
|
|
|
protected function makeArtifactTruthReviewPack(
|
|
Tenant $tenant,
|
|
User $user,
|
|
?EvidenceSnapshot $snapshot = null,
|
|
?TenantReview $review = null,
|
|
array $packOverrides = [],
|
|
array $summaryOverrides = [],
|
|
): ReviewPack {
|
|
$snapshot ??= $this->makeArtifactTruthEvidenceSnapshot($tenant);
|
|
$review ??= $this->makeArtifactTruthReview($tenant, $user, $snapshot);
|
|
|
|
$defaults = [
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_review_id' => (int) $review->getKey(),
|
|
'evidence_snapshot_id' => (int) $snapshot->getKey(),
|
|
'initiated_by_user_id' => (int) $user->getKey(),
|
|
'status' => ReviewPackStatus::Ready->value,
|
|
'summary' => array_replace_recursive([
|
|
'review_status' => $review->status,
|
|
'review_completeness_state' => $review->completeness_state,
|
|
'finding_count' => 2,
|
|
'report_count' => 2,
|
|
'operation_count' => 2,
|
|
'evidence_resolution' => [
|
|
'outcome' => 'resolved',
|
|
'snapshot_id' => (int) $snapshot->getKey(),
|
|
'snapshot_fingerprint' => (string) $snapshot->fingerprint,
|
|
'completeness_state' => (string) $snapshot->completeness_state,
|
|
],
|
|
], $summaryOverrides),
|
|
'fingerprint' => hash('sha256', 'pack-'.$tenant->getKey().'-'.microtime()),
|
|
'file_disk' => 'exports',
|
|
'file_path' => 'review-packs/'.microtime(true).'.zip',
|
|
'sha256' => hash('sha256', 'pack-file-'.$tenant->getKey().'-'.microtime()),
|
|
'file_size' => 1024,
|
|
'generated_at' => now(),
|
|
'expires_at' => now()->addDays(30),
|
|
];
|
|
|
|
return ReviewPack::query()->create(array_replace($defaults, $packOverrides));
|
|
}
|
|
|
|
protected function makeArtifactTruthRun(
|
|
Tenant $tenant,
|
|
string $type,
|
|
array $context = [],
|
|
array $attributes = [],
|
|
): OperationRun {
|
|
$defaults = [
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => $type,
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
'initiator_name' => 'Artifact Truth Test',
|
|
'context' => $context,
|
|
'summary_counts' => [],
|
|
'failure_summary' => [],
|
|
'started_at' => now()->subMinute(),
|
|
'completed_at' => now(),
|
|
];
|
|
|
|
return OperationRun::factory()->create(array_replace($defaults, $attributes));
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed> $summaryOverrides
|
|
*/
|
|
private function restateArtifactTruthEvidenceSnapshot(
|
|
EvidenceSnapshot $snapshot,
|
|
EvidenceCompletenessState $completenessState,
|
|
array $summaryOverrides = [],
|
|
): EvidenceSnapshot {
|
|
$summary = is_array($snapshot->summary) ? $snapshot->summary : [];
|
|
|
|
$summary = array_replace($summary, match ($completenessState) {
|
|
EvidenceCompletenessState::Stale => [
|
|
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
|
'missing_dimensions' => 0,
|
|
'stale_dimensions' => max(1, (int) ($summary['stale_dimensions'] ?? 1)),
|
|
],
|
|
EvidenceCompletenessState::Partial => [
|
|
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
|
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
|
'stale_dimensions' => 0,
|
|
],
|
|
EvidenceCompletenessState::Missing => [
|
|
'dimension_count' => (int) ($summary['dimension_count'] ?? 0),
|
|
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
|
'stale_dimensions' => 0,
|
|
],
|
|
EvidenceCompletenessState::Complete => [
|
|
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
|
'missing_dimensions' => 0,
|
|
'stale_dimensions' => 0,
|
|
],
|
|
});
|
|
|
|
$summary = array_replace_recursive($summary, $summaryOverrides);
|
|
|
|
$snapshot->forceFill([
|
|
'completeness_state' => $completenessState->value,
|
|
'summary' => $summary,
|
|
])->save();
|
|
|
|
return $snapshot->fresh();
|
|
}
|
|
}
|