What Implements tenant-scoped backup scheduling end-to-end: schedules CRUD, minute-based dispatch, queued execution, run history, manual “Run now/Retry”, retention (keep last N), and auditability. Key changes Filament UI: Backup Schedules resource with tenant scoping + SEC-002 role gating. Scheduler + queue: tenantpilot:schedules:dispatch command wired in scheduler (runs every minute), creates idempotent BackupScheduleRun records and dispatches jobs. Execution: RunBackupScheduleJob syncs policies, creates immutable backup sets, updates run status, writes audit logs, applies retry/backoff mapping, and triggers retention. Run history: Relation manager + “View” modal rendering run details. UX polish: row actions grouped; bulk actions grouped (run now / retry / delete). Bulk dispatch writes DB notifications (shows in notifications panel). Validation: policy type hard-validation on save; unknown policy types handled safely at runtime (skipped/partial). Tests: comprehensive Pest coverage for CRUD/scoping/validation, idempotency, job outcomes, error mapping, retention, view modal, run-now/retry notifications, bulk delete (incl. operator forbidden). Files / Areas Filament: BackupScheduleResource.php and app/Filament/Resources/BackupScheduleResource/* Scheduling/Jobs: app/Console/Commands/TenantpilotDispatchBackupSchedules.php, app/Jobs/RunBackupScheduleJob.php, app/Jobs/ApplyBackupScheduleRetentionJob.php, console.php Models/Migrations: app/Models/BackupSchedule.php, app/Models/BackupScheduleRun.php, database/migrations/backup_schedules, backup_schedule_runs Notifications: BackupScheduleRunDispatchedNotification.php Specs: specs/032-backup-scheduling-mvp/* (tasks/checklist/quickstart updates) How to test (Sail) Run tests: ./vendor/bin/sail artisan test tests/Feature/BackupScheduling Run formatter: ./vendor/bin/sail php ./vendor/bin/pint --dirty Apply migrations: ./vendor/bin/sail artisan migrate Manual dispatch: ./vendor/bin/sail artisan tenantpilot:schedules:dispatch Notes Uses DB notifications for queued UI actions to ensure they appear in the notifications panel even under queue fakes in tests. Checklist gate for 032 is PASS; tasks updated accordingly. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #34
134 lines
4.0 KiB
PHP
134 lines
4.0 KiB
PHP
<?php
|
|
|
|
namespace App\Services\BackupScheduling;
|
|
|
|
use App\Jobs\RunBackupScheduleJob;
|
|
use App\Models\BackupSchedule;
|
|
use App\Models\BackupScheduleRun;
|
|
use App\Models\Tenant;
|
|
use App\Services\Intune\AuditLogger;
|
|
use Carbon\CarbonImmutable;
|
|
use Illuminate\Database\QueryException;
|
|
use Illuminate\Support\Facades\Bus;
|
|
|
|
class BackupScheduleDispatcher
|
|
{
|
|
public function __construct(
|
|
private readonly ScheduleTimeService $scheduleTimeService,
|
|
private readonly AuditLogger $auditLogger,
|
|
) {}
|
|
|
|
/**
|
|
* Dispatch due schedules.
|
|
*
|
|
* No catch-up policy: we only dispatch if the current minute-slot is due.
|
|
*
|
|
* @return array{created_runs:int, skipped_runs:int, scanned_schedules:int}
|
|
*/
|
|
public function dispatchDue(?array $tenantIdentifiers = null): array
|
|
{
|
|
$nowUtc = CarbonImmutable::now('UTC');
|
|
|
|
$schedulesQuery = BackupSchedule::query()
|
|
->where('is_enabled', true)
|
|
->whereHas('tenant', fn ($query) => $query->where('status', 'active'))
|
|
->with('tenant');
|
|
|
|
if (is_array($tenantIdentifiers) && ! empty($tenantIdentifiers)) {
|
|
$schedulesQuery->whereIn('tenant_id', $this->resolveTenantIds($tenantIdentifiers));
|
|
}
|
|
|
|
$createdRuns = 0;
|
|
$skippedRuns = 0;
|
|
$scannedSchedules = 0;
|
|
|
|
foreach ($schedulesQuery->cursor() as $schedule) {
|
|
$scannedSchedules++;
|
|
|
|
$slot = $this->scheduleTimeService->nextRunFor($schedule, $nowUtc->subMinute());
|
|
|
|
if ($slot === null) {
|
|
$schedule->forceFill(['next_run_at' => null])->saveQuietly();
|
|
|
|
continue;
|
|
}
|
|
|
|
if ($slot->greaterThan($nowUtc)) {
|
|
if (! $schedule->next_run_at || ! $schedule->next_run_at->equalTo($slot)) {
|
|
$schedule->forceFill(['next_run_at' => $slot])->saveQuietly();
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
$run = null;
|
|
|
|
try {
|
|
$run = BackupScheduleRun::create([
|
|
'backup_schedule_id' => $schedule->id,
|
|
'tenant_id' => $schedule->tenant_id,
|
|
'scheduled_for' => $slot->toDateTimeString(),
|
|
'status' => BackupScheduleRun::STATUS_RUNNING,
|
|
'summary' => null,
|
|
]);
|
|
} catch (QueryException $exception) {
|
|
// Idempotency: unique (backup_schedule_id, scheduled_for)
|
|
$skippedRuns++;
|
|
|
|
continue;
|
|
}
|
|
|
|
$createdRuns++;
|
|
|
|
$this->auditLogger->log(
|
|
tenant: $schedule->tenant,
|
|
action: 'backup_schedule.run_dispatched',
|
|
context: [
|
|
'metadata' => [
|
|
'backup_schedule_id' => $schedule->id,
|
|
'backup_schedule_run_id' => $run->id,
|
|
'scheduled_for' => $slot->toDateTimeString(),
|
|
],
|
|
],
|
|
resourceType: 'backup_schedule_run',
|
|
resourceId: (string) $run->id,
|
|
status: 'success'
|
|
);
|
|
|
|
$schedule->forceFill([
|
|
'next_run_at' => $this->scheduleTimeService->nextRunFor($schedule, $nowUtc),
|
|
])->saveQuietly();
|
|
|
|
Bus::dispatch(new RunBackupScheduleJob($run->id));
|
|
}
|
|
|
|
return [
|
|
'created_runs' => $createdRuns,
|
|
'skipped_runs' => $skippedRuns,
|
|
'scanned_schedules' => $scannedSchedules,
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @param array<int, string> $tenantIdentifiers
|
|
* @return array<int>
|
|
*/
|
|
private function resolveTenantIds(array $tenantIdentifiers): array
|
|
{
|
|
$tenantIds = [];
|
|
|
|
foreach ($tenantIdentifiers as $identifier) {
|
|
$tenant = Tenant::query()
|
|
->where('status', 'active')
|
|
->forTenant($identifier)
|
|
->first();
|
|
|
|
if ($tenant) {
|
|
$tenantIds[] = $tenant->id;
|
|
}
|
|
}
|
|
|
|
return array_values(array_unique($tenantIds));
|
|
}
|
|
}
|