tenantpilot.php/graph_contracts.php include the new policy type, Graph contract, and /assign assignment flow (deviceHealthScriptAssignments payload key). ScriptsPolicyNormalizer now supports deviceComplianceScript (more metadata + script display), and InteractsWithODataTypes knows the new type. UI diff view highlights detection-script changes (same logic as other script policies) once tenantpilot.display.show_script_content is enabled. Added regression coverage in tests/Feature/Filament/ScriptPoliciesNormalizedDisplayTest plus new feature test DeviceComplianceScriptPolicyTypeTest. Runs: ScriptPoliciesNormalizedDisplayTest.php, ./vendor/bin/pint --dirty. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #29
199 lines
6.7 KiB
PHP
199 lines
6.7 KiB
PHP
<?php
|
|
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('renders policy version normalized settings for script policies', function (string $policyType, string $odataType) {
|
|
$originalEnv = getenv('INTUNE_TENANT_ID');
|
|
putenv('INTUNE_TENANT_ID=');
|
|
|
|
$this->actingAs(User::factory()->create());
|
|
|
|
$tenant = Tenant::factory()->create();
|
|
putenv('INTUNE_TENANT_ID='.$tenant->tenant_id);
|
|
$tenant->makeCurrent();
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'policy_type' => $policyType,
|
|
'platform' => 'all',
|
|
'display_name' => 'Script policy',
|
|
'external_id' => 'policy-1',
|
|
]);
|
|
|
|
config([
|
|
'tenantpilot.display.show_script_content' => true,
|
|
]);
|
|
|
|
$scriptContent = str_repeat('X', 20);
|
|
if ($policyType === 'deviceShellScript') {
|
|
$scriptContent = "#!/bin/zsh\n".str_repeat('X', 20);
|
|
}
|
|
|
|
$contentKey = in_array($policyType, ['deviceHealthScript', 'deviceComplianceScript'], true)
|
|
? 'detectionScriptContent'
|
|
: 'scriptContent';
|
|
|
|
$version = PolicyVersion::factory()->create([
|
|
'policy_id' => $policy->id,
|
|
'tenant_id' => $tenant->id,
|
|
'policy_type' => $policyType,
|
|
'snapshot' => [
|
|
'@odata.type' => $odataType,
|
|
'displayName' => 'Script policy',
|
|
'description' => 'desc',
|
|
$contentKey => $contentKey === 'scriptContent' ? $scriptContent : base64_encode($scriptContent),
|
|
],
|
|
]);
|
|
|
|
$this->get(\App\Filament\Resources\PolicyVersionResource::getUrl('index'))
|
|
->assertSuccessful();
|
|
|
|
$this->get(\App\Filament\Resources\PolicyVersionResource::getUrl('view', ['record' => $version]).'?tab=normalized-settings')
|
|
->assertSuccessful();
|
|
|
|
$originalEnv !== false
|
|
? putenv("INTUNE_TENANT_ID={$originalEnv}")
|
|
: putenv('INTUNE_TENANT_ID');
|
|
})->with([
|
|
['deviceManagementScript', '#microsoft.graph.deviceManagementScript'],
|
|
['deviceShellScript', '#microsoft.graph.deviceShellScript'],
|
|
['deviceHealthScript', '#microsoft.graph.deviceHealthScript'],
|
|
['deviceComplianceScript', '#microsoft.graph.deviceComplianceScript'],
|
|
]);
|
|
|
|
it('renders diff tab with highlighted script content for script policies', function () {
|
|
$originalEnv = getenv('INTUNE_TENANT_ID');
|
|
putenv('INTUNE_TENANT_ID=');
|
|
|
|
$this->actingAs(User::factory()->create());
|
|
|
|
config([
|
|
'tenantpilot.display.show_script_content' => true,
|
|
'tenantpilot.display.max_script_content_chars' => 5000,
|
|
]);
|
|
|
|
$tenant = Tenant::factory()->create();
|
|
putenv('INTUNE_TENANT_ID='.$tenant->tenant_id);
|
|
$tenant->makeCurrent();
|
|
|
|
$policy = \App\Models\Policy::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'policy_type' => 'deviceManagementScript',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
$scriptOne = "# test\n".str_repeat("Write-Host 'one'\n", 40);
|
|
$scriptTwo = "# test\n".str_repeat("Write-Host 'two'\n", 40);
|
|
|
|
$v1 = \App\Models\PolicyVersion::factory()->create([
|
|
'policy_id' => $policy->getKey(),
|
|
'tenant_id' => $tenant->getKey(),
|
|
'version_number' => 1,
|
|
'policy_type' => 'deviceManagementScript',
|
|
'platform' => 'windows',
|
|
'snapshot' => [
|
|
'@odata.type' => '#microsoft.graph.deviceManagementScript',
|
|
'displayName' => 'My script',
|
|
'scriptContent' => base64_encode($scriptOne),
|
|
],
|
|
]);
|
|
|
|
$v2 = \App\Models\PolicyVersion::factory()->create([
|
|
'policy_id' => $policy->getKey(),
|
|
'tenant_id' => $tenant->getKey(),
|
|
'version_number' => 2,
|
|
'policy_type' => 'deviceManagementScript',
|
|
'platform' => 'windows',
|
|
'snapshot' => [
|
|
'@odata.type' => '#microsoft.graph.deviceManagementScript',
|
|
'displayName' => 'My script',
|
|
'scriptContent' => base64_encode($scriptTwo),
|
|
],
|
|
]);
|
|
|
|
$url = \App\Filament\Resources\PolicyVersionResource::getUrl('view', ['record' => $v2]);
|
|
|
|
$this->get($url.'?tab=diff')
|
|
->assertSuccessful()
|
|
->assertSeeText('Fullscreen')
|
|
->assertSeeText("- Write-Host 'one'")
|
|
->assertSeeText("+ Write-Host 'two'")
|
|
->assertSee('bg-danger-50', false)
|
|
->assertSee('bg-success-50', false);
|
|
|
|
$originalEnv !== false
|
|
? putenv("INTUNE_TENANT_ID={$originalEnv}")
|
|
: putenv('INTUNE_TENANT_ID');
|
|
});
|
|
|
|
it('renders diff tab with highlighted script content for device compliance scripts', function () {
|
|
$originalEnv = getenv('INTUNE_TENANT_ID');
|
|
putenv('INTUNE_TENANT_ID=');
|
|
|
|
$this->actingAs(User::factory()->create());
|
|
|
|
config([
|
|
'tenantpilot.display.show_script_content' => true,
|
|
'tenantpilot.display.max_script_content_chars' => 5000,
|
|
]);
|
|
|
|
$tenant = Tenant::factory()->create();
|
|
putenv('INTUNE_TENANT_ID='.$tenant->tenant_id);
|
|
$tenant->makeCurrent();
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'policy_type' => 'deviceComplianceScript',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
$scriptOne = "# test\n".str_repeat("Write-Host 'one'\n", 40);
|
|
$scriptTwo = "# test\n".str_repeat("Write-Host 'two'\n", 40);
|
|
|
|
$v1 = PolicyVersion::factory()->create([
|
|
'policy_id' => $policy->getKey(),
|
|
'tenant_id' => $tenant->getKey(),
|
|
'version_number' => 1,
|
|
'policy_type' => 'deviceComplianceScript',
|
|
'platform' => 'windows',
|
|
'snapshot' => [
|
|
'@odata.type' => '#microsoft.graph.deviceComplianceScript',
|
|
'displayName' => 'My compliance script',
|
|
'detectionScriptContent' => base64_encode($scriptOne),
|
|
],
|
|
]);
|
|
|
|
$v2 = PolicyVersion::factory()->create([
|
|
'policy_id' => $policy->getKey(),
|
|
'tenant_id' => $tenant->getKey(),
|
|
'version_number' => 2,
|
|
'policy_type' => 'deviceComplianceScript',
|
|
'platform' => 'windows',
|
|
'snapshot' => [
|
|
'@odata.type' => '#microsoft.graph.deviceComplianceScript',
|
|
'displayName' => 'My compliance script',
|
|
'detectionScriptContent' => base64_encode($scriptTwo),
|
|
],
|
|
]);
|
|
|
|
$url = \App\Filament\Resources\PolicyVersionResource::getUrl('view', ['record' => $v2]);
|
|
|
|
$this->get($url.'?tab=diff')
|
|
->assertSuccessful()
|
|
->assertSeeText('Fullscreen')
|
|
->assertSeeText("- Write-Host 'one'")
|
|
->assertSeeText("+ Write-Host 'two'")
|
|
->assertSee('bg-danger-50', false)
|
|
->assertSee('bg-success-50', false);
|
|
|
|
$originalEnv !== false
|
|
? putenv("INTUNE_TENANT_ID={$originalEnv}")
|
|
: putenv('INTUNE_TENANT_ID');
|
|
});
|