ahmido
f13a4ce409
Implements Spec 110 Ops‑UX Enforcement and applies the repo‑wide “enterprise” standard for operation start + dedup surfaces. Key points - Start surfaces: only ephemeral queued toast (no DB notifications for started/queued/running). - Dedup paths: canonical “already queued” toast. - Progress refresh: dispatch run-enqueued browser event so the global widget updates immediately. - Completion: exactly-once terminal DB notification on completion (per Ops‑UX contract). Tests & formatting - Full suite: 1738 passed, 8 skipped (8477 assertions). - Pint: `vendor/bin/sail bin pint --dirty --format agent` (pass). Notable change - Removed legacy `RunStatusChangedNotification` (replaced by the terminal-only completion notification policy). Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #134
67 lines
2.5 KiB
PHP
67 lines
2.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Tests\Support\OpsUx\SourceFileScanner;
|
|
|
|
it('does not allow direct OperationRun status or outcome transitions outside OperationRunService', function (): void {
|
|
$root = SourceFileScanner::projectRoot();
|
|
$excluded = [$root.'/app/Services/OperationRunService.php'];
|
|
|
|
$files = SourceFileScanner::phpFiles([$root.'/app'], $excluded);
|
|
|
|
$patterns = [
|
|
'direct update() with status/outcome' => '/(?:\$this->operationRun|\$operationRun|\$opRun)\s*->\s*update\s*\(\s*\[(?:(?!\)\s*;).)*?(?:[\'"]status[\'"]|[\'"]outcome[\'"])\s*=>/s',
|
|
'direct fill()/forceFill() with status/outcome' => '/(?:\$this->operationRun|\$operationRun|\$opRun)\s*->\s*(?:fill|forceFill)\s*\(\s*\[(?:(?!\)\s*;).)*?(?:[\'"]status[\'"]|[\'"]outcome[\'"])\s*=>/s',
|
|
'direct property assignment' => '/(?:\$this->operationRun|\$operationRun|\$opRun)\s*->\s*(?:status|outcome)\s*=(?!=)/',
|
|
'OperationRun query/bulk update with status/outcome' => '/OperationRun::(?:(?!;).){0,800}?->\s*update\s*\(\s*\[(?:(?!\)\s*;).)*?(?:[\'"]status[\'"]|[\'"]outcome[\'"])\s*=>/s',
|
|
];
|
|
|
|
$violations = [];
|
|
|
|
foreach ($files as $file) {
|
|
$source = SourceFileScanner::read($file);
|
|
|
|
foreach ($patterns as $label => $pattern) {
|
|
if (! preg_match_all($pattern, $source, $matches, PREG_OFFSET_CAPTURE)) {
|
|
continue;
|
|
}
|
|
|
|
foreach ($matches[0] as [$snippetMatch, $offset]) {
|
|
if (! is_int($offset)) {
|
|
continue;
|
|
}
|
|
|
|
$line = substr_count(substr($source, 0, $offset), "\n") + 1;
|
|
|
|
$violations[] = [
|
|
'file' => SourceFileScanner::relativePath($file),
|
|
'line' => $line,
|
|
'label' => $label,
|
|
'snippet' => SourceFileScanner::snippet($source, $line),
|
|
'match' => trim((string) $snippetMatch),
|
|
];
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($violations !== []) {
|
|
$messages = array_map(static function (array $violation): string {
|
|
return sprintf(
|
|
"%s:%d [%s]\n%s",
|
|
$violation['file'],
|
|
$violation['line'],
|
|
$violation['label'],
|
|
$violation['snippet'],
|
|
);
|
|
}, $violations);
|
|
|
|
$this->fail(
|
|
"Forbidden direct OperationRun status/outcome transition(s) found outside OperationRunService:\n\n"
|
|
.implode("\n\n", $messages)
|
|
);
|
|
}
|
|
|
|
expect($violations)->toBe([]);
|
|
})->group('ops-ux');
|