Summary Adds a tenant-scoped Entra Groups “Directory Cache” to enable DB-only group name resolution across the app (no render-time Graph calls), plus sync runs + observability. What’s included • Entra Groups cache • New entra_groups storage (tenant-scoped) for group metadata (no memberships). • Retention semantics: groups become stale / retained per spec (no hard delete on first miss). • Group Sync Runs • New “Group Sync Runs” UI (list + detail) with tenant isolation (403 on cross-tenant access). • Manual “Sync Groups” action: creates/reuses a run, dispatches job, DB notification with “View run” link. • Scheduled dispatcher command wired in console.php. • DB-only label resolution (US3) • Shared EntraGroupLabelResolver with safe fallback Unresolved (…last8) and UUID guarding. • Refactors to prefer cached names (no typeahead / no live Graph) in: • Tenant RBAC group selects • Policy version assignments widget • Restore results + restore wizard group mapping labels Safety / Guardrails • No render-time Graph calls: fail-hard guard test verifies UI paths don’t call GraphClientInterface during page render. • Tenant isolation & authorization: policies + scoped queries enforced (cross-tenant access returns 403, not 404). • Data minimization: only group metadata is cached (no membership/owners). Tests / Verification • Added/updated tests under tests/Feature/DirectoryGroups and tests/Unit/DirectoryGroups: • Start sync → run record + job dispatch + upserts • Retention purge semantics • Scheduled dispatch wiring • Render-time Graph guard • UI/resource access isolation • Ran: • ./vendor/bin/pint --dirty • ./vendor/bin/sail artisan test tests/Feature/DirectoryGroups • ./vendor/bin/sail artisan test tests/Unit/DirectoryGroups Notes / Follow-ups • UI polish remains (picker/lookup UX, consistent progress widget/toasts across modules, navigation grouping). • pr-gate checklist still has non-blocking open items (mostly UX/ops polish); requirements gate is green. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #57
117 lines
3.8 KiB
PHP
117 lines
3.8 KiB
PHP
<?php
|
|
|
|
namespace App\Notifications;
|
|
|
|
use App\Filament\Resources\BulkOperationRunResource;
|
|
use App\Filament\Resources\EntraGroupSyncRunResource;
|
|
use App\Filament\Resources\RestoreRunResource;
|
|
use App\Models\Tenant;
|
|
use Filament\Actions\Action;
|
|
use Illuminate\Notifications\Notification;
|
|
|
|
class RunStatusChangedNotification extends Notification
|
|
{
|
|
/**
|
|
* @param array{
|
|
* tenant_id:int,
|
|
* run_type:string,
|
|
* run_id:int,
|
|
* status:string,
|
|
* counts?:array{total?:int, processed?:int, succeeded?:int, failed?:int, skipped?:int}
|
|
* } $metadata
|
|
*/
|
|
public function __construct(public array $metadata) {}
|
|
|
|
/**
|
|
* @return array<int, string>
|
|
*/
|
|
public function via(object $notifiable): array
|
|
{
|
|
return ['database'];
|
|
}
|
|
|
|
/**
|
|
* @return array<string, mixed>
|
|
*/
|
|
public function toDatabase(object $notifiable): array
|
|
{
|
|
$status = (string) ($this->metadata['status'] ?? 'queued');
|
|
$runType = (string) ($this->metadata['run_type'] ?? 'run');
|
|
$tenantId = (int) ($this->metadata['tenant_id'] ?? 0);
|
|
$runId = (int) ($this->metadata['run_id'] ?? 0);
|
|
|
|
$title = match ($status) {
|
|
'queued' => 'Run queued',
|
|
'running' => 'Run started',
|
|
'completed', 'succeeded' => 'Run completed',
|
|
'partial', 'completed_with_errors' => 'Run completed (partial)',
|
|
'failed' => 'Run failed',
|
|
default => 'Run updated',
|
|
};
|
|
|
|
$body = sprintf('A %s run changed status to: %s.', str_replace('_', ' ', $runType), $status);
|
|
|
|
$color = match ($status) {
|
|
'queued', 'running' => 'gray',
|
|
'completed', 'succeeded' => 'success',
|
|
'partial', 'completed_with_errors' => 'warning',
|
|
'failed' => 'danger',
|
|
default => 'gray',
|
|
};
|
|
|
|
$actions = [];
|
|
|
|
if (in_array($runType, ['bulk_operation', 'restore', 'directory_groups'], true) && $tenantId > 0 && $runId > 0) {
|
|
$tenant = Tenant::query()->find($tenantId);
|
|
|
|
if ($tenant) {
|
|
$url = match ($runType) {
|
|
'bulk_operation' => BulkOperationRunResource::getUrl('view', ['record' => $runId], tenant: $tenant),
|
|
'restore' => RestoreRunResource::getUrl('view', ['record' => $runId], tenant: $tenant),
|
|
'directory_groups' => EntraGroupSyncRunResource::getUrl('view', ['record' => $runId], tenant: $tenant),
|
|
default => null,
|
|
};
|
|
|
|
if (! $url) {
|
|
return [
|
|
'format' => 'filament',
|
|
'title' => $title,
|
|
'body' => $body,
|
|
'color' => $color,
|
|
'duration' => 'persistent',
|
|
'actions' => [],
|
|
'icon' => null,
|
|
'iconColor' => null,
|
|
'status' => null,
|
|
'view' => null,
|
|
'viewData' => [
|
|
'metadata' => $this->metadata,
|
|
],
|
|
];
|
|
}
|
|
|
|
$actions[] = Action::make('view_run')
|
|
->label('View run')
|
|
->url($url)
|
|
->toArray();
|
|
}
|
|
}
|
|
|
|
return [
|
|
'format' => 'filament',
|
|
'title' => $title,
|
|
'body' => $body,
|
|
'color' => $color,
|
|
'duration' => 'persistent',
|
|
'actions' => $actions,
|
|
'icon' => null,
|
|
'iconColor' => null,
|
|
'status' => null,
|
|
'view' => null,
|
|
'viewData' => [
|
|
'metadata' => $this->metadata,
|
|
],
|
|
];
|
|
}
|
|
}
|