Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
158 lines
5.2 KiB
PHP
158 lines
5.2 KiB
PHP
<?php
|
|
|
|
use App\Jobs\GenerateDriftFindingsJob;
|
|
use App\Models\OperationRun;
|
|
use App\Notifications\OperationRunCompleted;
|
|
use App\Services\Drift\DriftFindingGenerator;
|
|
use App\Services\OperationRunService;
|
|
use App\Services\Operations\TargetScopeConcurrencyLimiter;
|
|
use App\Support\OperationRunLinks;
|
|
use Mockery\MockInterface;
|
|
|
|
test('drift generation job sends completion notification with view link', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
config()->set('tenantpilot.bulk_operations.concurrency.per_target_scope_max', 1);
|
|
|
|
$scopeKey = hash('sha256', 'scope-job-notification-success');
|
|
|
|
$baseline = createInventorySyncOperationRun($tenant, [
|
|
'selection_hash' => $scopeKey,
|
|
'status' => 'success',
|
|
'finished_at' => now()->subDays(2),
|
|
]);
|
|
|
|
$current = createInventorySyncOperationRun($tenant, [
|
|
'selection_hash' => $scopeKey,
|
|
'status' => 'success',
|
|
'finished_at' => now()->subDay(),
|
|
]);
|
|
|
|
$opRun = OperationRun::create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'drift_generate_findings',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'run_identity_hash' => 'drift-hash-1',
|
|
'context' => [
|
|
'target_scope' => [
|
|
'entra_tenant_id' => 'entra-1',
|
|
],
|
|
'scope_key' => $scopeKey,
|
|
'baseline_operation_run_id' => (int) $baseline->getKey(),
|
|
'current_operation_run_id' => (int) $current->getKey(),
|
|
],
|
|
]);
|
|
|
|
$this->mock(DriftFindingGenerator::class, function (MockInterface $mock) {
|
|
$mock->shouldReceive('generate')->once()->andReturn(0);
|
|
});
|
|
|
|
$job = new GenerateDriftFindingsJob(
|
|
tenantId: (int) $tenant->getKey(),
|
|
userId: (int) $user->getKey(),
|
|
baselineRunId: (int) $baseline->getKey(),
|
|
currentRunId: (int) $current->getKey(),
|
|
scopeKey: $scopeKey,
|
|
operationRun: $opRun,
|
|
);
|
|
|
|
$job->handle(
|
|
app(DriftFindingGenerator::class),
|
|
app(OperationRunService::class),
|
|
app(TargetScopeConcurrencyLimiter::class),
|
|
);
|
|
|
|
$opRun->refresh();
|
|
expect($opRun->status)->toBe('completed');
|
|
|
|
$this->assertDatabaseHas('notifications', [
|
|
'notifiable_id' => $user->getKey(),
|
|
'notifiable_type' => $user->getMorphClass(),
|
|
'type' => OperationRunCompleted::class,
|
|
]);
|
|
|
|
$notification = $user->notifications()->latest('id')->first();
|
|
expect($notification)->not->toBeNull();
|
|
expect($notification->data['actions'][0]['url'] ?? null)
|
|
->toBe(OperationRunLinks::view($opRun, $tenant));
|
|
});
|
|
|
|
test('drift generation job sends failure notification with view link', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
config()->set('tenantpilot.bulk_operations.concurrency.per_target_scope_max', 1);
|
|
|
|
$scopeKey = hash('sha256', 'scope-job-notification-failure');
|
|
|
|
$baseline = createInventorySyncOperationRun($tenant, [
|
|
'selection_hash' => $scopeKey,
|
|
'status' => 'success',
|
|
'finished_at' => now()->subDays(2),
|
|
]);
|
|
|
|
$current = createInventorySyncOperationRun($tenant, [
|
|
'selection_hash' => $scopeKey,
|
|
'status' => 'success',
|
|
'finished_at' => now()->subDay(),
|
|
]);
|
|
|
|
$opRun = OperationRun::create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'drift_generate_findings',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'run_identity_hash' => 'drift-hash-2',
|
|
'context' => [
|
|
'target_scope' => [
|
|
'entra_tenant_id' => 'entra-1',
|
|
],
|
|
'scope_key' => $scopeKey,
|
|
'baseline_operation_run_id' => (int) $baseline->getKey(),
|
|
'current_operation_run_id' => (int) $current->getKey(),
|
|
],
|
|
]);
|
|
|
|
$this->mock(DriftFindingGenerator::class, function (MockInterface $mock) {
|
|
$mock->shouldReceive('generate')->once()->andThrow(new \RuntimeException('boom'));
|
|
});
|
|
|
|
$job = new GenerateDriftFindingsJob(
|
|
tenantId: (int) $tenant->getKey(),
|
|
userId: (int) $user->getKey(),
|
|
baselineRunId: (int) $baseline->getKey(),
|
|
currentRunId: (int) $current->getKey(),
|
|
scopeKey: $scopeKey,
|
|
operationRun: $opRun,
|
|
);
|
|
|
|
try {
|
|
$job->handle(
|
|
app(DriftFindingGenerator::class),
|
|
app(OperationRunService::class),
|
|
app(TargetScopeConcurrencyLimiter::class),
|
|
);
|
|
} catch (\RuntimeException) {
|
|
// Expected.
|
|
}
|
|
|
|
$opRun->refresh();
|
|
expect($opRun->status)->toBe('completed')
|
|
->and($opRun->outcome)->toBe('failed');
|
|
|
|
$this->assertDatabaseHas('notifications', [
|
|
'notifiable_id' => $user->getKey(),
|
|
'notifiable_type' => $user->getMorphClass(),
|
|
'type' => OperationRunCompleted::class,
|
|
]);
|
|
|
|
$notification = $user->notifications()->latest('id')->first();
|
|
expect($notification)->not->toBeNull();
|
|
expect($notification->data['actions'][0]['url'] ?? null)
|
|
->toBe(OperationRunLinks::view($opRun, $tenant));
|
|
});
|