ahmido
110245a9ec
Some checks are pending
Main Confidence / confidence (push) Waiting to run
## Summary - add a shared provider target-scope descriptor, normalizer, identity-context metadata, and surface-summary layer - update provider connection list, detail, create, edit, and onboarding surfaces to use neutral target-scope vocabulary while keeping Microsoft identity contextual - align provider connection audit and resolver output with the neutral target-scope contract and add focused guard/unit/feature coverage for regressions ## Validation - browser smoke: opened the tenant-scoped provider connection list, drilled into detail, and verified the edit/create surfaces in local admin context ## Notes - this PR comes from the session branch created for the active feature work - no additional runtime or persistence layer was introduced in this slice Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #274
63 lines
2.7 KiB
PHP
63 lines
2.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\ProviderCredential;
|
|
use App\Models\Tenant;
|
|
use App\Services\Providers\ProviderIdentityResolver;
|
|
use App\Support\Providers\ProviderConnectionType;
|
|
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeDescriptor;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('exposes neutral target-scope truth beside provider-owned identity metadata', function (): void {
|
|
config()->set('graph.client_id', 'platform-client-id');
|
|
config()->set('graph.client_secret', 'platform-client-secret');
|
|
config()->set('graph.tenant_id', 'platform-home-tenant-id');
|
|
|
|
$tenant = Tenant::factory()->create([
|
|
'tenant_id' => '22222222-2222-2222-2222-222222222222',
|
|
]);
|
|
|
|
$connection = ProviderConnection::factory()->platform()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
'entra_tenant_id' => '22222222-2222-2222-2222-222222222222',
|
|
]);
|
|
|
|
$resolution = app(ProviderIdentityResolver::class)->resolve($connection->fresh(['tenant']));
|
|
|
|
expect($resolution->resolved)->toBeTrue()
|
|
->and($resolution->connectionType)->toBe(ProviderConnectionType::Platform)
|
|
->and($resolution->tenantContext)->toBe('22222222-2222-2222-2222-222222222222')
|
|
->and($resolution->targetScope)->not->toBeNull()
|
|
->and($resolution->targetScope?->scopeKind)->toBe(ProviderConnectionTargetScopeDescriptor::SCOPE_KIND_TENANT)
|
|
->and($resolution->targetScope?->scopeIdentifier)->toBe('22222222-2222-2222-2222-222222222222')
|
|
->and(collect($resolution->contextualIdentityDetails)->pluck('detailKey')->all())
|
|
->toContain('microsoft_tenant_id', 'authority_tenant', 'redirect_uri');
|
|
});
|
|
|
|
it('keeps dedicated runtime credentials out of the shared target-scope descriptor', function (): void {
|
|
$connection = ProviderConnection::factory()->dedicated()->create([
|
|
'entra_tenant_id' => '33333333-3333-3333-3333-333333333333',
|
|
]);
|
|
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
'payload' => [
|
|
'client_id' => 'dedicated-client-id',
|
|
'client_secret' => 'dedicated-client-secret',
|
|
],
|
|
]);
|
|
|
|
$resolution = app(ProviderIdentityResolver::class)->resolve($connection->fresh(['tenant', 'credential']));
|
|
|
|
expect($resolution->resolved)->toBeTrue()
|
|
->and($resolution->targetScope?->toArray())->not->toHaveKey('client_id')
|
|
->and($resolution->targetScope?->toArray())->not->toHaveKey('client_secret')
|
|
->and($resolution->effectiveClientId)->toBe('dedicated-client-id');
|
|
});
|