Some checks failed
Main Confidence / confidence (push) Failing after 57s
## Summary - add the provider boundary catalog, boundary support types, and guardrails for platform-core versus provider-owned seams - harden provider gateway, identity resolution, operation registry, and start-gate behavior to require explicit provider bindings - add unit and feature coverage for boundary classification, runtime preservation, unsupported paths, and platform-core leakage guards - add the full Spec Kit artifact set for spec 237 and update roadmap/spec-candidate tracking ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Providers/ProviderBoundaryClassificationTest.php tests/Unit/Providers/ProviderBoundaryGuardrailTest.php tests/Feature/Providers/ProviderBoundaryHardeningTest.php tests/Feature/Providers/UnsupportedProviderBoundaryPathTest.php tests/Feature/Guards/ProviderBoundaryPlatformCoreGuardTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Providers/ProviderGatewayTest.php tests/Unit/Providers/ProviderIdentityResolverTest.php tests/Unit/Providers/ProviderOperationStartGateTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - browser smoke: `http://localhost/admin/provider-connections?tenant_id=18000000-0000-4000-8000-000000000180` loaded with the local smoke user, the empty-state CTA reached the canonical create route, and cancel returned to the scoped list Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #273
319 lines
11 KiB
PHP
319 lines
11 KiB
PHP
<?php
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\ProviderCredential;
|
|
use App\Models\Tenant;
|
|
use App\Services\Providers\ProviderOperationStartGate;
|
|
use App\Support\Auth\Capabilities;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\Providers\ProviderReasonCodes;
|
|
use App\Support\Verification\VerificationReportSchema;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('starts a provider operation and dispatches the job once', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
'entra_tenant_id' => 'entra-tenant-id',
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$dispatched = 0;
|
|
|
|
$gate = app(ProviderOperationStartGate::class);
|
|
|
|
$result = $gate->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'provider.connection.check',
|
|
dispatcher: function (OperationRun $run) use (&$dispatched): void {
|
|
$dispatched++;
|
|
expect($run->type)->toBe('provider.connection.check');
|
|
},
|
|
);
|
|
|
|
expect($dispatched)->toBe(1);
|
|
expect($result->status)->toBe('started');
|
|
expect($result->dispatched)->toBeTrue();
|
|
|
|
$run = $result->run->fresh();
|
|
expect($run)->not->toBeNull();
|
|
expect($run->type)->toBe('provider.connection.check');
|
|
expect($run->status)->toBe('queued');
|
|
|
|
expect($run->context)->toMatchArray([
|
|
'provider' => 'microsoft',
|
|
'module' => 'health_check',
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
'target_scope' => [
|
|
'entra_tenant_id' => 'entra-tenant-id',
|
|
],
|
|
]);
|
|
expect($run->context['provider_binding']['provider'] ?? null)->toBe('microsoft')
|
|
->and($run->context['provider_binding']['binding_status'] ?? null)->toBe('active');
|
|
});
|
|
|
|
it('dedupes when the same operation is already active for the scope', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$existing = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'type' => 'provider.connection.check',
|
|
'status' => 'running',
|
|
'context' => [
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
],
|
|
]);
|
|
|
|
$dispatched = 0;
|
|
$gate = app(ProviderOperationStartGate::class);
|
|
|
|
$result = $gate->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'provider.connection.check',
|
|
dispatcher: function () use (&$dispatched): void {
|
|
$dispatched++;
|
|
},
|
|
);
|
|
|
|
expect($dispatched)->toBe(0);
|
|
expect($result->status)->toBe('deduped');
|
|
expect($result->run->getKey())->toBe($existing->getKey());
|
|
expect(OperationRun::query()->where('tenant_id', $tenant->getKey())->count())->toBe(1);
|
|
});
|
|
|
|
it('blocks when a different operation is already active for the scope', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$blocking = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'type' => 'inventory_sync',
|
|
'status' => 'queued',
|
|
'context' => [
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
],
|
|
]);
|
|
|
|
$dispatched = 0;
|
|
$gate = app(ProviderOperationStartGate::class);
|
|
|
|
$result = $gate->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'provider.connection.check',
|
|
dispatcher: function () use (&$dispatched): void {
|
|
$dispatched++;
|
|
},
|
|
);
|
|
|
|
expect($dispatched)->toBe(0);
|
|
expect($result->status)->toBe('scope_busy');
|
|
expect($result->run->getKey())->toBe($blocking->getKey());
|
|
expect(OperationRun::query()->where('tenant_id', $tenant->getKey())->count())->toBe(1);
|
|
});
|
|
|
|
it('returns blocked and stores reason metadata when no default connection exists', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$dispatched = 0;
|
|
$gate = app(ProviderOperationStartGate::class);
|
|
|
|
$result = $gate->start(
|
|
tenant: $tenant,
|
|
connection: null,
|
|
operationType: 'provider.connection.check',
|
|
dispatcher: function () use (&$dispatched): void {
|
|
$dispatched++;
|
|
},
|
|
);
|
|
|
|
expect($dispatched)->toBe(0);
|
|
expect($result->status)->toBe('blocked');
|
|
expect($result->dispatched)->toBeFalse();
|
|
expect($result->run->status)->toBe(OperationRunStatus::Completed->value);
|
|
expect($result->run->outcome)->toBe(OperationRunOutcome::Blocked->value);
|
|
expect($result->run->context['reason_code'] ?? null)->toBe(ProviderReasonCodes::ProviderConnectionMissing);
|
|
expect($result->run->context['next_steps'] ?? [])->not->toBeEmpty();
|
|
expect($result->run->context['verification_report'] ?? null)->toBeArray();
|
|
expect(VerificationReportSchema::isValidReport($result->run->context['verification_report'] ?? []))->toBeTrue();
|
|
});
|
|
|
|
it('starts restore execution with explicit provider connection binding and operation capability metadata', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
'entra_tenant_id' => 'restore-entra-tenant-id',
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$dispatched = 0;
|
|
$gate = app(ProviderOperationStartGate::class);
|
|
|
|
$result = $gate->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'restore.execute',
|
|
dispatcher: function (OperationRun $run) use (&$dispatched): void {
|
|
$dispatched++;
|
|
|
|
expect($run->type)->toBe('restore.execute');
|
|
},
|
|
);
|
|
|
|
expect($dispatched)->toBe(1);
|
|
expect($result->status)->toBe('started');
|
|
expect($result->dispatched)->toBeTrue();
|
|
|
|
$run = $result->run->fresh();
|
|
|
|
expect($run)->not->toBeNull();
|
|
expect($run->context)->toMatchArray([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
'required_capability' => Capabilities::TENANT_MANAGE,
|
|
'target_scope' => [
|
|
'entra_tenant_id' => 'restore-entra-tenant-id',
|
|
],
|
|
]);
|
|
});
|
|
|
|
it('starts directory group sync with explicit provider connection binding and sync capability metadata', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
'entra_tenant_id' => 'directory-entra-tenant-id',
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$dispatched = 0;
|
|
$gate = app(ProviderOperationStartGate::class);
|
|
|
|
$result = $gate->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'entra_group_sync',
|
|
dispatcher: function (OperationRun $run) use (&$dispatched): void {
|
|
$dispatched++;
|
|
|
|
expect($run->type)->toBe('entra_group_sync');
|
|
},
|
|
);
|
|
|
|
expect($dispatched)->toBe(1);
|
|
expect($result->status)->toBe('started');
|
|
expect($result->dispatched)->toBeTrue();
|
|
|
|
$run = $result->run->fresh();
|
|
|
|
expect($run)->not->toBeNull();
|
|
expect($run->context)->toMatchArray([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
'required_capability' => Capabilities::TENANT_SYNC,
|
|
'target_scope' => [
|
|
'entra_tenant_id' => 'directory-entra-tenant-id',
|
|
],
|
|
]);
|
|
});
|
|
|
|
it('treats onboarding bootstrap provider starts as one protected scope', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$blocking = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'type' => 'inventory_sync',
|
|
'status' => 'running',
|
|
'context' => [
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
],
|
|
]);
|
|
|
|
$dispatched = 0;
|
|
$gate = app(ProviderOperationStartGate::class);
|
|
|
|
$result = $gate->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'compliance.snapshot',
|
|
dispatcher: function () use (&$dispatched): void {
|
|
$dispatched++;
|
|
},
|
|
);
|
|
|
|
expect($dispatched)->toBe(0);
|
|
expect($result->status)->toBe('scope_busy');
|
|
expect($result->run->getKey())->toBe($blocking->getKey());
|
|
});
|
|
|
|
it('blocks provider starts when no explicit provider binding supports the connection provider', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'provider' => 'contoso',
|
|
'entra_tenant_id' => 'contoso-tenant-id',
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$dispatched = 0;
|
|
$gate = app(ProviderOperationStartGate::class);
|
|
|
|
$result = $gate->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'provider.connection.check',
|
|
dispatcher: function () use (&$dispatched): void {
|
|
$dispatched++;
|
|
},
|
|
);
|
|
|
|
expect($dispatched)->toBe(0);
|
|
expect($result->status)->toBe('blocked');
|
|
expect($result->run->context)->toMatchArray([
|
|
'provider' => 'contoso',
|
|
'module' => 'health_check',
|
|
'reason_code' => ProviderReasonCodes::ProviderBindingUnsupported,
|
|
'reason_code_extension' => 'ext.provider_binding_missing',
|
|
]);
|
|
expect($result->run->context['provider_binding']['provider'] ?? null)->toBe('contoso')
|
|
->and($result->run->context['provider_binding']['binding_status'] ?? null)->toBe('unsupported');
|
|
});
|