ahmido
6fdd45fb02
Some checks failed
Main Confidence / confidence (push) Failing after 53s
## Summary - keep stale active operation runs visible in the tenant progress overlay and polling state - align tenant and canonical operation surfaces around the shared stale-active presentation contract - add Spec 233 artifacts and clean the promoted-candidate backlog entries ## Validation - browser smoke: `/admin/t/18000000-0000-4000-8000-000000000180` -> stale dashboard CTA -> `/admin/operations?tenant_id=7&activeTab=active_stale_attention&problemClass=active_stale_attention` -> `/admin/operations/15` - verified healthy vs likely-stale tenant cards, canonical stale list row, and canonical run detail consistency ## Notes - local smoke fixture seeded with one fresh and one stale running `baseline_compare` operation for browser validation - Pest suite was not re-run in this session before opening this PR Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #269
111 lines
3.6 KiB
PHP
111 lines
3.6 KiB
PHP
<?php
|
|
|
|
use App\Livewire\BulkOperationProgress;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use Filament\Facades\Filament;
|
|
use Livewire\Livewire;
|
|
|
|
it('keeps the Ops UX progress widget DB-only (no outbound HTTP) and tenant-scoped', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create();
|
|
|
|
[$user] = createUserWithTenant($tenantA, role: 'owner');
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantB->getKey() => ['role' => 'owner'],
|
|
]);
|
|
|
|
OperationRun::factory()->create([
|
|
'tenant_id' => $tenantA->getKey(),
|
|
'type' => 'policy.sync',
|
|
'status' => 'running',
|
|
'outcome' => 'pending',
|
|
'initiator_name' => 'TenantA',
|
|
]);
|
|
|
|
OperationRun::factory()->create([
|
|
'tenant_id' => $tenantB->getKey(),
|
|
'type' => 'inventory_sync',
|
|
'status' => 'running',
|
|
'outcome' => 'pending',
|
|
'initiator_name' => 'TenantB',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenantA, true);
|
|
|
|
assertNoOutboundHttp(function () {
|
|
Livewire::test(BulkOperationProgress::class)
|
|
->call('refreshRuns')
|
|
->assertSet('disabled', false)
|
|
->assertSee('Policy sync')
|
|
->assertDontSee('Inventory sync');
|
|
});
|
|
})->group('ops-ux');
|
|
|
|
it('removes terminal runs from the progress overlay on the next refresh cycle without a new enqueue event', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'inventory_sync',
|
|
'status' => 'running',
|
|
'outcome' => 'pending',
|
|
]);
|
|
|
|
$component = Livewire::actingAs($user)
|
|
->test(BulkOperationProgress::class)
|
|
->call('refreshRuns')
|
|
->assertSet('hasActiveRuns', true)
|
|
->assertSee('Inventory sync');
|
|
|
|
$run->forceFill([
|
|
'status' => 'completed',
|
|
'outcome' => 'failed',
|
|
'completed_at' => now(),
|
|
])->save();
|
|
|
|
$component
|
|
->call('refreshRuns')
|
|
->assertSet('hasActiveRuns', false)
|
|
->assertDontSee('Inventory sync');
|
|
})->group('ops-ux');
|
|
|
|
it('shows likely stale runs in the progress overlay and keeps polling when only stale runs remain', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'inventory_sync',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'created_at' => now()->subWeeks(2),
|
|
'started_at' => null,
|
|
]);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(BulkOperationProgress::class)
|
|
->call('refreshRuns')
|
|
->assertSet('hasActiveRuns', true)
|
|
->assertSee('Inventory sync')
|
|
->assertSee('Likely stale')
|
|
->assertSee('This operation is past its lifecycle window.');
|
|
})->group('ops-ux');
|
|
|
|
it('registers Alpine cleanup for the Ops UX poller to avoid stale listeners across re-renders', function () {
|
|
$contents = file_get_contents(resource_path('views/livewire/bulk-operation-progress.blade.php'));
|
|
|
|
expect($contents)->toContain('new MutationObserver');
|
|
expect($contents)->toContain('teardownObserver');
|
|
expect($contents)->toContain('wire:poll.10s="refreshRuns"');
|
|
expect($contents)->not->toContain('wire:poll.5s="refreshRuns"');
|
|
})->group('ops-ux');
|