ahmido
440e63edff
## Summary
Implements Spec 145 for tenant action taxonomy and lifecycle-safe visibility.
This PR:
- adds a central tenant action policy surface and supporting value objects
- aligns tenant list, detail, edit, onboarding, and widget surfaces around lifecycle-safe actions
- standardizes operator-facing lifecycle wording around View, Resume onboarding, Archive, Restore, and Complete onboarding
- tightens onboarding and tenant lifecycle authorization semantics, including honest 404 vs 403 behavior
- updates related regression coverage and spec artifacts for Spec 145
- fixes follow-on full-suite regressions uncovered during validation, including onboarding browser flows, provider consent fixtures, workspace redirect DI expectations, and critical table/action/UI expectation drift
## Validation
Executed and passed:
- vendor/bin/sail bin pint --dirty --format agent
- vendor/bin/sail artisan test --compact
Result:
- 2581 passed
- 8 skipped
- 13534 assertions
## Notes
- Base branch: dev
- Feature branch commit: a33a41b
- Filament v5 / Livewire v4 compliance preserved
- No panel provider registration changes; Laravel 12 provider registration remains in bootstrap/providers.php
- No new globally searchable resource behavior added in this slice
- Destructive lifecycle actions remain confirmation-gated and authorization-protected
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #174
82 lines
2.8 KiB
PHP
82 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Policies\TenantOnboardingSessionPolicy;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Illuminate\Auth\Access\Response;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('returns not found for actors outside the active workspace when viewing a draft', function (): void {
|
|
$tenant = Tenant::factory()->onboarding()->create();
|
|
$owner = User::factory()->create();
|
|
$otherWorkspaceUser = User::factory()->create();
|
|
$otherWorkspace = \App\Models\Workspace::factory()->create();
|
|
|
|
createUserWithTenant(
|
|
tenant: $tenant,
|
|
user: $owner,
|
|
role: 'owner',
|
|
workspaceRole: 'owner',
|
|
ensureDefaultMicrosoftProviderConnection: false,
|
|
);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => (int) $otherWorkspace->getKey(),
|
|
'user_id' => (int) $otherWorkspaceUser->getKey(),
|
|
'role' => 'owner',
|
|
]);
|
|
|
|
$draft = createOnboardingDraft([
|
|
'workspace' => $tenant->workspace,
|
|
'tenant' => $tenant,
|
|
'started_by' => $owner,
|
|
'updated_by' => $owner,
|
|
]);
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $otherWorkspace->getKey());
|
|
|
|
$result = app(TenantOnboardingSessionPolicy::class)->view($otherWorkspaceUser, $draft);
|
|
|
|
expect($result)->toBeInstanceOf(Response::class)
|
|
->and($result->allowed())->toBeFalse()
|
|
->and($result->status())->toBe(404);
|
|
});
|
|
|
|
it('returns an honest forbidden message for entitled actors missing onboarding capability', function (): void {
|
|
$tenant = Tenant::factory()->onboarding()->create();
|
|
$readonlyUser = User::factory()->create();
|
|
|
|
createUserWithTenant(
|
|
tenant: $tenant,
|
|
user: $readonlyUser,
|
|
role: 'readonly',
|
|
workspaceRole: 'readonly',
|
|
ensureDefaultMicrosoftProviderConnection: false,
|
|
);
|
|
|
|
$draft = createOnboardingDraft([
|
|
'workspace' => $tenant->workspace,
|
|
'tenant' => $tenant,
|
|
'started_by' => $readonlyUser,
|
|
'updated_by' => $readonlyUser,
|
|
]);
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
|
|
|
$viewResult = app(TenantOnboardingSessionPolicy::class)->view($readonlyUser, $draft);
|
|
$cancelResult = app(TenantOnboardingSessionPolicy::class)->cancel($readonlyUser, $draft);
|
|
|
|
expect($viewResult)->toBeInstanceOf(Response::class)
|
|
->and($viewResult->allowed())->toBeFalse()
|
|
->and($viewResult->message())->toBe('You do not have permission to continue this onboarding draft.')
|
|
->and($cancelResult)->toBeInstanceOf(Response::class)
|
|
->and($cancelResult->allowed())->toBeFalse()
|
|
->and($cancelResult->message())->toBe('You do not have permission to cancel this onboarding draft.');
|
|
});
|