ahmido
c6e7591d19
## Summary - add Intune RBAC role definitions and role assignments as foundation-backed inventory, backup, and versioned snapshot types - add RBAC-specific normalization, coverage, permission-warning handling, and preview-only restore safety behavior across existing Filament and service surfaces - add spec 127 artifacts, contracts, audits, and focused regression coverage for inventory, backup, versioning, verification, and authorization behavior ## Testing - `vendor/bin/sail bin pint --dirty --format agent` - `vendor/bin/sail artisan test --compact tests/Feature/Inventory/InventorySyncServiceTest.php tests/Feature/Filament/InventoryCoverageTableTest.php tests/Feature/FoundationBackupTest.php tests/Feature/Filament/RestoreExecutionTest.php tests/Feature/RestoreUnknownPolicyTypeSafetyTest.php tests/Unit/GraphContractRegistryTest.php tests/Unit/FoundationSnapshotServiceTest.php tests/Feature/Verification/IntuneRbacPermissionCoverageTest.php tests/Unit/IntuneRoleDefinitionNormalizerTest.php tests/Unit/IntuneRoleAssignmentNormalizerTest.php` ## Notes - tasks in `specs/127-rbac-inventory-backup/tasks.md` are complete except `T041`, which is the documented manual QA validation step Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #155
95 lines
2.6 KiB
PHP
95 lines
2.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Services\OperationRunService;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('increments only whitelisted summary_counts keys', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'policy.delete',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'context' => ['operation' => ['type' => 'policy.delete']],
|
|
'summary_counts' => [
|
|
'total' => 10,
|
|
'processed' => 1,
|
|
'secrets' => 999,
|
|
],
|
|
]);
|
|
|
|
/** @var OperationRunService $service */
|
|
$service = app(OperationRunService::class);
|
|
|
|
$service->incrementSummaryCounts($run, [
|
|
'processed' => 2,
|
|
'failed' => 1,
|
|
'secrets' => 123,
|
|
]);
|
|
|
|
$run->refresh();
|
|
|
|
expect($run->summary_counts['total'] ?? null)->toBe(10);
|
|
expect($run->summary_counts['processed'] ?? null)->toBe(3);
|
|
expect($run->summary_counts['failed'] ?? null)->toBe(1);
|
|
expect($run->summary_counts)->not->toHaveKey('secrets');
|
|
})->group('ops-ux');
|
|
|
|
it('increments canonical backup-flow summary keys used by RBAC foundation capture', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'backup_set.add_policies',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'context' => ['options' => ['include_foundations' => true]],
|
|
'summary_counts' => [
|
|
'total' => 1,
|
|
'processed' => 1,
|
|
'succeeded' => 1,
|
|
'created' => 1,
|
|
'items' => 1,
|
|
],
|
|
]);
|
|
|
|
/** @var OperationRunService $service */
|
|
$service = app(OperationRunService::class);
|
|
|
|
$service->incrementSummaryCounts($run, [
|
|
'total' => 2,
|
|
'items' => 2,
|
|
'processed' => 2,
|
|
'succeeded' => 2,
|
|
'created' => 1,
|
|
'updated' => 1,
|
|
'secrets' => 123,
|
|
]);
|
|
|
|
$run->refresh();
|
|
|
|
expect($run->summary_counts)->toMatchArray([
|
|
'total' => 3,
|
|
'processed' => 3,
|
|
'succeeded' => 3,
|
|
'created' => 2,
|
|
'updated' => 1,
|
|
'items' => 3,
|
|
]);
|
|
expect($run->summary_counts)->not->toHaveKey('secrets');
|
|
})->group('ops-ux');
|