Summary This PR implements Spec 049 – Backup/Restore Job Orchestration: all critical Backup/Restore execution paths are job-only, idempotent, tenant-scoped, and observable via run records + DB notifications (Phase 1). The UI no longer performs heavy Graph work inside request/Filament actions for these flows. Why We want predictable UX and operations at MSP scale: • no timeouts / long-running requests • reproducible run state + per-item results • safe error persistence (no secrets / no token leakage) • strict tenant isolation + auditability for write paths What changed Foundational (Runs + Idempotency + Observability) • Added a shared RunIdempotency helper (dedupe while queued/running). • Added a read-only BulkOperationRuns surface (list + view) for status/progress. • Added DB notifications for run status changes (with “View run” link). US1 – Policy “Capture snapshot” is job-only • Policy detail “Capture snapshot” now: • creates/reuses a run (dedupe key: tenant + policy.capture_snapshot + policy DB id) • dispatches a queued job • returns immediately with notification + link to run detail • Graph capture work moved fully into the job; request path stays Graph-free. US3 – Restore runs orchestration is job-only + safe • Live restore execution is queued and updates RestoreRun status/progress. • Per-item outcomes are persisted deterministically (per internal DB record). • Audit logging is written for live restore. • Preview/dry-run is enforced as read-only (no writes). Tenant isolation / authorization (non-negotiable) • Run list/view/start are tenant-scoped and policy-guarded (cross-tenant access => 403, not 404). • Explicit Pest tests cover cross-tenant denial and start authorization. Tests / Verification • ./vendor/bin/pint --dirty • Targeted suite (examples): • policy capture snapshot queued + idempotency tests • restore orchestration + audit logging + preview read-only tests • run authorization / tenant isolation tests Notes / Scope boundaries • Phase 1 UX = DB notifications + run detail page. A global “progress widget” is tracked as Phase 2 and not required for merge. • Resilience/backoff is tracked in tasks but can be iterated further after merge. Review focus • Dedupe behavior for queued/running runs (reuse vs create-new) • Tenant scoping & policy gates for all run surfaces • Restore safety: audit event + preview no-writes Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #56
58 lines
2.1 KiB
PHP
58 lines
2.1 KiB
PHP
<?php
|
|
|
|
use App\Models\BulkOperationRun;
|
|
use App\Models\RestoreRun;
|
|
use App\Support\RunIdempotency;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('builds a deterministic 64 char sha256 idempotency key', function () {
|
|
$keyA1 = RunIdempotency::buildKey(1, 'policy.capture_snapshot', 'abc', ['b' => 2, 'a' => 1]);
|
|
$keyA2 = RunIdempotency::buildKey(1, 'policy.capture_snapshot', 'abc', ['a' => 1, 'b' => 2]);
|
|
$keyB = RunIdempotency::buildKey(1, 'policy.capture_snapshot', 'def', ['a' => 1, 'b' => 2]);
|
|
|
|
expect($keyA1)->toBe($keyA2)
|
|
->and($keyA1)->not->toBe($keyB)
|
|
->and($keyA1)->toMatch('/^[a-f0-9]{64}$/');
|
|
});
|
|
|
|
it('finds only active bulk operation runs by idempotency key', function () {
|
|
$pending = BulkOperationRun::factory()->create([
|
|
'idempotency_key' => RunIdempotency::buildKey(1, 'bulk.policy.capture_snapshot', 'abc'),
|
|
'status' => 'pending',
|
|
]);
|
|
|
|
$completed = BulkOperationRun::factory()->create([
|
|
'tenant_id' => $pending->tenant_id,
|
|
'user_id' => $pending->user_id,
|
|
'idempotency_key' => $pending->idempotency_key,
|
|
'status' => 'completed',
|
|
]);
|
|
|
|
expect(RunIdempotency::findActiveBulkOperationRun($pending->tenant_id, $pending->idempotency_key))
|
|
->not->toBeNull()
|
|
->id->toBe($pending->id);
|
|
|
|
expect(RunIdempotency::findActiveBulkOperationRun($pending->tenant_id, $completed->idempotency_key))
|
|
->id->toBe($pending->id);
|
|
});
|
|
|
|
it('finds only active restore runs by idempotency key', function () {
|
|
$active = RestoreRun::factory()->create([
|
|
'idempotency_key' => RunIdempotency::buildKey(1, 'restore.execute', 123),
|
|
'status' => 'queued',
|
|
]);
|
|
|
|
RestoreRun::factory()->create([
|
|
'tenant_id' => $active->tenant_id,
|
|
'backup_set_id' => $active->backup_set_id,
|
|
'idempotency_key' => $active->idempotency_key,
|
|
'status' => 'completed',
|
|
]);
|
|
|
|
expect(RunIdempotency::findActiveRestoreRun($active->tenant_id, $active->idempotency_key))
|
|
->not->toBeNull()
|
|
->id->toBe($active->id);
|
|
});
|