ahmido
1acbf8cc54
## Summary - remove tenant-based Graph options access from runtime service paths and enforce provider-only resolution - add `MicrosoftGraphOptionsResolver` and `ProviderConfigurationRequiredException` for centralized, actionable provider-config errors - turn `Tenant::graphOptions()` into a fail-fast kill switch to prevent legacy runtime usage - add and update tests (including guardrail) to enforce no reintroduction in `app/` - update Spec 088 artifacts (`spec`, `plan`, `research`, `tasks`, checklist) ## Validation - `vendor/bin/sail bin pint --dirty` - `vendor/bin/sail artisan test --compact --filter=NoLegacyTenantGraphOptions` - `vendor/bin/sail artisan test --compact tests/Feature/Filament` - `CI=1 vendor/bin/sail artisan test --compact` ## Notes - Branch includes the guardrail test for legacy callsite detection in `app/`. - Full suite currently green: 1227 passed, 5 skipped. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #105
67 lines
2.3 KiB
PHP
67 lines
2.3 KiB
PHP
<?php
|
|
|
|
use App\Models\Policy;
|
|
use App\Models\Tenant;
|
|
use App\Services\Graph\AssignmentFetcher;
|
|
use App\Services\Graph\AssignmentFilterResolver;
|
|
use App\Services\Graph\GroupResolver;
|
|
use App\Services\Graph\ScopeTagResolver;
|
|
use App\Services\Intune\PolicyCaptureOrchestrator;
|
|
use App\Services\Intune\PolicySnapshotService;
|
|
use App\Services\Intune\VersionService;
|
|
use App\Services\Providers\MicrosoftGraphOptionsResolver;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
test('capture returns failure when snapshot fetch fails (no exception)', function () {
|
|
$tenant = Tenant::factory()->create([
|
|
'tenant_id' => 'tenant-1',
|
|
'app_client_id' => 'client-1',
|
|
'app_client_secret' => 'secret-1',
|
|
'is_current' => true,
|
|
]);
|
|
|
|
ensureDefaultProviderConnection($tenant, 'microsoft');
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'policy_type' => 'mamAppConfiguration',
|
|
'external_id' => 'A_f38e7f58-ac7c-455d-bb0e-f56bf1b3890e',
|
|
'display_name' => 'MAM Example',
|
|
'platform' => 'mobile',
|
|
]);
|
|
|
|
$snapshotService = Mockery::mock(PolicySnapshotService::class);
|
|
$snapshotService
|
|
->shouldReceive('fetch')
|
|
->once()
|
|
->andReturn([
|
|
'failure' => [
|
|
'reason' => 'InternalServerError: upstream',
|
|
'status' => 500,
|
|
],
|
|
]);
|
|
|
|
$orchestrator = new PolicyCaptureOrchestrator(
|
|
versionService: Mockery::mock(VersionService::class),
|
|
snapshotService: $snapshotService,
|
|
assignmentFetcher: Mockery::mock(AssignmentFetcher::class),
|
|
groupResolver: Mockery::mock(GroupResolver::class),
|
|
assignmentFilterResolver: Mockery::mock(AssignmentFilterResolver::class),
|
|
scopeTagResolver: Mockery::mock(ScopeTagResolver::class),
|
|
graphOptionsResolver: app(MicrosoftGraphOptionsResolver::class),
|
|
);
|
|
|
|
$result = $orchestrator->capture(
|
|
policy: $policy,
|
|
tenant: $tenant,
|
|
includeAssignments: true,
|
|
includeScopeTags: true,
|
|
createdBy: 'admin@example.test',
|
|
);
|
|
|
|
expect($result)->toHaveKey('failure');
|
|
expect($result['failure']['status'])->toBe(500);
|
|
expect($result['failure']['reason'])->toContain('InternalServerError');
|
|
});
|