TenantAtlas/apps/platform/tests/Feature/Monitoring/HeaderContextBarTest.php
ahmido e0c2cdb1f4 feat: enforce workspace and environment scope contract (Spec 338) (#409)
## Summary
- enforce the canonical workspace/environment scope contract for workspace hubs and environment-owned surfaces
- replace first-party Operations deep links that leaked Filament `tableFilters[...]` internals with stable product-level query behavior
- add the sidebar scope indicator and split environment-page navigation into explicit `Workspace-wide` and `Workspace admin` groups
- remove redundant tenantless `All environments` scope badges from workspace-wide pages while preserving explicit environment filter affordances
- include the Spec 338 artifacts, guard tests, and browser smoke coverage for the new contract

## Validation
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Navigation/Spec338EnvironmentSidebarSeparationTest.php tests/Feature/Navigation/Spec338OperationRunLinksQueryContractTest.php tests/Feature/Navigation/Spec338SidebarScopeIndicatorTest.php tests/Feature/Filament/PanelNavigationSegregationTest.php`
- `cd apps/platform && ./vendor/bin/sail php vendor/bin/pest tests/Browser/Spec338ScopeContractSmokeTest.php --compact`

## Notes
- Livewire v4 compliance unchanged
- Filament provider registration remains in `bootstrap/providers.php`
- no destructive action behavior changed
- no migrations, env var changes, or new Filament asset registration

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #409
2026-05-31 01:36:08 +00:00

300 lines
11 KiB
PHP

<?php
declare(strict_types=1);
use App\Filament\Pages\ChooseWorkspace;
use App\Models\ManagedEnvironment;
use App\Models\OperationRun;
use App\Support\ManagedEnvironmentLinks;
use App\Support\Workspaces\WorkspaceContext;
use Filament\Facades\Filament;
it('renders the tenant context picker on tenantless Monitoring → Operations', function (): void {
$tenant = ManagedEnvironment::factory()->create(['status' => 'active']);
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
$workspaceName = $tenant->workspace?->name;
Filament::setTenant(null, true);
$response = $this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
WorkspaceContext::LAST_ENVIRONMENT_IDS_SESSION_KEY => [
(string) $tenant->workspace_id => (int) $tenant->getKey(),
],
])
->get(route('admin.operations.index', ['workspace' => $tenant->workspace]))
->assertOk()
->assertSee($workspaceName ?? 'Select workspace')
->assertSee(__('localization.shell.search_environments'))
->assertSee('Switch workspace')
->assertSee('admin/select-environment')
->assertSee(__('localization.shell.clear_environment_scope'))
->assertSee($tenant->name)
->assertDontSee('MANAGED_ENVIRONMENT');
$content = $response->getContent();
expect($content)->not->toBeFalse();
expect(
preg_match('/<a[^>]+href="([^"]+)"[^>]*>\s*Switch workspace\s*<\/a>/i', (string) $content, $matches)
)->toBe(1);
expect($matches[1] ?? null)->toBe(ChooseWorkspace::getUrl(panel: 'admin').'?choose=1');
expect($matches[1] ?? null)->not->toContain('/admin/workspaces');
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
])
->post(route('admin.select-environment'), ['managed_environment_id' => (int) $tenant->getKey()])
->assertRedirect();
});
it('disables the tenant picker when no workspace is active (Global Mode)', function (): void {
$user = \App\Models\User::factory()->create();
$workspace = \App\Models\Workspace::factory()->create();
\App\Models\WorkspaceMembership::factory()->create([
'workspace_id' => (int) $workspace->getKey(),
'user_id' => (int) $user->getKey(),
'role' => 'owner',
]);
Filament::setTenant(null, true);
session()->forget(WorkspaceContext::SESSION_KEY);
$this->actingAs($user)
->get('/admin/workspaces')
->assertOk()
->assertSee('Choose a workspace first.')
->assertDontSee(__('localization.shell.search_environments'));
});
it('keeps tenant-scoped pages selector read-only while exposing the clear tenant scope action', function (): void {
$tenant = ManagedEnvironment::factory()->create(['status' => 'active']);
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
])
->get(ManagedEnvironmentLinks::viewUrl($tenant))
->assertOk()
->assertSee($tenant->name)
->assertSee(__('localization.shell.clear_environment_scope'))
->assertDontSee('MANAGED_ENVIRONMENT');
});
it('renders routed tenant resource view pages with a clear tenant scope action but no inline selector list', function (): void {
$currentTenant = ManagedEnvironment::factory()->create([
'status' => 'active',
'name' => 'YPTW2',
'environment' => 'dev',
]);
[$user, $currentTenant] = createUserWithTenant($currentTenant, role: 'owner');
$routedTenant = ManagedEnvironment::factory()->create([
'status' => ManagedEnvironment::STATUS_ONBOARDING,
'workspace_id' => (int) $currentTenant->workspace_id,
'name' => 'Test',
'environment' => 'dev',
]);
createUserWithTenant($routedTenant, $user, role: 'owner');
Filament::setTenant($currentTenant, true);
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $currentTenant->workspace_id,
WorkspaceContext::LAST_ENVIRONMENT_IDS_SESSION_KEY => [
(string) $currentTenant->workspace_id => (int) $currentTenant->getKey(),
],
])
->get(ManagedEnvironmentLinks::viewUrl($routedTenant))
->assertOk()
->assertSee(__('localization.shell.clear_environment_scope'));
});
it('filters the header tenant picker to tenants the user can access', function (): void {
$tenantA = ManagedEnvironment::factory()->create(['status' => 'active']);
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner', workspaceRole: 'readonly');
$tenantB = ManagedEnvironment::factory()->create([
'status' => 'active',
'workspace_id' => (int) $tenantA->workspace_id,
'name' => 'ZZZ-UNAUTHORIZED-TENANT-NAME-12345',
]);
Filament::setTenant(null, true);
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
])
->get(route('admin.operations.index', ['workspace' => $tenantA->workspace]))
->assertOk()
->assertSee($tenantA->name)
->assertDontSee($tenantB->name)
->assertDontSee('MANAGED_ENVIRONMENT');
});
it('keeps the header tenant picker limited to tenant-entitled active tenants for workspace owners', function (): void {
$tenantA = ManagedEnvironment::factory()->create(['status' => 'active']);
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner', workspaceRole: 'owner');
$tenantB = ManagedEnvironment::factory()->create([
'status' => 'active',
'workspace_id' => (int) $tenantA->workspace_id,
'name' => 'ZZZ-UNASSIGNED-TENANT-NAME-12345',
]);
Filament::setTenant(null, true);
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
])
->get(route('admin.operations.index', ['workspace' => $tenantA->workspace]))
->assertOk()
->assertSee($tenantA->name)
->assertDontSee($tenantB->name)
->assertDontSee('MANAGED_ENVIRONMENT');
});
it('hides onboarding tenants from the header tenant picker even for workspace owners', function (): void {
$tenantA = ManagedEnvironment::factory()->create([
'status' => 'active',
'name' => 'YPTW2',
'environment' => 'other',
]);
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner', workspaceRole: 'owner');
$onboardingTenant = ManagedEnvironment::factory()->create([
'status' => ManagedEnvironment::STATUS_ONBOARDING,
'workspace_id' => (int) $tenantA->workspace_id,
'name' => 'ZZZ-ONBOARDING-TENANT-NAME-12345',
'environment' => 'dev',
]);
Filament::setTenant(null, true);
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
])
->get(route('admin.operations.index', ['workspace' => $tenantA->workspace]))
->assertOk()
->assertSee($tenantA->name)
->assertDontSee($onboardingTenant->name)
->assertDontSee('MANAGED_ENVIRONMENT');
});
it('does not implicitly switch tenant when opening canonical operation deep links', function (): void {
$tenantA = ManagedEnvironment::factory()->create(['status' => 'active']);
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner');
$tenantB = ManagedEnvironment::factory()->create([
'status' => 'active',
'workspace_id' => (int) $tenantA->workspace_id,
]);
$user->tenants()->syncWithoutDetaching([
$tenantB->getKey() => ['role' => 'owner'],
]);
$runA = OperationRun::factory()->create([
'managed_environment_id' => (int) $tenantA->getKey(),
'workspace_id' => (int) $tenantA->workspace_id,
'type' => 'policy.sync',
'initiator_name' => 'TenantA',
]);
OperationRun::factory()->create([
'managed_environment_id' => (int) $tenantB->getKey(),
'workspace_id' => (int) $tenantB->workspace_id,
'type' => 'inventory_sync',
'initiator_name' => 'TenantB',
]);
Filament::setTenant(null, true);
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
])
->get(route('admin.operations.view', ['workspace' => $tenantA->workspace, 'run' => (int) $runA->getKey()]))
->assertOk();
expect(Filament::getTenant())->toBeNull();
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
])
->get(route('admin.operations.index', ['workspace' => $tenantA->workspace]))
->assertOk()
->assertSee('Policy sync')
->assertSee('Inventory sync')
->assertSee('TenantA')
->assertSee('TenantB');
});
it('shows explicit mismatch context on canonical run pages while keeping the current header tenant label', function (): void {
$runTenant = ManagedEnvironment::factory()->create([
'name' => 'Run ManagedEnvironment',
]);
[$user, $runTenant] = createUserWithTenant($runTenant, role: 'owner');
$currentTenant = ManagedEnvironment::factory()->create([
'name' => 'Current ManagedEnvironment',
'workspace_id' => (int) $runTenant->workspace_id,
]);
createUserWithTenant($currentTenant, $user, role: 'owner');
$run = OperationRun::factory()->create([
'managed_environment_id' => (int) $runTenant->getKey(),
'workspace_id' => (int) $runTenant->workspace_id,
'type' => 'policy.sync',
]);
Filament::setTenant($currentTenant, true);
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $runTenant->workspace_id,
])
->get(route('admin.operations.view', ['workspace' => $runTenant->workspace, 'run' => (int) $run->getKey()]))
->assertOk()
->assertSee(__('localization.shell.environment_scope').': Current ManagedEnvironment')
->assertSee('Current environment context differs from this operation')
->assertSee('Operation environment: Run ManagedEnvironment.');
});
it('shows canonical workspace framing on canonical run pages with no selected tenant context', function (): void {
$tenant = ManagedEnvironment::factory()->create([
'name' => 'Workspace ManagedEnvironment',
]);
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
$run = OperationRun::factory()->create([
'managed_environment_id' => (int) $tenant->getKey(),
'workspace_id' => (int) $tenant->workspace_id,
'type' => 'policy.sync',
]);
Filament::setTenant(null, true);
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
])
->get(route('admin.operations.view', ['workspace' => $tenant->workspace, 'run' => (int) $run->getKey()]))
->assertOk()
->assertDontSee(__('localization.shell.all_environments'))
->assertSee('Canonical workspace view')
->assertSee('No environment context is currently selected.');
});