## Summary Automated scanning of Entra ID directory roles to surface high-privilege role assignments as trackable findings with alerting support. ## What's included ### Core Services - **EntraAdminRolesReportService** — Fetches role definitions + assignments via Graph API, builds payload with fingerprint deduplication - **EntraAdminRolesFindingGenerator** — Creates/resolves/reopens findings based on high-privilege role catalog - **HighPrivilegeRoleCatalog** — Curated list of high-privilege Entra roles (Global Admin, Privileged Auth Admin, etc.) - **ScanEntraAdminRolesJob** — Queued job orchestrating scan → report → findings → alerts pipeline ### UI - **AdminRolesSummaryWidget** — Tenant dashboard card showing last scan time, high-privilege assignment count, scan trigger button - RBAC-gated: `ENTRA_ROLES_VIEW` for viewing, `ENTRA_ROLES_MANAGE` for scan trigger ### Infrastructure - Graph contracts for `entraRoleDefinitions` + `entraRoleAssignments` - `config/entra_permissions.php` — Entra permission registry - `StoredReport.fingerprint` migration (deduplication support) - `OperationCatalog` label + duration for `entra.admin_roles.scan` - Artisan command `entra:scan-admin-roles` for CLI/scheduled use ### Global UX improvement - **SummaryCountsNormalizer**: Zero values filtered, snake_case keys humanized (e.g. `report_deduped: 1` → `Report deduped: 1`). Affects all operation notifications. ## Test Coverage - **12 test files**, **79+ tests**, **307+ assertions** - Report service, finding generator, job orchestration, widget rendering, alert integration, RBAC enforcement, badge mapping ## Spec artifacts - `specs/105-entra-admin-roles-evidence-findings/tasks.md` — Full task breakdown (38 tasks, all complete) - `specs/105-entra-admin-roles-evidence-findings/checklists/requirements.md` — All items checked ## Files changed 46 files changed, 3641 insertions(+), 15 deletions(-) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #128
116 lines
4.0 KiB
PHP
116 lines
4.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Jobs;
|
|
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Services\EntraAdminRoles\EntraAdminRolesFindingGenerator;
|
|
use App\Services\EntraAdminRoles\EntraAdminRolesReportService;
|
|
use App\Services\OperationRunService;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\OpsUx\RunFailureSanitizer;
|
|
use Illuminate\Bus\Queueable;
|
|
use Illuminate\Contracts\Queue\ShouldQueue;
|
|
use Illuminate\Foundation\Bus\Dispatchable;
|
|
use Illuminate\Queue\InteractsWithQueue;
|
|
use Illuminate\Queue\SerializesModels;
|
|
use Throwable;
|
|
|
|
class ScanEntraAdminRolesJob implements ShouldQueue
|
|
{
|
|
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
|
|
|
|
public function __construct(
|
|
public readonly int $tenantId,
|
|
public readonly int $workspaceId,
|
|
public readonly ?int $initiatorUserId = null,
|
|
) {}
|
|
|
|
public function handle(
|
|
EntraAdminRolesReportService $reportService,
|
|
EntraAdminRolesFindingGenerator $findingGenerator,
|
|
OperationRunService $operationRuns,
|
|
): void {
|
|
$tenant = Tenant::query()->find($this->tenantId);
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return;
|
|
}
|
|
|
|
// FR-018: Skip tenants without active provider connection
|
|
$hasConnection = ProviderConnection::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('status', 'connected')
|
|
->exists();
|
|
|
|
if (! $hasConnection) {
|
|
return;
|
|
}
|
|
|
|
$initiator = $this->initiatorUserId !== null
|
|
? User::query()->find($this->initiatorUserId)
|
|
: null;
|
|
|
|
$operationRun = $operationRuns->ensureRunWithIdentity(
|
|
tenant: $tenant,
|
|
type: 'entra.admin_roles.scan',
|
|
identityInputs: [
|
|
'tenant_id' => $this->tenantId,
|
|
'trigger' => 'scan',
|
|
],
|
|
context: [
|
|
'workspace_id' => $this->workspaceId,
|
|
'initiator_user_id' => $this->initiatorUserId,
|
|
],
|
|
initiator: $initiator instanceof User ? $initiator : null,
|
|
);
|
|
|
|
$operationRuns->updateRun(
|
|
$operationRun,
|
|
status: OperationRunStatus::Running->value,
|
|
outcome: OperationRunOutcome::Pending->value,
|
|
);
|
|
|
|
try {
|
|
$reportResult = $reportService->generate($tenant, $operationRun);
|
|
|
|
$findingResult = $findingGenerator->generate($tenant, $reportResult->payload, $operationRun);
|
|
|
|
$operationRuns->updateRun(
|
|
$operationRun,
|
|
status: OperationRunStatus::Completed->value,
|
|
outcome: OperationRunOutcome::Succeeded->value,
|
|
summaryCounts: [
|
|
'report_created' => $reportResult->created ? 1 : 0,
|
|
'report_deduped' => $reportResult->created ? 0 : 1,
|
|
'findings_created' => $findingResult->created,
|
|
'findings_resolved' => $findingResult->resolved,
|
|
'findings_reopened' => $findingResult->reopened,
|
|
'findings_unchanged' => $findingResult->unchanged,
|
|
'alert_events_produced' => $findingResult->alertEventsProduced,
|
|
],
|
|
);
|
|
} catch (Throwable $e) {
|
|
$message = RunFailureSanitizer::sanitizeMessage($e->getMessage());
|
|
$reasonCode = RunFailureSanitizer::normalizeReasonCode($e->getMessage());
|
|
|
|
$operationRuns->updateRun(
|
|
$operationRun,
|
|
status: OperationRunStatus::Completed->value,
|
|
outcome: OperationRunOutcome::Failed->value,
|
|
failures: [[
|
|
'code' => 'entra.admin_roles.scan.failed',
|
|
'reason_code' => $reasonCode,
|
|
'message' => $message !== '' ? $message : 'Entra admin roles scan failed.',
|
|
]],
|
|
);
|
|
|
|
throw $e;
|
|
}
|
|
}
|
|
}
|