## Summary Automated scanning of Entra ID directory roles to surface high-privilege role assignments as trackable findings with alerting support. ## What's included ### Core Services - **EntraAdminRolesReportService** — Fetches role definitions + assignments via Graph API, builds payload with fingerprint deduplication - **EntraAdminRolesFindingGenerator** — Creates/resolves/reopens findings based on high-privilege role catalog - **HighPrivilegeRoleCatalog** — Curated list of high-privilege Entra roles (Global Admin, Privileged Auth Admin, etc.) - **ScanEntraAdminRolesJob** — Queued job orchestrating scan → report → findings → alerts pipeline ### UI - **AdminRolesSummaryWidget** — Tenant dashboard card showing last scan time, high-privilege assignment count, scan trigger button - RBAC-gated: `ENTRA_ROLES_VIEW` for viewing, `ENTRA_ROLES_MANAGE` for scan trigger ### Infrastructure - Graph contracts for `entraRoleDefinitions` + `entraRoleAssignments` - `config/entra_permissions.php` — Entra permission registry - `StoredReport.fingerprint` migration (deduplication support) - `OperationCatalog` label + duration for `entra.admin_roles.scan` - Artisan command `entra:scan-admin-roles` for CLI/scheduled use ### Global UX improvement - **SummaryCountsNormalizer**: Zero values filtered, snake_case keys humanized (e.g. `report_deduped: 1` → `Report deduped: 1`). Affects all operation notifications. ## Test Coverage - **12 test files**, **79+ tests**, **307+ assertions** - Report service, finding generator, job orchestration, widget rendering, alert integration, RBAC enforcement, badge mapping ## Spec artifacts - `specs/105-entra-admin-roles-evidence-findings/tasks.md` — Full task breakdown (38 tasks, all complete) - `specs/105-entra-admin-roles-evidence-findings/checklists/requirements.md` — All items checked ## Files changed 46 files changed, 3641 insertions(+), 15 deletions(-) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #128
161 lines
6.0 KiB
PHP
161 lines
6.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
|
|
/*
|
|
|--------------------------------------------------------------------------
|
|
| T001 — Sidebar context tests for Required Permissions page
|
|
|--------------------------------------------------------------------------
|
|
|
|
|
| Verifies that the Required Permissions page (a workspace-scoped page
|
|
| that uses {tenant} for data display only) always renders the workspace
|
|
| sidebar — never the tenant sidebar. Also verifies FR-002: authorization
|
|
| (404 for non-members) still works after the middleware change.
|
|
|
|
|
*/
|
|
|
|
it('renders workspace navigation items on the required permissions page', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
|
|
$response = $this->actingAs($user)
|
|
->get("/admin/tenants/{$tenant->external_id}/required-permissions");
|
|
|
|
$response->assertOk();
|
|
|
|
// Workspace nav items from configureNavigationForRequest() workspace builder
|
|
$response->assertSee('Operations', false);
|
|
$response->assertSee('Audit Log', false);
|
|
});
|
|
|
|
it('does not render tenant navigation items on the required permissions page', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
|
|
$response = $this->actingAs($user)
|
|
->get("/admin/tenants/{$tenant->external_id}/required-permissions");
|
|
|
|
$response->assertOk();
|
|
|
|
// Tenant-scoped nav groups/items must NOT appear
|
|
$response->assertDontSee('>Inventory</span>', false);
|
|
$response->assertDontSee('>Backups & Restore</span>', false);
|
|
});
|
|
|
|
it('shows workspace sidebar when navigating directly via URL', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
|
|
$response = $this->actingAs($user)
|
|
->get("/admin/tenants/{$tenant->external_id}/required-permissions");
|
|
|
|
$response->assertOk();
|
|
|
|
// Workspace nav present (Operations is always visible in workspace nav)
|
|
$response->assertSee('Operations', false);
|
|
$response->assertSee('Audit Log', false);
|
|
|
|
// Tenant nav absent
|
|
$response->assertDontSee('>Directory</span>', false);
|
|
$response->assertDontSee('>Governance</span>', false);
|
|
});
|
|
|
|
it('returns 404 for non-workspace-members after middleware change (FR-002 regression guard)', function (): void {
|
|
$user = User::factory()->create();
|
|
$workspace = Workspace::factory()->create();
|
|
$tenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
]);
|
|
|
|
// User is NOT a workspace member — no WorkspaceMembership created
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $workspace->getKey(),
|
|
])
|
|
->get("/admin/tenants/{$tenant->external_id}/required-permissions")
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('returns 404 for workspace members without tenant entitlement after middleware change (FR-002 regression guard)', function (): void {
|
|
$user = User::factory()->create();
|
|
$workspace = Workspace::factory()->create();
|
|
$tenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
]);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'user_id' => (int) $user->getKey(),
|
|
'role' => 'owner',
|
|
]);
|
|
|
|
// User IS a workspace member but NOT entitled to this tenant
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $workspace->getKey(),
|
|
])
|
|
->get("/admin/tenants/{$tenant->external_id}/required-permissions")
|
|
->assertNotFound();
|
|
});
|
|
|
|
/*
|
|
|--------------------------------------------------------------------------
|
|
| T002 — Regression: tenant-scoped pages still show tenant sidebar
|
|
|--------------------------------------------------------------------------
|
|
|
|
|
| Verifies that the middleware change does NOT affect tenant-scoped pages.
|
|
| Pages under /admin/t/{tenant}/ must continue to show tenant sidebar.
|
|
|
|
|
*/
|
|
|
|
it('still renders tenant sidebar on tenant-scoped pages (regression guard)', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
// Use the tenant dashboard — a known tenant-scoped URL
|
|
$response = $this->actingAs($user)
|
|
->get("/admin/t/{$tenant->external_id}");
|
|
|
|
$response->assertOk();
|
|
|
|
// Tenant-scoped nav groups MUST be present on tenant pages (Inventory group)
|
|
$response->assertSee('Inventory', false);
|
|
});
|
|
|
|
/*
|
|
|--------------------------------------------------------------------------
|
|
| T007 — Context bar: tenant name is visible on the page
|
|
|--------------------------------------------------------------------------
|
|
|
|
|
| The page's $scopedTenant is resolved from the route param via
|
|
| resolveScopedTenant() — NOT from Filament::getTenant(). So the tenant
|
|
| data is available even though Filament::setTenant() is skipped.
|
|
| Verify the page renders successfully and that the tenant's data is used.
|
|
|
|
|
*/
|
|
|
|
it('resolves scoped tenant correctly with workspace sidebar (context bar / US2)', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
|
|
$response = $this->actingAs($user)
|
|
->get("/admin/tenants/{$tenant->external_id}/required-permissions");
|
|
|
|
$response->assertOk();
|
|
|
|
// The page resolves $scopedTenant from route param and uses it for data display.
|
|
// Verify the page title is present (static title: "Required permissions")
|
|
$response->assertSee('Required permissions', false);
|
|
|
|
// The page uses $scopedTenant for links (e.g., "Re-run verification" links back to TenantResource)
|
|
// If $scopedTenant were null, the page would abort(404) in mount().
|
|
// The fact that we get 200 proves $scopedTenant resolved correctly despite setTenant() being skipped.
|
|
|
|
// Workspace nav present (sidebar fix working)
|
|
$response->assertSee('Operations', false);
|
|
|
|
// Tenant nav absent (sidebar fix working)
|
|
$response->assertDontSee('>Inventory</span>', false);
|
|
});
|