ahmido
d90fb0f963
PR Body Implements Spec 065 “Tenant RBAC v1” with capabilities-first RBAC, tenant membership scoping (Option 3), and consistent Filament action semantics. Key decisions / rules Tenancy Option 3: tenant switching is tenantless (ChooseTenant), tenant-scoped routes stay scoped, non-members get 404 (not 403). RBAC model: canonical capability registry + role→capability map + Gates for each capability (no role-string checks in UI logic). UX policy: for tenant members lacking permission → actions are visible but disabled + tooltip (avoid click→403). Security still enforced server-side. What’s included Capabilities foundation: Central capability registry (Capabilities::*) Role→capability mapping (RoleCapabilityMap) Gate registration + resolver/manager updates to support tenant-scoped authorization Filament enforcement hardening across the app: Tenant registration & tenant CRUD properly gated Backup/restore/policy flows aligned to “visible-but-disabled” where applicable Provider operations (health check / inventory sync / compliance snapshot) guarded and normalized Directory groups + inventory sync start surfaces normalized Policy version maintenance actions (archive/restore/prune/force delete) gated SpecKit artifacts for 065: spec.md, plan/tasks updates, checklists, enforcement hitlist Security guarantees Non-member → 404 via tenant scoping/membership guards. Member without capability → 403 on execution, even if UI is disabled. No destructive actions execute without proper authorization checks. Tests Adds/updates Pest coverage for: Tenant scoping & membership denial behavior Role matrix expectations (owner/manager/operator/readonly) Filament surface checks (visible/disabled actions, no side effects) Provider/Inventory/Groups run-start authorization Verified locally with targeted vendor/bin/sail artisan test --compact … Deployment / ops notes No new services required. Safe change: behavior is authorization + UI semantics; no breaking route changes intended. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #79
75 lines
2.1 KiB
PHP
75 lines
2.1 KiB
PHP
<?php
|
|
|
|
use App\Filament\Pages\InventoryCoverage;
|
|
use App\Filament\Resources\InventoryItemResource;
|
|
use App\Filament\Resources\InventorySyncRunResource;
|
|
use App\Models\InventoryItem;
|
|
use App\Models\InventorySyncRun;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
|
|
uses(\Illuminate\Foundation\Testing\RefreshDatabase::class);
|
|
|
|
test('inventory hub pages load for a tenant', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$user = User::factory()->create();
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenant->getKey() => ['role' => 'owner'],
|
|
]);
|
|
|
|
InventoryItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'display_name' => 'Item A',
|
|
'policy_type' => 'deviceConfiguration',
|
|
'external_id' => 'item-a',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
InventorySyncRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'selection_hash' => str_repeat('a', 64),
|
|
'status' => InventorySyncRun::STATUS_SUCCESS,
|
|
]);
|
|
|
|
$itemsUrl = InventoryItemResource::getUrl('index', tenant: $tenant);
|
|
$syncRunsUrl = InventorySyncRunResource::getUrl('index', tenant: $tenant);
|
|
$coverageUrl = InventoryCoverage::getUrl(tenant: $tenant);
|
|
|
|
$kpiLabels = [
|
|
'Total items',
|
|
'Coverage',
|
|
'Last inventory sync',
|
|
'Active ops',
|
|
'Inventory ops',
|
|
];
|
|
|
|
$this->actingAs($user)
|
|
->get($itemsUrl)
|
|
->assertOk()
|
|
->assertSee('Run Inventory Sync')
|
|
->assertSee($syncRunsUrl)
|
|
->assertSee($coverageUrl)
|
|
->assertSee($kpiLabels)
|
|
->assertSee('Item A');
|
|
|
|
$this->actingAs($user)
|
|
->get($syncRunsUrl)
|
|
->assertOk()
|
|
->assertSee($itemsUrl)
|
|
->assertSee($coverageUrl)
|
|
->assertSee($kpiLabels)
|
|
->assertSee(str_repeat('a', 12));
|
|
|
|
$this->actingAs($user)
|
|
->get(InventoryCoverage::getUrl(tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee($itemsUrl)
|
|
->assertSee($syncRunsUrl)
|
|
->assertSee($kpiLabels)
|
|
->assertSee('Coverage')
|
|
->assertSee('Policies')
|
|
->assertSee('Foundations')
|
|
->assertSee('Dependencies');
|
|
});
|