ahmido
a449ecec5b
Beschreibung Implementiert das Drift MVP Feature (Spec: 044-drift-mvp) mit Fokus auf automatische Drift-Erkennung zwischen Inventory Sync Runs und Bulk-Triage für Findings. Was wurde implementiert? Drift-Erkennung: Vergleicht Policy-Snapshots, Assignments und Scope Tags zwischen Baseline- und Current-Runs. Deterministische Fingerprints verhindern Duplikate. Findings UI: Neue Filament Resource für Findings mit Listen- und Detail-Ansicht. DB-only Diffs (keine Graph-Calls zur Laufzeit). Bulk Acknowledge: "Acknowledge selected" (Bulk-Action auf der Liste) "Acknowledge all matching" (Header-Action, respektiert aktuelle Filter; Type-to-Confirm bei >100 Findings) Scope Tag Fix: Behebt False Positives bei Legacy-Daten ohne scope_tags.ids (inferiert Default-Werte). Authorization: Tenant-isoliert, Rollen-basiert (Owner/Manager/Operator können acknowledge). Tests: Vollständige Pest-Coverage (28 Tests, 347 Assertions) für Drift-Logik, UI und Bulk-Actions. Warum diese Änderungen? Problem: Keine automatisierte Drift-Erkennung; manuelle Triage bei vielen Findings ist mühsam. Lösung: Async Drift-Generierung mit persistenter Findings-Tabelle. Safe Bulk-Tools für Massen-Triage ohne Deletes. Konformität: Folgt AGENTS.md Workflow, Spec-Kit (Tasks + Checklists abgehakt), Laravel/Filament Best Practices. Technische Details Neue Dateien: ~40 (Models, Services, Tests, Views, Migrations) Änderungen: Filament Resources, Jobs, Policies DB: Neue findings Tabelle (JSONB für Evidence, Indexes für Performance) Tests: ./vendor/bin/sail artisan test tests/Feature/Drift --parallel → 28 passed Migration: ./vendor/bin/sail artisan migrate (neue Tabelle + Indexes) Screenshots / Links Spec: spec.md Tasks: tasks.md (alle abgehakt) UI: Findings-Liste mit Bulk-Actions; Detail-View mit Diffs Checklist Tests passieren (parallel + serial) Code formatiert (./vendor/bin/pint --dirty) Migration reversibel Tenant-Isolation enforced No Graph-Calls in Views Authorization checks Spec + Tasks aligned Deployment Notes Neue Migration: create_findings_table Neue Permissions: drift.view, drift.acknowledge Queue-Job: GenerateDriftFindingsJob (async, deduped)
81 lines
3.3 KiB
PHP
81 lines
3.3 KiB
PHP
<?php
|
|
|
|
use App\Models\Finding;
|
|
use App\Models\InventorySyncRun;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Services\Drift\DriftFindingGenerator;
|
|
|
|
test('drift generation is tenant isolated', function () {
|
|
[$userA, $tenantA] = createUserWithTenant(role: 'manager');
|
|
[$userB, $tenantB] = createUserWithTenant(role: 'manager');
|
|
|
|
$scopeKey = hash('sha256', 'scope-tenant');
|
|
|
|
$baselineA = InventorySyncRun::factory()->for($tenantA)->create([
|
|
'selection_hash' => $scopeKey,
|
|
'selection_payload' => ['policy_types' => ['settingsCatalogPolicy']],
|
|
'status' => InventorySyncRun::STATUS_SUCCESS,
|
|
'finished_at' => now()->subDays(2),
|
|
]);
|
|
|
|
$currentA = InventorySyncRun::factory()->for($tenantA)->create([
|
|
'selection_hash' => $scopeKey,
|
|
'selection_payload' => ['policy_types' => ['settingsCatalogPolicy']],
|
|
'status' => InventorySyncRun::STATUS_SUCCESS,
|
|
'finished_at' => now()->subDay(),
|
|
]);
|
|
|
|
$policyA = Policy::factory()->for($tenantA)->create([
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
]);
|
|
|
|
$baselineAssignments = [['target' => ['groupId' => 'group-a'], '@odata.type' => '#microsoft.graph.groupAssignmentTarget']];
|
|
$currentAssignments = [['target' => ['groupId' => 'group-b'], '@odata.type' => '#microsoft.graph.groupAssignmentTarget']];
|
|
|
|
PolicyVersion::factory()->for($tenantA)->for($policyA)->create([
|
|
'version_number' => 1,
|
|
'policy_type' => $policyA->policy_type,
|
|
'captured_at' => $baselineA->finished_at->copy()->subMinute(),
|
|
'assignments' => $baselineAssignments,
|
|
'assignments_hash' => hash('sha256', json_encode($baselineAssignments)),
|
|
]);
|
|
|
|
PolicyVersion::factory()->for($tenantA)->for($policyA)->create([
|
|
'version_number' => 2,
|
|
'policy_type' => $policyA->policy_type,
|
|
'captured_at' => $currentA->finished_at->copy()->subMinute(),
|
|
'assignments' => $currentAssignments,
|
|
'assignments_hash' => hash('sha256', json_encode($currentAssignments)),
|
|
]);
|
|
|
|
$policyB = Policy::factory()->for($tenantB)->create([
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
]);
|
|
|
|
$baselineAssignmentsB = [['target' => ['groupId' => 'group-x'], '@odata.type' => '#microsoft.graph.groupAssignmentTarget']];
|
|
$currentAssignmentsB = [['target' => ['groupId' => 'group-y'], '@odata.type' => '#microsoft.graph.groupAssignmentTarget']];
|
|
|
|
PolicyVersion::factory()->for($tenantB)->for($policyB)->create([
|
|
'version_number' => 1,
|
|
'policy_type' => $policyB->policy_type,
|
|
'captured_at' => now()->subDays(2)->subMinute(),
|
|
'assignments' => $baselineAssignmentsB,
|
|
'assignments_hash' => hash('sha256', json_encode($baselineAssignmentsB)),
|
|
]);
|
|
|
|
PolicyVersion::factory()->for($tenantB)->for($policyB)->create([
|
|
'version_number' => 2,
|
|
'policy_type' => $policyB->policy_type,
|
|
'captured_at' => now()->subDay()->subMinute(),
|
|
'assignments' => $currentAssignmentsB,
|
|
'assignments_hash' => hash('sha256', json_encode($currentAssignmentsB)),
|
|
]);
|
|
|
|
$generator = app(DriftFindingGenerator::class);
|
|
$generator->generate($tenantA, $baselineA, $currentA, $scopeKey);
|
|
|
|
expect(Finding::query()->where('tenant_id', $tenantA->getKey())->count())->toBe(1);
|
|
expect(Finding::query()->where('tenant_id', $tenantB->getKey())->count())->toBe(0);
|
|
});
|