ahmido
73a879d061
## Summary
- implement Spec 147 for workspace-first tenant selector and remembered tenant context enforcement
- harden canonical and tenant-bound route behavior so selected tenant mismatch stays informational
- fix drift finding subject fallback for workspace-safe RBAC identifiers and centralize finding subject resolution
## Testing
- vendor/bin/sail artisan test --compact tests/Feature/Filament/FindingViewRbacEvidenceTest.php tests/Feature/Findings/FindingsListDefaultsTest.php
- vendor/bin/sail bin pint --dirty --format agent
## Notes
- branch pushed at de0679cd8b
- includes the spec artifacts under specs/147-tenant-selector-remembered-context-enforcement/
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #176
60 lines
2.0 KiB
PHP
60 lines
2.0 KiB
PHP
<?php
|
|
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('returns 404 for non-members on tenant dashboard route', function () {
|
|
$tenant = Tenant::factory()->create(['external_id' => 'tenant-a']);
|
|
$user = User::factory()->create();
|
|
|
|
$this->actingAs($user)
|
|
->get("/admin/t/{$tenant->external_id}")
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('allows members to access the tenant dashboard route', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
|
|
$this->actingAs($user)
|
|
->get("/admin/t/{$tenant->external_id}")
|
|
->assertSuccessful();
|
|
});
|
|
|
|
it('enforces panel boundary semantics between workspace routes and tenant routes', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
$otherTenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'external_id' => 'boundary-tenant-b',
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get("/admin/tenants/{$tenant->external_id}")
|
|
->assertSuccessful();
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get("/admin/t/{$otherTenant->external_id}")
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('keeps non-member tenant-bound requests as 404 even when another tenant is selected', function () {
|
|
[$user, $selectedTenant] = createUserWithTenant(role: 'readonly');
|
|
$otherTenant = Tenant::factory()->active()->create([
|
|
'workspace_id' => (int) $selectedTenant->workspace_id,
|
|
'external_id' => 'hidden-tenant-b',
|
|
]);
|
|
|
|
Filament::setTenant($selectedTenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $selectedTenant->workspace_id])
|
|
->get("/admin/t/{$otherTenant->external_id}")
|
|
->assertNotFound();
|
|
});
|