Kontext / Ziel Diese PR standardisiert Tenant‑RBAC Enforcement in der Filament‑UI: statt ad-hoc Gate::*, abort_if/abort_unless und kopierten ->visible()/->disabled()‑Closures gibt es jetzt eine zentrale, wiederverwendbare Implementierung für Actions (Header/Table/Bulk). Links zur Spec: spec.md plan.md quickstart.md Was ist drin Neue zentrale Helper-API: UiEnforcement (Tenant-plane RBAC‑UX “source of truth” für Filament Actions) Standardisierte Tooltip-Texte und Context-DTO (UiTooltips, TenantAccessContext) Migration vieler tenant‑scoped Filament Action-Surfaces auf das Standardpattern (ohne ad-hoc Auth-Patterns) CI‑Guard (Test) gegen neue ad-hoc Patterns in app/Filament/**: verbietet Gate::allows/denies/check/authorize, use Illuminate\Support\Facades\Gate, abort_if/abort_unless Legacy-Allowlist ist aktuell leer (neue Verstöße failen sofort) RBAC-UX Semantik (konsequent & testbar) Non-member: UI Actions hidden (kein Tenant‑Leak); Execution wird blockiert (Filament hidden→disabled chain), Defense‑in‑depth enthält zusätzlich serverseitige Guards. Member ohne Capability: Action visible aber disabled + Standard-Tooltip; Execution wird blockiert (keine Side Effects). Member mit Capability: Action enabled und ausführbar. Destructive actions: über ->destructive() immer mit ->requiresConfirmation() + klare Warntexte (Execution bleibt über ->action(...)). Wichtig: In Filament v5 sind hidden/disabled Actions typischerweise “silently blocked” (200, keine Ausführung). Die Tests prüfen daher UI‑State + “no side effects”, nicht nur HTTP‑Statuscodes. Sicherheit / Scope Keine neuen DB-Tabellen, keine Migrations, keine Microsoft Graph Calls (DB‑only bei Render; kein outbound HTTP). Tenant Isolation bleibt Isolation‑Boundary (deny-as-not-found auf Tenant‑Ebene, Capability erst nach Membership). Kein Asset-Setup erforderlich; keine neuen Filament Assets. Compliance Notes (Repo-Regeln) Filament v5 / Livewire v4.0+ kompatibel. Keine Änderungen an Provider‑Registrierung (Laravel 11+/12: providers.php bleibt der Ort; hier unverändert). Global Search: keine gezielte Änderung am Global‑Search-Verhalten in dieser PR. Tests / Qualität Pest Feature/Unit Tests für Member/Non-member/Tooltip/Destructive/Regression‑Guard. Guard-Test: “No ad-hoc Filament auth patterns”. Full suite laut Tasks: vendor/bin/sail artisan test --compact → 837 passed, 5 skipped. Checklist: requirements.md vollständig (16/16). Review-Fokus API‑Usage in neuen/angepassten Filament Actions: UiEnforcement::forAction/forTableAction/forBulkAction(...)->requireCapability(...)->apply() Guard-Test soll “red” werden, sobald jemand neue ad-hoc Auth‑Patterns einführt (by design). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #81
115 lines
3.7 KiB
PHP
115 lines
3.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\TenantResource\Pages\ViewTenant;
|
|
use App\Filament\Resources\TenantResource\RelationManagers\TenantMembershipsRelationManager;
|
|
use App\Models\TenantMembership;
|
|
use App\Models\User;
|
|
use Livewire\Livewire;
|
|
|
|
it('allows an owner to add, change role, and remove members', function (): void {
|
|
[$owner, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$tenant->makeCurrent();
|
|
|
|
$member = User::factory()->create(['name' => 'Member User']);
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('add_member', null, [
|
|
'user_id' => $member->getKey(),
|
|
'role' => 'readonly',
|
|
]);
|
|
|
|
$membership = TenantMembership::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('user_id', $member->getKey())
|
|
->first();
|
|
|
|
expect($membership)->not->toBeNull();
|
|
expect($membership?->role)->toBe('readonly');
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('change_role', $membership, [
|
|
'role' => 'manager',
|
|
]);
|
|
|
|
expect($membership?->refresh()->role)->toBe('manager');
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('remove', $membership);
|
|
|
|
expect(TenantMembership::query()->whereKey($membership?->getKey())->exists())->toBeFalse();
|
|
});
|
|
|
|
it('hides membership management actions from non-owners', function (): void {
|
|
[$manager, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$tenant->makeCurrent();
|
|
|
|
$member = User::factory()->create();
|
|
$member->tenants()->syncWithoutDetaching([
|
|
$tenant->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
$membership = TenantMembership::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('user_id', $member->getKey())
|
|
->firstOrFail();
|
|
|
|
Livewire::actingAs($manager)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->assertTableActionVisible('add_member')
|
|
->assertTableActionDisabled('add_member')
|
|
->assertTableActionVisible('change_role', $membership)
|
|
->assertTableActionDisabled('change_role', $membership)
|
|
->assertTableActionVisible('remove', $membership)
|
|
->assertTableActionDisabled('remove', $membership);
|
|
});
|
|
|
|
it('prevents removing or demoting the last owner', function (): void {
|
|
[$owner, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$tenant->makeCurrent();
|
|
|
|
$ownerMembership = TenantMembership::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('user_id', $owner->getKey())
|
|
->firstOrFail();
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('change_role', $ownerMembership, [
|
|
'role' => 'manager',
|
|
]);
|
|
|
|
expect($ownerMembership->refresh()->role)->toBe('owner');
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('remove', $ownerMembership);
|
|
|
|
expect(TenantMembership::query()->whereKey($ownerMembership->getKey())->exists())->toBeTrue();
|
|
});
|