ahmido
d6e7de597a
Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
76 lines
2.5 KiB
PHP
76 lines
2.5 KiB
PHP
<?php
|
|
|
|
use App\Models\Finding;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Services\Drift\DriftFindingGenerator;
|
|
|
|
test('drift generation is deterministic for the same baseline/current', function () {
|
|
[, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$scopeKey = hash('sha256', 'scope-determinism');
|
|
|
|
$baseline = createInventorySyncOperationRun($tenant, [
|
|
'selection_hash' => $scopeKey,
|
|
'selection_payload' => ['policy_types' => ['settingsCatalogPolicy']],
|
|
'status' => 'success',
|
|
'finished_at' => now()->subDays(2),
|
|
]);
|
|
|
|
$current = createInventorySyncOperationRun($tenant, [
|
|
'selection_hash' => $scopeKey,
|
|
'selection_payload' => ['policy_types' => ['settingsCatalogPolicy']],
|
|
'status' => 'success',
|
|
'finished_at' => now()->subDay(),
|
|
]);
|
|
|
|
$policy = Policy::factory()->for($tenant)->create([
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
]);
|
|
|
|
$baselineAssignments = [
|
|
['target' => ['@odata.type' => '#microsoft.graph.groupAssignmentTarget', 'groupId' => 'group-a']],
|
|
['target' => ['@odata.type' => '#microsoft.graph.groupAssignmentTarget', 'groupId' => 'group-b']],
|
|
];
|
|
|
|
$currentAssignments = [
|
|
['target' => ['@odata.type' => '#microsoft.graph.groupAssignmentTarget', 'groupId' => 'group-c']],
|
|
];
|
|
|
|
PolicyVersion::factory()->for($tenant)->for($policy)->create([
|
|
'version_number' => 1,
|
|
'policy_type' => $policy->policy_type,
|
|
'captured_at' => $baseline->finished_at->copy()->subMinute(),
|
|
'assignments' => $baselineAssignments,
|
|
]);
|
|
|
|
PolicyVersion::factory()->for($tenant)->for($policy)->create([
|
|
'version_number' => 2,
|
|
'policy_type' => $policy->policy_type,
|
|
'captured_at' => $current->finished_at->copy()->subMinute(),
|
|
'assignments' => $currentAssignments,
|
|
]);
|
|
|
|
$generator = app(DriftFindingGenerator::class);
|
|
|
|
$created1 = $generator->generate($tenant, $baseline, $current, $scopeKey);
|
|
$fingerprints1 = Finding::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->pluck('fingerprint')
|
|
->sort()
|
|
->values()
|
|
->all();
|
|
|
|
$created2 = $generator->generate($tenant, $baseline, $current, $scopeKey);
|
|
$fingerprints2 = Finding::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->pluck('fingerprint')
|
|
->sort()
|
|
->values()
|
|
->all();
|
|
|
|
expect($created1)->toBeGreaterThan(0);
|
|
expect($created2)->toBe(0);
|
|
expect($fingerprints2)->toBe($fingerprints1);
|
|
});
|