ahmido
6a15fe978a
## Summary Automated scanning of Entra ID directory roles to surface high-privilege role assignments as trackable findings with alerting support. ## What's included ### Core Services - **EntraAdminRolesReportService** — Fetches role definitions + assignments via Graph API, builds payload with fingerprint deduplication - **EntraAdminRolesFindingGenerator** — Creates/resolves/reopens findings based on high-privilege role catalog - **HighPrivilegeRoleCatalog** — Curated list of high-privilege Entra roles (Global Admin, Privileged Auth Admin, etc.) - **ScanEntraAdminRolesJob** — Queued job orchestrating scan → report → findings → alerts pipeline ### UI - **AdminRolesSummaryWidget** — Tenant dashboard card showing last scan time, high-privilege assignment count, scan trigger button - RBAC-gated: `ENTRA_ROLES_VIEW` for viewing, `ENTRA_ROLES_MANAGE` for scan trigger ### Infrastructure - Graph contracts for `entraRoleDefinitions` + `entraRoleAssignments` - `config/entra_permissions.php` — Entra permission registry - `StoredReport.fingerprint` migration (deduplication support) - `OperationCatalog` label + duration for `entra.admin_roles.scan` - Artisan command `entra:scan-admin-roles` for CLI/scheduled use ### Global UX improvement - **SummaryCountsNormalizer**: Zero values filtered, snake_case keys humanized (e.g. `report_deduped: 1` → `Report deduped: 1`). Affects all operation notifications. ## Test Coverage - **12 test files**, **79+ tests**, **307+ assertions** - Report service, finding generator, job orchestration, widget rendering, alert integration, RBAC enforcement, badge mapping ## Spec artifacts - `specs/105-entra-admin-roles-evidence-findings/tasks.md` — Full task breakdown (38 tasks, all complete) - `specs/105-entra-admin-roles-evidence-findings/checklists/requirements.md` — All items checked ## Files changed 46 files changed, 3641 insertions(+), 15 deletions(-) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #128
65 lines
2.5 KiB
PHP
65 lines
2.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Services\EntraAdminRoles\HighPrivilegeRoleCatalog;
|
|
|
|
it('classifies Global Administrator template_id as critical', function (): void {
|
|
$catalog = new HighPrivilegeRoleCatalog;
|
|
|
|
expect($catalog->classify('62e90394-69f5-4237-9190-012177145e10', null))->toBe('critical');
|
|
});
|
|
|
|
it('classifies all 5 other high-privilege template_ids as high', function (string $templateId): void {
|
|
$catalog = new HighPrivilegeRoleCatalog;
|
|
|
|
expect($catalog->classify($templateId, null))->toBe('high');
|
|
})->with([
|
|
'Privileged Role Administrator' => 'e8611ab8-c189-46e8-94e1-60213ab1f814',
|
|
'Security Administrator' => '194ae4cb-b126-40b2-bd5b-6091b380977d',
|
|
'Conditional Access Administrator' => 'b1be1c3e-b65d-4f19-8427-f6fa0d97feb9',
|
|
'Exchange Administrator' => '29232cdf-9323-42fd-ade2-1d097af3e4de',
|
|
'Authentication Administrator' => 'c4e39bd9-1100-46d3-8c65-fb160da0071f',
|
|
]);
|
|
|
|
it('falls back to display_name when template_id does not match', function (): void {
|
|
$catalog = new HighPrivilegeRoleCatalog;
|
|
|
|
expect($catalog->classify('unknown-template-id', 'Security Administrator'))->toBe('high');
|
|
});
|
|
|
|
it('returns null for unknown template_id and unknown display_name', function (): void {
|
|
$catalog = new HighPrivilegeRoleCatalog;
|
|
|
|
expect($catalog->classify('unknown-template-id', 'Custom Role'))->toBeNull();
|
|
});
|
|
|
|
it('returns null for unknown template_id with null display_name', function (): void {
|
|
$catalog = new HighPrivilegeRoleCatalog;
|
|
|
|
expect($catalog->classify('unknown-template-id', null))->toBeNull();
|
|
});
|
|
|
|
it('identifies Global Administrator via isGlobalAdministrator', function (): void {
|
|
$catalog = new HighPrivilegeRoleCatalog;
|
|
|
|
expect($catalog->isGlobalAdministrator('62e90394-69f5-4237-9190-012177145e10', null))->toBeTrue()
|
|
->and($catalog->isGlobalAdministrator('e8611ab8-c189-46e8-94e1-60213ab1f814', null))->toBeFalse();
|
|
});
|
|
|
|
it('returns all 6 entries from allTemplateIds', function (): void {
|
|
$catalog = new HighPrivilegeRoleCatalog;
|
|
$all = $catalog->allTemplateIds();
|
|
|
|
expect($all)->toHaveCount(6)
|
|
->and($all)->toHaveKey('62e90394-69f5-4237-9190-012177145e10');
|
|
});
|
|
|
|
it('matches display_name case-insensitively', function (): void {
|
|
$catalog = new HighPrivilegeRoleCatalog;
|
|
|
|
expect($catalog->classify('unknown-id', 'GLOBAL ADMINISTRATOR'))->toBe('critical')
|
|
->and($catalog->classify('unknown-id', 'global administrator'))->toBe('critical')
|
|
->and($catalog->classify('unknown-id', 'Global Administrator'))->toBe('critical');
|
|
});
|